<deepender>
doesn't give output even in verbose mode
<deepender>
one of test which is failing is this:
<deepender>
rspec ./spec/install/gemfile/git_spec.rb:177 # bundle install with git sources when specifying local override uses the local repository instead of checking a new one out
<deepender>
can you give just a head start for this I tried but was not able to understand the code
<tmoore>
OK so it looks like that test is looking for something in the "Using" line, so probably the best solution is to change the test to pass --verbose (once that part is working properly)
robbyoconnor has quit [Quit: Konversation terminated!]
<deepender>
yes
<tmoore>
I'm not sure why Bundler.ui.debug isn't outputting in verbose mode... I was going by the code in cli.rb: "Bundler.ui.level = "debug" if options["verbose"]"
<deepender>
I don't know
<deepender>
but let me check that in my cli code
<deepender>
Yes you are right
<deepender>
its there
<deepender>
don't you think the code means print everything in debug mode
<deepender>
if options is verbose
robbyoconnor has joined #bundler
<deepender>
I tried Bundler.ui.debug don't print anything
<deepender>
even just given simply
<deepender>
like I tired Bundler.ui.debug to print something
<deepender>
it doesn't print anything
<deepender>
tmoore:
<tmoore>
yeah I'm seeing the same thing but I'm not sure why... I'll see if I can figure it out, but I need to finish something else up first
<deepender>
cool
cwebber has quit []
cwebber has joined #bundler
cwebber has quit [Client Quit]
Cidan is now known as zz_Cidan
patcon has quit [Read error: Connection reset by peer]
patcon has joined #bundler
patcon has quit [Read error: Connection reset by peer]
patcon has joined #bundler
zz_Cidan is now known as Cidan
Cidan is now known as zz_Cidan
patcon_ has joined #bundler
patcon has quit [Ping timeout: 260 seconds]
zz_Cidan is now known as Cidan
deepender has quit [Ping timeout: 246 seconds]
Cidan is now known as zz_Cidan
deepender has joined #bundler
<tmoore>
deepender: it looks like somehow the --verbose flag broke in Bundler 1.5
<tmoore>
I'll file an issue for that and hopefully we'll get it fixed soon
<deepender>
cool
<deepender>
cool
<deepender>
Can I fix that
<deepender>
if you can tell me from where to start. tmoore:
<tmoore>
Sure. I'm not totally sure what's wrong, so I was going to start by comparing cli.rb in the two versions
<deepender>
and I told you I should be thankfull for your patience to help me
<tmoore>
well, it's always nice when more people are willing to contribute
<tmoore>
we want people to feel welcome
<deepender>
tmoore:
<deepender>
I told this same error
<deepender>
to indirect when
<deepender>
I first start on that feature
<deepender>
I think in 1.3 verbose was an alias of Debug code =1
<deepender>
but not in 1.5
<deepender>
tmoore:
<tmoore>
yeah we all missed the fact that the output had changed in 1.5... I'm pretty sure that was unintentional
<deepender>
there is no testcase also for this
<deepender>
I think first logical step for me is to compate
<deepender>
the procedure of debug = 1
<deepender>
and bundle -- verbose
<deepender>
can you tell what is the actual command of Debug , tmoore:
<deepender>
I forgot indirect told me once
<tmoore>
Hmm with DEBUG=1 I still get different output on 1.5.1 and 1.3.5
<tmoore>
on 1.3.5 it's the same as --verbose, on 1.5.1 it's totally different
<tmoore>
maybe because of the parallel install change
<tmoore>
I'm not sure how all of this stuff works TBH :-)
<tmoore>
OK right so in ui.rb it looks for ENV['DEBUG'] when setting the default log level
<tmoore>
so what that level means is that you can call Bundler.ui.debug all you want, but it will only actually output if the level is debug
<deepender>
tmoore: can you tell the actual full command.
<tmoore>
I'm running 'DEBUG=1 bundle' if that's what you mean
<deepender>
yeah
<deepender>
one more thing do I need to download the branch of 1.3 separately
<deepender>
to use it for testing
<deepender>
I think now I am working on 2.0
<deepender>
you are right
<deepender>
DEBUG=1 dbundle install --verbose
<deepender>
give what is needed
<deepender>
with Bundler.ui.debug
<deepender>
tmoore:
<tmoore>
You can switch between branches using git, or you can install Bundler 1.3.5 using gem
<tmoore>
I think I see the problem
<tmoore>
This line is new in 1.5: options ||= {}
<tmoore>
previously it was calling options as a method, but that line declares it as a local variable
<tmoore>
when I comment it out, --verbose seems to work again... but I'm not sure what else might break
<tmoore>
and you are right that there should be RSpec tests for this
<deepender>
yeah
<deepender>
I tried writing rspec for the project and It was a difficult for me to understans
<tmoore>
so if you'd like to work on a pull request for this, I'll leave it to you, and I can review it and help if you get stuck at all
<deepender>
cool
<tmoore>
yeah... the RSpec is difficult for me to understand too :-)
<deepender>
no you do it
<deepender>
if you can fix early
<tmoore>
OK I might be turning the computer off for the night soon, so we'll see who gets to it first ;)
Who has joined #bundler
<deepender>
are they generated
<deepender>
or written
<deepender>
by someone
<tmoore>
hand written
<tmoore>
have you used RSpec before in other projects or is it new to you?
<deepender>
I used
<deepender>
in some rails project
<tmoore>
cool
<deepender>
but only 2 till now
<deepender>
personal project
<deepender>
so the task if I summarize is to write rspec for the bundle --verbsoe
<tmoore>
yeah the tests for Bundler are all very high-level integration tests at the moment, which makes it hard to figure out what's going on when something fails
<deepender>
in debug mode
<tmoore>
yeah, I guess we want a test that ensures that the --verbose flag actually sets the output level correctly to debug
<tmoore>
and another that DEBUG=1 in the environment does the same thing
<deepender>
okey , it has to be done in 1.5
<tmoore>
yeah that would be best I think
<deepender>
cool
<deepender>
I will try to work
<deepender>
and the change which you did which it makes it work was in 1.5
<tmoore>
yeah I just commented out that line for now
<tmoore>
I'm running the tests against that now to see if it causes something else to break
<deepender>
you also pushed the code
<deepender>
yeah
<tmoore>
no not yet
<deepender>
ohh
<tmoore>
I'll try to track down why it was added in the first place, too
<deepender>
really appreciate your patience and helpful advice
JordanFaust_ has joined #bundler
<deepender>
I am proud to say that I am involved in bundler
<deepender>
even in a small way
<tmoore>
well I only started with it a few months ago myself, and I was impressed at how inviting it is to new contributors so I'm just trying to do my part :-)
<deepender>
tmoore: will you be available for google voice chat
<deepender>
sometime
<deepender>
just have small doubts
<deepender>
in bundler
<deepender>
whenever you are free
<tmoore>
yeah I could probably chat tomorrow night
<tmoore>
I'll find you here tomorrow and we can work something out
deepender has quit [Ping timeout: 252 seconds]
deepender has joined #bundler
retro|cz has joined #bundler
JordanFaust_ has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
andrein has joined #bundler
Who has quit [Quit: Who]
andrein has quit [Ping timeout: 264 seconds]
pipecloud_ is now known as pipecloud
pipecloud has quit [Changing host]
pipecloud has joined #bundler
pipecloud has joined #bundler
JordanFaust_ has joined #bundler
cha1tanya has joined #bundler
cha1tanya has quit [Read error: Connection reset by peer]
cha1tanya has joined #bundler
JordanFaust_ has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
samphippen has joined #bundler
pipecloud has quit [*.net *.split]
JSharp has quit [*.net *.split]
ereslibre_laptop has quit [*.net *.split]
sneak_ has quit [*.net *.split]
sneak has joined #bundler
sneak has quit [Changing host]
sneak has joined #bundler
JSharp has joined #bundler
pipecloud has joined #bundler
ereslibre has joined #bundler
ereslibre has quit [Changing host]
ereslibre has joined #bundler
danp has quit [Quit: bai]
danp has joined #bundler
johnbeynon has joined #bundler
johnbeynon has quit [Quit: Computer has gone to sleep.]
johnbeynon has joined #bundler
johnbeynon has quit [Client Quit]
andrein has joined #bundler
andrein has quit [Changing host]
andrein has joined #bundler
samphippen has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
samphippen has joined #bundler
Who has joined #bundler
cha1tanya has quit [Ping timeout: 265 seconds]
patcon_ is now known as patcon
cha1tanya has joined #bundler
patcon is now known as blahbleehloo
blahblee_ has joined #bundler
blahbleehloo has quit [Ping timeout: 272 seconds]
<deepender>
anyone:
<deepender>
indirect:
<deepender>
there?
blahblee_ is now known as patcon
cha1tanya has quit [Ping timeout: 272 seconds]
andrein has quit [Ping timeout: 272 seconds]
Who has quit [Quit: Who]
johnbeynon has joined #bundler
indirect_ has joined #bundler
JSharp has quit [*.net *.split]
henrikhodne has quit [*.net *.split]
indirect has quit [Ping timeout: 260 seconds]
indirect_ is now known as indirect
7CBAANUJ9 has joined #bundler
7CBAANUJ9 has joined #bundler
7CBAANUJ9 has quit [Changing host]
retro_ has joined #bundler
amateurhuman_ has joined #bundler
lmarburger has quit [Ping timeout: 265 seconds]
retro|cz has quit [Read error: Operation timed out]