02:01 <FromGitter> <Blacksmoke16> @shreeve you can unadd me from that repo btw

07:00 <FromGitter> <j8r> Why attributes in Crystal are called annotations? This can be confused with the existing Type Annotations, which aren't the same

07:03 <FromGitter> <r00ster91> asterite decided to rename them in 6063

07:11 <FromGitter> <j8r> I just got this PR with GH search

07:12 <FromGitter> <j8r> https://github.com/crystal-lang/crystal/pull/7648#issuecomment-483966008

07:15 <FromGitter> <j8r> `TypeNode#annotated_types` is a bit confusing, we don't really know if this is about type annotations or type annotation in annotation

09:58 <FromGitter> <j8r> I just setup Drone CI - it's nice!

10:09 <FromGitter> <j8r> Open Source, and ability to build on arm64 and armhf

11:45 <FromGitter> <vladfaust> Does it have a publicly accessible build history for a project? Does it have GitHub integration (i.e. build pull requests)?

12:07 <FromGitter> <Blacksmoke16> @j8r Im not really sure what you mean? It would types that are annotated with `self`

12:07 <FromGitter> <Blacksmoke16> `MyAnnotation.annotated_types`

12:12 <FromGitter> <Blacksmoke16> And whats not the same? An annotation is still an annotation no matter what it is on

12:39 <FromGitter> <j8r> if we see in the docs annotated types, this isn't obvious what this means

12:39 <FromGitter> <j8r> in `a : String, b : Int32`, `String` and `int32` are annotated types too

12:40 <z64> strictly speaking, those are type restrictions, not annotations

12:41 <z64> and they are not "annotated types", the thing being annotated is an argument or ivar

13:19 <FromGitter> <Blacksmoke16> ^

13:22 <FromGitter> <j8r> that's not really what said in docs

13:22 <FromGitter> <j8r> https://crystal-lang.org/reference/syntax_and_semantics/type_inference.html

13:22 <FromGitter> <j8r> > Crystal's philosophy is to require as few type annotations as possible. However, some type annotations are required.

13:23 <FromGitter> <j8r> And what's called annotations is called attributes https://crystal-lang.org/reference/syntax_and_semantics/attributes.html

13:23 <FromGitter> <Blacksmoke16> id prob update the docs to say `as few type restrictions`, that would be the more clear way

13:23 <FromGitter> <Blacksmoke16> they're annotations now, were renamed a year or so ago

13:23 <FromGitter> <Blacksmoke16> i can make a PR to update some things

13:23 <FromGitter> <Blacksmoke16> in the git book

13:25 <FromGitter> <j8r> The problem isn't only in Crystal

13:25 <FromGitter> <j8r> This is a very common term in programming, too https://duckduckgo.com/?q=type+annotation&t=canonical&ia=web

13:26 <FromGitter> <j8r> This aren't always type restriction, for instance take ivars

13:28 <FromGitter> <j8r> Take this for instance https://carc.in/#/r/6ql3

13:28 <FromGitter> <Blacksmoke16> do you have a better name?

13:29 <FromGitter> <Blacksmoke16> they keyword to define annotations is `annotation`

13:29 <FromGitter> <j8r> type annotation, that act sometimes has restriction

13:29 <FromGitter> <j8r> I'd say this are type annotations

13:30 <FromGitter> <Blacksmoke16> then what would you call like ⏎ ⏎ ```@[Foo] ⏎ class Klass ⏎ end``` [https://gitter.im/crystal-lang/crystal?at=5cb72a641cd0b8307d29054f]

13:30 <FromGitter> <Blacksmoke16> an `annotated type`, a type with an annotation

13:35 <FromGitter> <j8r> `annotated_typenodes`? That's what they return, no?

13:40 <FromGitter> <Blacksmoke16> i suppose but that would be the first macro method where we do something like that. For `Union` its `.union_types` not `union_typenodes`

13:41 <FromGitter> <j8r> Not sure, I don't know. I just pointed out it's a bit confusing

13:41 <FromGitter> <Blacksmoke16> kinda hard when you have two similarly named things

13:42 <z64> i think its simple if we are just consistent when talking about type restrictions. i'm not sure what you mean about ivars, as i've always thought of it as "@foo : Bar restricts @foo to being of type Bar, instead of letting it be inferred if possible"

13:42 <FromGitter> <Blacksmoke16> granted this is macro related, so its not like its going to be an issue for new people, is under the assumption you already know what macros are and such

13:42 <FromGitter> <Blacksmoke16> yea, I can make a PR later to update some git book docs, finally add my section on annotations

13:44 <FromGitter> <j8r> z64: what do yout think of this https://carc.in/#/r/6ql8

13:45 <FromGitter> <Blacksmoke16> its defining a getter for `num` with a return type restriction of `Int32`

13:45 <FromGitter> <j8r> I guess you're right @Blacksmoke16 , this is an advanced topic

13:45 <FromGitter> <j8r> But this doesn't restrict anything, it's already `Int32`

13:46 <FromGitter> <j8r> and can't be another type, because of the constructor type restriction

13:48 <FromGitter> <Blacksmoke16> https://carc.in/#/r/6qlg

13:48 <FromGitter> <Blacksmoke16> it still restricts the value that `num` can be

13:48 <z64> indeed, getter expands to @num : Int32

13:49 <FromGitter> <kinxer> https://carc.in/#/r/6qli

13:49 <FromGitter> <kinxer> Sometimes people re-open things.

13:49 <FromGitter> <Blacksmoke16> ye, basically overrides the type restriction of `num` in the initializer

13:49 <FromGitter> <Blacksmoke16> https://github.com/crystal-lang/crystal/blob/302b606a753bd97bc3f1f55d6adcbbdf0d8a5bf8/src/object.cr#L389 because of this line

13:50 <FromGitter> <j8r> Ok

13:51 <FromGitter> <j8r> it wasn't a good example 😅

13:51 <FromGitter> <j8r> https://carc.in/#/r/6qll

13:52 <z64> that still restricts the type of the local var https://carc.in/#/r/6qln

13:53 <FromGitter> <Blacksmoke16> and since there is no other *possible* assignment it can only ever be a string

13:53 <FromGitter> <j8r> I got the perfect example, one can say it's a bug https://carc.in/#/r/6qlq

13:54 <FromGitter> <j8r> sorry, https://carc.in/#/r/6qlr

13:54 <z64> not a bug, just a well known missing feature :P

13:56 <FromGitter> <Blacksmoke16> https://github.com/crystal-lang/crystal/issues/3546

14:02 <FromGitter> <j8r> You're right, mostly type annotations are restrictions (not in this very case, alas)

14:03 <FromGitter> <K155K155BAN6BAN6> will crystal be participating in google season of docs this year?

14:03 <FromGitter> <K155K155BAN6BAN6> https://developers.google.com/season-of-docs/

14:09 <FromGitter> <Blacksmoke16> yea so some PRs on the git book would prob be a good idea