kevery has quit [Read error: Connection reset by peer]
kevery1 is now known as kevery
kaspter has quit [Ping timeout: 260 seconds]
kaspter has joined #linux-rockchip
vicencb has joined #linux-rockchip
kevery1 has joined #linux-rockchip
kevery has quit [Read error: Connection reset by peer]
kevery1 is now known as kevery
camus1 has joined #linux-rockchip
kaspter has quit [Read error: Connection reset by peer]
camus1 is now known as kaspter
ckeepax has quit [Ping timeout: 260 seconds]
<macc24>
is powering off rk3326/px30 boards supported? rk817 pmic
<robmur01>
poweroff via PSCI depends on how complete the firmware is... letting the kernel do it directly ("rockchip,system-power-controller" in DT) *should* work
<macc24>
PSCI?
<macc24>
the firmware as arm-trusted-firmware?
<robmur01>
especially since the last person to touch that part of the PMIC driver was, er, me
<macc24>
the firmware is the mainline u-boot
<macc24>
boot firmware*
<macc24>
i modified dt and kernel config, compiling...
<robmur01>
you must have *some* form of TF-A in there, or you wouldn't get very far bringing up secondary CPUs in early boot ;)
<robmur01>
right, so unless the PMIC is given authority, poweroff will simply involve issuing a PSCI_SYSTEM_OFF call to BL31 and letting it do... whatever.
<robmur01>
Which in practice may well be nothing
<macc24>
yeah it does nothing
<macc24>
now it has stopped detecting my sd card in linux ,_,
<macc24>
robmur01: i added rockchip,system-power-controller, https://bpa.st/PLFA and it still doesn't power off
<robmur01>
macc24: it's not a compatible... but you already have it there anyway (line 14)
<robmur01>
in that case, something might be amiss with sending the shutdown command over I2C :/
<macc24>
is there kconfig option i need to set?
kaspter has joined #linux-rockchip
<robmur01>
hmm, actually, looking back at the PMIC code, RK817 never had pm_power_off support (i.e. kernel-based I2C shutdown)
<robmur01>
so presumably it's expected to be operating in firmware-wiggles-a-GPIO mode - maybe try *removing* the system-power-controller property?
<macc24>
removed
<robmur01>
failing that, it'd be a case of fiddling with rk808_pm_power_off() to add the relevant bits
<macc24>
it works!
<macc24>
mmind00: was there a good reason why rockchip,system-power-controller was added to rockchip-odroid-go2.dts?
<mmind00>
macc24: not sure - probably just picked with the vendor dts source ... though I'm not sure what the deal with the system-power-controller is in recent times
<robmur01>
most likely just downstream copypasta ;)
<mmind00>
drivers/mfd/rk808.c attaches to 'if (of_property_read_bool(np, "rockchip,system-power-controller")) {'
<mmind00>
didn't we have a generic "system-power-controller" at some point?
<mmind00>
grepping through sources there are a number of $vendor,system-power-controller properties in use ... and my memory doesn't serve what happened to the generalization
<mmind00>
and just now I saw the backlog ... regarding removing that property :-D
<robmur01>
either way, it should now always be meaningful in the sense of "don't use firmware-based poweroff", which may not be the case downstream with older kernels
<robmur01>
where it previously would have tended to do nothing if (likely) PSCI registered its pm_power_off hook first
<robmur01>
thus there's every chance it's simply been blindly copied around in downstream trees without having any detrimental effect until thrown at a recent mainline kernel
fncapkle has joined #linux-rockchip
kevery1 has joined #linux-rockchip
kevery has quit [Ping timeout: 260 seconds]
kevery1 is now known as kevery
<mmind00>
macc24: "git send-email"? ;-)
* macc24
sighs
<macc24>
ill make an attempt later
<macc24>
probably
ckeepax has joined #linux-rockchip
inode has quit [Ping timeout: 260 seconds]
stikonas has quit [Remote host closed the connection]
stikonas has joined #linux-rockchip
kaspter has quit [Ping timeout: 260 seconds]
kaspter has joined #linux-rockchip
kevery1 has joined #linux-rockchip
kevery has quit [Ping timeout: 260 seconds]
kevery1 is now known as kevery
<tuxd3v>
robmur01, many thanks for the patch in the other day :)
vicencb has quit [Quit: Leaving.]
alpernebbi has quit [Quit: alpernebbi]
stikonas has quit [Remote host closed the connection]