07:58 <st-gourichon-fid> pepijndevos, if my PR was useful to your "good news! vexrisc boots to console no" then I'm happy about it, any way that's okay. https://github.com/enjoy-digital/litex/pull/663

07:58 <tpb> Title: Fix SoC CPU crash on minimal variants on call to flush_cpu_dcache(). by fidergo-stephane-gourichon · Pull Request #663 · enjoy-digital/litex · GitHub (at github.com)

11:12 <st-gourichon-fid> Hi! When building documentation for a design we get "AttributeError: 'CDCUsbPHY' object has no attribute 'duid'". Investigating the hypothesis that this means "document id" and something is missing in CSCUsbPHY. Any hint appreciated.

11:16 <st-gourichon-fid> on calling generate_docs(soc, "build/"+target+"/documentation")

11:17 <zyp> sounds to me like the CDCUsbPHY instance gets passed to some code that expects a CSR instance (the CSR instances have a duid attribute)

11:17 <zyp> i.e. you're probably passing in the wrong object somewhere

11:18 <st-gourichon-fid> Thanks zyp for the feedback. The design compiles and works fine, only generating doc fails like this.

11:21 <zyp> can you pastebin the full traceback of the error?

11:31 <st-gourichon-fid> yes

11:35 <st-gourichon-fid> https://paste.ubuntu.com/p/SHngNPcQbw/

11:35 <tpb> Title: Ubuntu Pastebin (at paste.ubuntu.com)

11:41 <zyp> ah, right, it's not the CSR duid, it's the ModuleDoc duid

11:43 <zyp> where does the CDCUsbPHY come from?

11:43 <st-gourichon-fid> Strangely, the code does test if object is of ModuleDoc class.

11:43 <st-gourichon-fid> Let me check.

11:44 <st-gourichon-fid> In ValentyUSB

11:48 <st-gourichon-fid> We were instructed to follow https://gist.github.com/enjoy-digital/82ed88b77ef0b1e3e91b0592e44eaa14#file-gistfile1-txt-L83 which requires branch hw_cdc_eptri of valentyusb

11:48 <tpb> Title: Fomu · GitHub (at gist.github.com)

11:50 <zyp> ah, right

11:50 <st-gourichon-fid> https://github.com/gregdavill/valentyusb/blob/hw_cdc_eptri/valentyusb/usbcore/cpu/cdc_eptri.py#L180

11:50 <tpb> Title: valentyusb/cdc_eptri.py at hw_cdc_eptri · gregdavill/valentyusb · GitHub (at github.com)

11:50 <st-gourichon-fid> class CDCUsbPHY(Module, AutoDoc, ModuleDoc):

11:51 <zyp> yeah, I found it

11:52 <zyp> I have an idea of what the problem might be

11:53 <st-gourichon-fid> I'm interested.

11:57 <zyp> well, ref. https://github.com/enjoy-digital/litex/blob/master/litex/soc/integration/doc.py#L27

11:57 <tpb> Title: litex/doc.py at master · enjoy-digital/litex · GitHub (at github.com)

11:58 <zyp> that claims there's no need to call __init__(), but __init__() is what calls DUID.__init__() which is what sets self.duid

11:58 <zyp> so I don't really understand how it's supposed to work without calling __init__

12:00 <zyp> try adding ModuleDoc.__init__(self) to CDCUsbPHY

12:02 <st-gourichon-fid> doing that

12:03 <zyp> I guess it got overlooked because __init__() doesn't do anything else useful when called without arguments

12:05 <st-gourichon-fid> Done. No more exception.

12:05 <st-gourichon-fid> Considering PR to https://github.com/gregdavill/valentyusb/blob/hw_cdc_eptri/valentyusb/usbcore/cpu/cdc_eptri.py#L180

12:05 <tpb> Title: valentyusb/cdc_eptri.py at hw_cdc_eptri · gregdavill/valentyusb · GitHub (at github.com)

12:06 <zyp> yeah, and probably a PR to litex as well to remove the line about __init__ not being required :)

12:06 <zyp> unless there is a better way to solve it

12:06 <st-gourichon-fid> Can do that. Will include your hints in the PR.

12:12 <st-gourichon-fid> zyp, where is that mentioned in litex that __init__ is not required?

12:12 <st-gourichon-fid> I grepped and did not find.

12:13 <zyp> I linked it

12:13 <zyp> 13:57:37 < zyp> well, ref. https://github.com/enjoy-digital/litex/blob/master/litex/soc/integration/doc.py#L27

12:13 <tpb> Title: litex/doc.py at master · enjoy-digital/litex · GitHub (at github.com)

12:14 <st-gourichon-fid> Ah thanks. I grepped excluding *.py ...

12:22 <st-gourichon-fid> Thanks zyp, things were not clear to me before, re-reading your lines above things are clear now. Doing PRs.

12:29 <st-gourichon-fid> Done https://github.com/gregdavill/valentyusb/pull/1

12:29 <tpb> Title: Fix incompatibility with ModuleDoc(). by fidergo-stephane-gourichon · Pull Request #1 · gregdavill/valentyusb · GitHub (at github.com)

12:29 <st-gourichon-fid> and https://github.com/enjoy-digital/litex/pull/668

12:29 <tpb> Title: Change misleading comment about ModuleDoc. by fidergo-stephane-gourichon · Pull Request #668 · enjoy-digital/litex · GitHub (at github.com)

22:44 <futarisIRCcloud> https://github.com/secworks/poly1305

22:44 <tpb> Title: GitHub - secworks/poly1305: Hardware implementation of the poly1305 message authentication function. (at github.com)