09:06 <guardian> morning

09:11 <guardian> ddfreyne: do you know how I could alter http://pastebin.com/kypU63NS so that it ALSO populate @site.@code_snippets so that outdateness checker notices when those additional snippets change?

09:51 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures a4f6279 Denis Defreyne: The build is still failing.

09:52 <ddfreyne> guardian: Where does that code live?

10:02 <guardian> that's again the same situation I described in this comment: https://github.com/nanoc/nanoc/pull/414#issuecomment-39829349

10:02 <guardian> except now there's product/lib/_factory.lib that contains the code: http://pastebin.com/kypU63NS

10:02 <guardian> this allows me to have the product nanoc site load the helpers from the "nanoc factory" and eventually have its own helpers

10:04 <ddfreyne> guardian: Where is that code called? (The code that creates and loads the code snippets)

10:04 <guardian> I cd product/

10:05 <guardian> product/lib/_factory.rb == http://pastebin.com/kypU63NS

10:05 <guardian> so when I'm inside product/, nanoc compile loads product/lib/_factory.rb which loads more snippets

10:06 <guardian> but @site.@code_snippets only contains product/lib/_factory.rb and isn't aware of all the helpers coming from _factory/lib/**/*.rb

10:07 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures c855872 Denis Defreyne: The build is still failing.

10:07 <ddfreyne> guardian: You should call the code that creates code snippets in the preprocess block

10:10 <guardian> I tried that but it doesn't work

10:10 <guardian> and even if I call that excerpt from preprocessor: http://pastebin.com/kypU63NS

10:10 <guardian> how does that solve "new helpers must be appended to @site.@code_snippets"? because once in preprocessor I can alter @site.@code_snippets?

10:11 <ddfreyne> It's @site.code_snippets, not @site.@code_snippets (the latter is invalid Ruby syntax)

10:12 <ddfreyne> guardian: In the preprocess block you can modify that, kyes

10:13 <guardian> ah ok :)

10:13 <guardian> I'll try that again

10:13 <guardian> thanks for taking the time to understand where I am :)

10:14 <guardian> damn I'm at the same time tyding SVG coming out of inkscape with Nokogiri... removing all cruft is not so easy

10:15 <guardian> that's nice my GF drives while I'm working over my 4G link. the future is now

10:15 <guardian> listening to soundcloud :)

10:15 <ddfreyne> Haha :)

10:16 <guardian> https://soundcloud.com/carpenter_brut

10:22 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures cc1824f Denis Defreyne: The build is still failing.

10:23 <ddfreyne> Nice

10:36 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures 6ed5ab6 Denis Defreyne: The build is still failing.

11:46 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures 49d33fa Denis Defreyne: The build is still failing.

12:03 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures 532565a Denis Defreyne: The build is still failing.

12:10 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures 2511262 Denis Defreyne: The build is still failing.

12:23 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures 007c00f Denis Defreyne: The build is still failing.

12:36 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures b9dfaac Denis Defreyne: The build is still failing.

12:47 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures afb20fd Denis Defreyne: The build is still failing.

13:01 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures 6eb0da2 Denis Defreyne: The build was fixed.

13:28 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures 48282da Denis Defreyne: The build passed.

13:35 <ddfreyne> Review requested:

13:35 <ddfreyne> https://github.com/nanoc/nanoc/pull/422

13:40 <ddfreyne> Relatedly, I'd love to get more people aboard nanoc development. Would be great to have a bunch of people that are willing to do code reviews.

13:40 <ddfreyne> If interested, talk to me!

16:14 <guardian> ddfreyne: interested, but not sure I can always provide useful feedback

16:14 <travis-ci> [travis-ci] nanoc/nanoc/bug/fix-jruby-failures f885fe7 Denis Defreyne: The build passed.

16:15 <guardian> ddfreyne: Now you have to update that warning message would Nokogiri issues be fixed. Why not reference #422 in the warning msg?

16:16 <ddfreyne> guardian: It's OK not to be able to always provide feedback. It's mostly just so PRs get more exposure before beign merged and bobthecow does not have sole responsibility for reviewing :)

16:16 <ddfreyne> guardian: I could mention #422 in the warning message I guess.

16:17 <guardian> ddfreyne: so loading the _factory/lib/**/*.rb code snippets from _factory/Rules 's preprocess block works but _factory/Rules uses some helpers in the compile/route definitions (like an images_dir helper that looks up inside @config)

16:17 <guardian> maybe I should get rid of this images_dir helper and replace it by straight @config[:images_dir]

16:18 <ddfreyne> Hmm, that is annoying…

16:20 <guardian> well... that's annoying but a clean solution involves exposing a helper search path to nanoc.yaml

16:25 <ddfreyne> Or let the Rules file determine where to load code snippets from

16:25 <ddfreyne> (So you'd have some sort of #require-like functionality in there)

16:27 <guardian> in fact, adding snippets to @site.code_snippets from _factory/Rules' preprocess block doesn't work in the end

16:27 <guardian> after the site has compiled successfully, I get: http://pastebin.com/jztgsidA

16:27 <ddfreyne> guardian: How are you adding the code snippets?

16:28 <ddfreyne> (How are you adding it to @site.code_snippets I mean)

16:28 <guardian> http://pastebin.com/96vrmXBu

16:29 <ddfreyne> guardian: Yeah, that's worng and exactly what I suspected :)

16:29 <ddfreyne> #<< adds a single element; the single element in this case being the entire array

16:29 <guardian> ah crap

16:29 <guardian> so, do you still want me onboard? :))))

16:29 <ddfreyne> You need #concat

16:29 <guardian> well at least I think I'm a behaving student :)

16:30 <ddfreyne> Heh

16:31 <ddfreyne> Alright, off to dinner

16:31 <ddfreyne> seeya!

16:31 <guardian> o/

16:31 <guardian> thx for the help

16:32 <guardian> when you have more time I'm interested in discussing about a solution to have the Rules file tell from which code_snippets should be loaded. When you say "(So you'd have some sort of #require-like functionality in there)" are you thinking of augmenting the DSL?

16:33 <guardian> in the meantine, I have product/lib/_factory.rb that loads _factory/**/*.rb, "that loads" == "code_snippets.each { |cs| cs.load }"

16:34 <guardian> and I ALSO have _factory/Rules that looks up _factory/**/*.rb files but this time doesn't call cs.load but just concat @site.code_snippets

16:34 <guardian> that's icky but that unblock my current situation

22:17 <ddfreyne> guardian: This may require some backwards-incompatible reworking I think… would definitely be useful to think about this in nanoc 4.