ifreund changed the topic of #river to: river - a dynamic tiling wayland compositor - https://github.com/ifreund/river - channel logs: https://freenode.irclog.whitequark.org/river/
travankor has joined #river
travankor has quit [Remote host closed the connection]
travankor has joined #river
leon-p has quit [Quit: leaving]
travankor has quit [Ping timeout: 240 seconds]
travankor has joined #river
_whitelogger has joined #river
travankor has quit [Ping timeout: 240 seconds]
travankor has joined #river
travankor has quit [Remote host closed the connection]
travankor has joined #river
travankor has quit [Ping timeout: 240 seconds]
waleee-cl has quit [Quit: Connection closed for inactivity]
leon-p has joined #river
travankor has joined #river
<leon-p> just removed the main view concept and the layout name from river-layout
<leon-p> But if we want clients to monitor their configuration values through river-config, there needs to be a way for them to request a layout demand
travankor has quit [Remote host closed the connection]
travankor has joined #river
travankor has quit [Ping timeout: 240 seconds]
<ifreund> leon-p: indeed, do you think that's a better fit for a new request in river-layout or for a river-control request?
<ifreund> leon-p: I think a river-layout request on the zriver_layout_v1 object would be fine
jamijamo777 has joined #river
FollieHiyuki has joined #river
<leon-p> I'd prefer this to be in river-control tbh.
FollieHiyuki has quit [Client Quit]
<leon-p> but I think acting on a river-layout-v1 object makes more sense, so that the server can easily check if a new layout is actually needed
jamijamo777 has quit [Read error: Connection reset by peer]
<ifreund> leon-p: the way I see it, we will probably need to arrange views after most river-control actions already, and unconditionally on the commit request if queuing actions
<ifreund> a separate request that does nothing but ask for an output to be re-arranged would be kinda weird I feel
<ifreund> oh shit, this looks worth examining: https://gitlab.com/kirbykevinson/libinput-config
<ifreund> rather hacky though :D
<leon-p> yeah, I just added a request for that in the protocol, but then realized that its not a good approach: even with rivertile we already have four layouts per output. If now the main-amount or something changes, each of them will issue a layout.markDirty(), which causes river to check for each if they are the currently active layout.
<leon-p> Lot's of wasted cycles. Not a fan
<leon-p> however, re-arranging the views on every river-config operation is also not ideal IMO, since I was kinda planning on ab^H^Husing it for non-layout related values
<leon-p> Needs more thought
waleee-cl has joined #river
<leon-p> actually, why don't we make full use of the command-queuing and put the burden of checking whether the output needs to be re-arranged on the client changing the setting?
<leon-p> So queue up a change to some value and then a layout.
<ifreund> I'm not sure I trust clients enough for that
<ifreund> they'll either be lazy and cause unecessary transactions or forget to trigger one when one is needed
<ifreund> I need to spend some time to think on this, I'm going to try and finish up the river-options PR real quick first though
ifreund has quit [Ping timeout: 256 seconds]
ifreund has joined #river
<ifreund> alright, river-options works with the example client I just wrote
<ifreund> I think I'll probably just merge it like this, implementation in riverctl and migration of options can come later
ifreund1 has joined #river
ifreund has quit [Ping timeout: 256 seconds]
ifreund1 is now known as ifreund
<leon-p> cool, I'll rebase and port river-layout