faustinoaq changed the topic of #amber to: Welcome to Amber Framework community! | https://amberframework.org | Developer happiness, productivity and bare metal performance | GH: https://github.com/amberframework | Docs: https://docs.amberframework.org | Gitter: https://gitter.im/amberframework/amber | IRC Logger: https://irclog.whitequark.org/amber | Amber::Server.start
<FromGitter> <faustinoaq> Wow, the most stared framework by far is Vue.js 100+K stars 🙌
<FromGitter> <faustinoaq> We're also in this list at position 112 😄 ✨
wontruefree has joined #amber
slacko_16178 has joined #amber
<slacko_16178> hello
slacko_16178 has quit [Client Quit]
snsei has joined #amber
snsei has quit [Ping timeout: 276 seconds]
snsei has joined #amber
snsei has quit [Ping timeout: 245 seconds]
_whitelogger has joined #amber
wontruefree has quit [Quit: bye]
marenz has joined #amber
snsei has joined #amber
snsei has quit [Ping timeout: 276 seconds]
_whitelogger has joined #amber
snsei has joined #amber
snsei has quit [Ping timeout: 245 seconds]
_whitelogger has joined #amber
feepbot has quit [Ping timeout: 256 seconds]
feepbot has joined #amber
<FromGitter> <Thellior> I update docker and sometimes see this error ⏎ ⏎ ```code paste, see link``` [https://gitter.im/amberframework/amber?at=5b2e2b4f479ca2668978f6df]
<FromGitter> <Thellior> Is this an issue with my changes
snsei has joined #amber
snsei has quit [Ping timeout: 260 seconds]
<FromGitter> <faustinoaq> @Thellior That spec looks strange 😅
<FromGitter> <eliasjpr> @faustinoaq we should be in this category https://github.com/topics/web-framework?o=desc&s=stars
snsei has joined #amber
<FromGitter> <robacarp> @Thellior I think that’s probably a known issue. Crystal 25 time changes trickled down into the database adapters and now they round time, so we need to add .at_beginning_of_second a bunch of places
snsei has quit [Ping timeout: 240 seconds]
<FromGitter> <Thellior> Ok than i Dont have to worry about it in my pull requests
<faustinoaq> @eliasjpr Done! https://i.imgur.com/5LZ0MCM.png
marenz has quit [Ping timeout: 245 seconds]
<FromGitter> <Thellior> Me and @robacarp started a discussion about static code analyser. There are different opinions regarding these and i would like to have other opinions as well . If you want to leave you comment than you can https://github.com/amberframework/granite/pull/240
wontruefree has joined #amber
wontruefree has quit [Max SendQ exceeded]
wontruefree has joined #amber
<FromGitter> <vlazar> I'm in the process of updating TFB to newer Crystal and Crystal frameworks versions. ⏎ ⏎ Can't find what's changed from granite 0.8.4 to 0.12.0 that TFB amber test fails with `column world.randomNumber does not exist (PQ::PQError)` https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/395841205 ⏎ ⏎ PR https://github.com/TechEmpower/FrameworkBenchmarks/pull/3884 [htt
<FromGitter> ... ps://gitter.im/amberframework/amber?at=5b2e7cb372b31d3691ed8539]
<FromGitter> <eliasjpr> Thanks @vlazar. @robacarp might be more familiar than me with this
faustinoaq has quit [Ping timeout: 245 seconds]
<FromGitter> <eliasjpr> It seems that the other tests passed fine
<FromGitter> <vlazar> there is one issue with Kemal too, opened an issue on Kemal already https://github.com/kemalcr/kemal/issues/459
<FromGitter> <Blacksmoke16> did you check the simple stuff, like is that column actually exist in the PG db?
<FromGitter> <Blacksmoke16> misspelled or snake case or something
<FromGitter> <vlazar> the TFB setup didn't worked for me locally, so I just went ahead and make necessary changes for Crystal 0.25.0 and latest amber and dependencies, now TFB CI fails
<FromGitter> <vlazar> PG db is not changed in any way, that's not part of test code
snsei has joined #amber
<FromGitter> <vlazar> tests in other frameworks work with the same DB structure, nothing changed there
<FromGitter> <Blacksmoke16> huh
snsei has quit [Ping timeout: 260 seconds]
<FromGitter> <vlazar> OK, debugged the issue
<FromGitter> <vlazar> the SQL query is not build with quotes like `SELECT "world"."id", "world"."randomNumber" FROM "world" WHERE id = 5175 LIMIT 1`
<FromGitter> <vlazar> and this doesn't work with TFD DB
<FromGitter> <vlazar> I guess before column names weren't quoted
<FromGitter> <vlazar> this works
<FromGitter> <vlazar> notice `randomNumber` is without quotes now
wontruefree has quit [Quit: bye]
<FromGitter> <vlazar> this also works
<FromGitter> <vlazar> `"randomnumber"` is lowercase
snsei has joined #amber
faustinoaq has joined #amber
snsei has quit [Ping timeout: 276 seconds]
<FromGitter> <Blacksmoke16> glad you figured it out
<FromGitter> <robacarp> My friends ex girlfriends dog just liked my photo on Instagram. This world is weird and uncomfortable.
<FromGitter> <eliasjpr> lol
<FromGitter> <eliasjpr> @vlazar we would have to patch Granite I guess?