faustinoaq changed the topic of #amber to: Welcome to Amber Framework community! | https://amberframework.org | Developer happiness, productivity and bare metal performance | GH: https://github.com/amberframework | Docs: https://docs.amberframework.org | Gitter: https://gitter.im/amberframework/amber | IRC Logger: https://irclog.whitequark.org/amber | Amber::Server.start
<FromGitter> <Blacksmoke16> noice
<FromGitter> <Blacksmoke16> @hfjallemark Idea i had for this on drive home, was something similar to how https://github.com/amberframework/granite/blob/master/src/adapter/base.cr#L65 works
<FromGitter> <hfjallemark> Ah, neat!
<FromGitter> <Blacksmoke16> er crap, for PG its not that simple since it has to be numbered characters
<FromGitter> <Blacksmoke16> hm
<FromGitter> <Blacksmoke16> so really each adapter needs to be able to define a custom placeholder value and method of implementing that
<FromGitter> <Blacksmoke16> or at least only the ones that have a diff way of doing it
<FromGitter> <Blacksmoke16> so question is how to do that nicely...
<FromGitter> <Blacksmoke16> i think you're onto something
<FromGitter> <hfjallemark> Just realised I forgot to make `_ensure_clause_template` public in the pg adapter, fixed and pushed now.. works in my app now, but haven't been able to run the specs since I don't have mysql etc.
<FromGitter> <Blacksmoke16> you use docker?
<FromGitter> <Blacksmoke16> but yea, im happy with your solution. Defines a default placeholder of `?`, able to be overridden on adapters that dont use it
<FromGitter> <Blacksmoke16> we got CI anyway so shouldnt have to worry about it
<FromGitter> <Blacksmoke16> all green
<FromGitter> <hfjallemark> Great!
<FromGitter> <Blacksmoke16> can you write a spec for the initial issue?
<FromGitter> <Blacksmoke16> so in future and can be assured that's working correctly
wontruefree has joined #amber
<FromGitter> <hfjallemark> Yes, have regular work now but will try to get to it tonight
<FromGitter> <Blacksmoke16> no worries
<FromGitter> <Blacksmoke16> also could prob specify return type of the `ensure_cause_template` as `String`
wontruefree has quit [Quit: bye]
<FromGitter> <Blacksmoke16> hm, wonder if we can come up with a better name for that function that better describes what it's doing.
<FromGitter> <damianham> @alex-lairan @bparanj I switched from capistrano to mina https://github.com/mina-deploy/mina for Rails apps a long time ago - with mina you setup your deploy routine to run shell commands on the target server. If you want to copy a compiled binary to the target then in the cookbook in the docs there is an example of copying a file to the target using scp. There is also an FTP plugin to deploy a directory
<FromGitter> ... hierarchy. If your development terminal and the target are the exact same OS and release and same shared libs you are good to go. If not use docker on your dev terminal to create a docker container that is the exact same as your target with same shared libs and compile your Amber app in the docker container and then run m ... [https://gitter.im/amberframework/amber?at=5bd8098b1e23486b933d899f]
<FromGitter> <hfjallemark> Yeah @Blacksmoke16 I think maybe a better name would be good, not that I can think of any :)
wontruefree has joined #amber
wontruefree has quit [Quit: bye]
wontruefree has joined #amber
<FromGitter> <Blacksmoke16> :shrug:
<FromGitter> <Blacksmoke16> have to think on it
wontruefree has quit [Quit: bye]
<FromGitter> <Blacksmoke16> oo this not nil refactor is looking nice
<FromGitter> <Blacksmoke16> will bet compile time errors now
<FromGitter> <Blacksmoke16> ```code paste, see link``` [https://gitter.im/amberframework/amber?at=5bd889f0ae7be94016de44fc]
<FromGitter> <Blacksmoke16> i kept the bang getter, that will raise if its nil
<FromGitter> <Blacksmoke16> currently it throws `Unhandled exception: Nil assertion failed (Exception)`
<FromGitter> <Blacksmoke16> however in next crystal version it would be more like
<FromGitter> <Blacksmoke16> `Unhandled exception: Nil assertion failed at /path/to/file/test.cr:6 (Exception)`
<FromGitter> <Blacksmoke16> er i might bring back other raise, this isnt as detailed as i remembered
<FromGitter> <Blacksmoke16> `Unhandled exception: Foo#name cannot be nil at /home/george/dev/git/crystal/test.cr:6 (Exception)` much better