dominikh changed the topic of #cinch to: The IRC Framework | Latest version: Cinch 2.3.1 | You're being logged at https://irclog.whitequark.org/cinch/
_whitelogger has joined #cinch
cjfn has joined #cinch
<cjfn>
any cinch project devs around?
<cjfn>
I'd like to try implementing support for the list command (code 322 RPL_LIST) so I forked the project but I'm not sure how to set up the dev env
<cjfn>
I saw similar methods for handling other irc codes so I have an idea of where to make the changes but not sure how I can test them locally
<cjfn>
also noticed when I forked the project and ran rake, a few plugin.rb tests fail
<dominikh>
LIST is not implemented on purpose. using LIST is a very bad idea on large networks
<dominikh>
(also tests either don't exist or a broken)
<dominikh>
*are
<dominikh>
and bougyman here has been terribly slacking on fixing things :)
<cjfn>
is it a bad idea because it takes a long time?
<cjfn>
In my own project where I use cinch I tried @bot.irc.send('list') and it took a few mins to complete
<cjfn>
on freenode
<dominikh>
and because if your connection is too slow, the server will kick you.
<cjfn>
is there some kind of rate limiting we can do?
<dominikh>
freenode, and most networks, have custom commands that aren't LIST that allow filtering/searching
<cjfn>
outside of the rfc?
<dominikh>
yes.
<dominikh>
I don't remember if they're commands, or just messages to one of their bots
<dominikh>
probably the latter
<cjfn>
gotcha
<dominikh>
as for testing Cinch: it's a manual process. have a bot connect to an IRC network, see if stuff works.
<cjfn>
lol dang ok I was hoping there was another way
<cjfn>
git blame says the failing tests were last touched by you btw ;)
<dominikh>
I don't doubt it. I also started working on Cinch 8 years ago; I wasn't particularly into testing, or testable code, at the time…
<cjfn>
lol no worries
<cjfn>
Cinch is by far the best bot framework I've seen
<cjfn>
so I appreciate your work regardless :)
<dominikh>
which is both great and deeply worrying ;)