<Davy_CC>
Rust use Windows' SEH with MSVC toolchain, and C++ABI EH with gnu toolchain.
A124 has joined #crystal-lang
<Davy_CC>
Maybe I'll implement Windows SEH first than try C++ABI (I metioned that LLVM provided this in 3.8, but the last release on LLVM release page is 3.7.1
<crystal-gh>
[crystal] jhass pushed 3 new commits to master: https://git.io/vgX2m
<crystal-gh>
crystal/master 95daae5 Konstantin Makarchev: Add HTTP::Client dns_timeout
<crystal-gh>
crystal/master b8aeef4 Jonne Haß: Merge pull request #2102 from kostya/dns_timeout...
<crystal-gh>
crystal/master a372b27 Jonne Haß: Touch up HTTP::Client#dns_timeout= docs
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
jonathan_ has joined #crystal-lang
<jonathan_>
Hi
jonathan_ has quit [Quit: Page closed]
jonathan_ has joined #crystal-lang
<jonathan_>
Hi everyone. I'm new here :)
<asterite>
Hi jonathan_, welcome :-)
<jonathan_>
asterite: Thanks :) maybe you could help me. I'm with a team of 6 persons, and we have to contribute to an open source project for a school assignment. We would like to contribute to crystal, can we just begin and send pull requests on the github repository ?
<asterite>
Of course! Do you know in which way you'll contribute?
<jonathan_>
asterite: Well, our teacher asked us to make a lot of small improvements, he values the quantity of modifications over the size of one modification.
<jonathan_>
asterite: so we thought we could add some documentation to the classes, or add some missing functions in the standard library
<jonathan_>
asterite: if you have anything more to suggest, be free to say so :)
<BlaXpirit>
jonathan_, documentation sure would be great
<asterite>
Documentation would be really helpful. Missing functions to the standard library will probably have some discussions around them :)
<jonathan_>
asterite: what do you mean by discussions ?
<jonathan_>
BlaXpirit: the motivation of our grades will help us to prodives lots of documentation =)
<asterite>
Well, documentation too
<asterite>
I mean, we will review and comment, add suggestions, request changes, etc. Or maybe those functions are not needed, or we don't want them for some reason, etc. Or maybe yes and we'll accept them
<asterite>
Well, like any pull request
<jonathan_>
asterite: oh all right, I have already contributed to some other project earlier, so you work similarly, that's cool :)
<jonathan_>
asterite: Expect a lot of pull requests soon, just need to setup myself first ^^
<crystal-gh>
[crystal] HeleneMyr opened pull request #2144: Add documentation for BitArray (master...bitArray) https://git.io/vgX7z
<Davy_CC>
I created a module `DL` wrapper and make it has dlsym, dlopen, dladdr on Unix system (create inline function calling LibDL's function) and dlsym, dlopen on Windows, like this code: https://gist.github.com/david50407/451b778db43e217b07fb
<Davy_CC>
is this matching Crystal's style?
<Davy_CC>
because dlopen, dlsym have alternative calls in Windows, but they are in kernel32.dll. If I put them into LibDL, that would be strange (they are not in the library `dl`).
<Davy_CC>
But they are doing the same thing so I think create a high-level layer DL and mapping into libdl/kernel32 is good.
<Davy_CC>
but there is a problem with this situation that there consts and structs in LibDL and WinAPI, should I alias them into `DL` or just let users use `LibDL::` and `WinApi::` to reach them
<crystal-gh>
[crystal] jhass pushed 2 new commits to master: https://git.io/vgXFh
<crystal-gh>
crystal/master b61391c meyer: Add documentation for BitArray
<crystal-gh>
crystal/master b69fdc0 Jonne Haß: Merge pull request #2144 from HeleneMyr/bitArray...
<Davy_CC>
Or maybe this way is not matched Crystal' style, not creating the layer and every1 have to use LibDL on Unix and WinApi on Windows is better?
fowlduck has quit [Remote host closed the connection]
ylluminate has joined #crystal-lang
<ylluminate>
so i was just playing with kemal last night and now it seems to be gone altogether
<ylluminate>
the entire project is gone from github and the website is also down: http://kemalcr.com
<crystal-gh>
[crystal] Ryuuzakis opened pull request #2145: Fixed typo in string.cr description (master...StringTypoFixing) https://git.io/vgXAI
<ylluminate>
any idea as to what's going on here?
<ylluminate>
looks like the `sdogruyol` account is completely gone
<Noha>
Hey guys! I have a question: Where is the most help needed right now for someone who wants to get into the project?
<Davy_CC>
Rust-lang created it's own dl wrapper to providing cross-platform dynamic library loading and only keep the same part between unix and windows (it doesn't provide open mode/flag option)
<Noha>
@asterite: So just everywhere :p Great haha. I am just working my way through the markdown parser to add the missing features from the basic markdown spec.
<asterite>
Oh, cool, that would be neat, as that's what we are using in the API docs
Renich has joined #crystal-lang
<crystal-gh>
[crystal] jhass pushed 2 new commits to master: https://git.io/vg1tL
<crystal-gh>
crystal/master 2f495a6 Jonathan Lecointe: Fixed typo in string.cr
<crystal-gh>
crystal/master 09d8ae5 Jonne Haß: Merge pull request #2145 from Ryuuzakis/StringTypoFixing...
<crystal-gh>
[crystal] Nesqwik opened pull request #2146: Adding documentation for BigInt.to_s methods (master...doc_bigint) https://git.io/vg1mW
<crystal-gh>
[crystal] werner opened pull request #2147: Add man page to crystal (master...feature/man-page) https://git.io/vg1mD
tomchapin has joined #crystal-lang
<crystal-gh>
[crystal] MatthieuBlm opened pull request #2148: Add comments in file.cr (master...file1) https://git.io/vg1nO
<crystal-gh>
crystal/master ca2f328 Ary Borenszweig: Docs: automatically link `Foo.bar` (with a dot, in addition to a sharp). Also, dot favors class methods, sharp favors instance methods.
<crystal-gh>
crystal/master a8ff85a Ary Borenszweig: Docs: linking to constants and enum members didn't work
<crystal-gh>
[crystal] jhass pushed 2 new commits to master: https://git.io/vg1WQ