jhass changed the topic of #crystal-lang to: The Crystal programming language | http://crystal-lang.org | Crystal 0.12.0 | Fund Crystals development: http://is.gd/X7PRtI | Paste > 3 lines of text to https://gist.github.com | GH: https://github.com/crystal-lang/crystal | Docs: http://crystal-lang.org/docs/ | API: http://crystal-lang.org/api/ | Logs: http://irclog.whitequark.org/crystal-lang
<BlaXpirit> pls no
<BlaXpirit> well actually it's not so bad, but you'd still have to deal with `AllParamTypes`
<fka> @BlaXpirit yep. we already know AllParamTypes is not nice. We need to figure out to remove it. I'm talkin in the name of sdogruyol, actually I don't know what he actually think but he generally cares about the critics about kemal.
<BlaXpirit> fka, you can't get rid of AllParamTypes. just make a way to get request query args as String
<BlaXpirit> (and there is such a way but very long line of code)
<fka> the problem is, we push all the data to @params which is String => AllParamTypes
<BlaXpirit> uh yes
<fka> you're right with your point
<fka> parse_part(@request.query)
<fka> this code parses query string and pushes to the params which is AllParamTypes
<fka> but it's actually string.
<fka> (the query string)
<crystal-gh> [crystal] javajax opened pull request #2273: resolves segfaults on older kernel versions (master...build_min_version) https://git.io/v2N5l
<fka> maybe we can generate a @query = {} of String => String
<fka> and push to that hash instead of params
<fka> AllParamTypes is definitely a solve for json body.
<umurgdk> fka: yeah that solves :)
<fka> this part needs AllParamTypes actually
<BlaXpirit> fka, I don't see any reason to have GET query args and json body in the same place, that's the thing. it doesn't even give any convenience
Gasher^ has quit [Quit: Leaving]
<BlaXpirit> even in dynamic languages, where this works well nobody does such a thing
<fka> you mean, should we leave all the json.body as is (string)?
<BlaXpirit> well no
<BlaXpirit> make 3 hashes. @query or @get, @forms or @post, @json
<BlaXpirit> make access methods for each of these
<fka> aha got it.
<fka> makes sense to me.
<BlaXpirit> keep params as is and deprecate it. you can either keep it a separate hash or a proxy over all of these
<fka> makes sense :)
<umurgdk> is there any way to have method reference?
<BlaXpirit> fka, maybe you can get better performance like this: def query_args; @query ||= parse_part(...
<BlaXpirit> umurgdk, if you're trying to implement your previous idea... well, it's impossible
<BlaXpirit> but maybe you can find something interesting in kemal's code
<umurgdk> could be but why do you say its impossible?
<BlaXpirit> i just think it's impossible to have the argument passed to the block be simply Int32
<BlaXpirit> it has to be a union
<fka> @BlaXpirit i try to make it now. I'll show it to sdogruyol what he thinks.
<BlaXpirit> fka, OK. thanks for listening and sorry for rudeness
<fka> no problem :)
sp4rrow has quit [Quit: The Internet needs a break and I need a cookie]
shama has quit [Remote host closed the connection]
sp4rrow has joined #crystal-lang
<sp4rrow> it seems like more of ENUM in the standard lib has a conditional for the attribute "Flag"
<sp4rrow> would it make sense to break this out into 2 Enum structs
<sp4rrow> FEnum and Enum
<sp4rrow> or something similar
sp4rrow has quit [Client Quit]
sp4rrow has joined #crystal-lang
sp4rrow has joined #crystal-lang
mondok has joined #crystal-lang
shama has joined #crystal-lang
shama has quit [Client Quit]
mondok has quit [Ping timeout: 248 seconds]
Dreamer3 has quit [Ping timeout: 244 seconds]
fka has quit [Remote host closed the connection]
Dreamer3 has joined #crystal-lang
dome22xl has joined #crystal-lang
sardaukar has joined #crystal-lang
Dreamer__ has joined #crystal-lang
Dreamer3 has quit [Ping timeout: 264 seconds]
trapped has quit [Read error: Connection reset by peer]
sardaukar has quit [Quit: sardaukar]
ragmaanir_ has joined #crystal-lang
ragmaanir has quit [Ping timeout: 264 seconds]
ragmaanir_ has quit [Quit: Leaving]
ragmaanir has joined #crystal-lang
fka has joined #crystal-lang
fka has quit [Ping timeout: 248 seconds]
buggs has quit [Quit: WeeChat 0.4.2]
krtv` has joined #crystal-lang
bcardiff has joined #crystal-lang
bcardiff has quit [Quit: bcardiff]
bcardiff has joined #crystal-lang
bcardiff has quit [Client Quit]
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
sp4rrow has quit [Quit: The Internet needs a break and I need a cookie]
zeno_ has joined #crystal-lang
sp4rrow has joined #crystal-lang
ragmaanir has quit [Quit: Leaving]
fka_ has joined #crystal-lang
umurgdk has quit [Remote host closed the connection]
fka_ has quit [Ping timeout: 240 seconds]
umurgdk has joined #crystal-lang
umurgdk has quit [Ping timeout: 260 seconds]
<travis-ci> MaloJaffre/crystal#9a0ef62 (master - Merge pull request #2124 from ysbaddaden/musl-libc): The build passed. https://travis-ci.org/MaloJaffre/crystal/builds/114014060
<crystal-gh> [crystal] MaloJaffre opened pull request #2276: Add Char methods and specs, include Comparable. (master...char_classes) https://git.io/v2AsL
fka_ has joined #crystal-lang
fka_ has quit [Ping timeout: 276 seconds]
fka_ has joined #crystal-lang
umurgdk has joined #crystal-lang
umurgdk has quit [Ping timeout: 268 seconds]
mondok has joined #crystal-lang
zeno_ has quit [Quit: Page closed]
Gasher has joined #crystal-lang
trapped has joined #crystal-lang
fka_ has quit [Remote host closed the connection]
fka_ has joined #crystal-lang
rok has joined #crystal-lang
umurgdk has joined #crystal-lang
umurgdk has quit [Ping timeout: 276 seconds]
mondok has quit [Ping timeout: 244 seconds]
<fka_> @jhass
<fka_> i decoupled it. fingers crossed wish sdogruyol will merge :)
Gasher has quit [Quit: Leaving]
<BlaXpirit> good job
sp4rrow has quit [Quit: The Internet needs a break and I need a cookie]
fka_ has quit [Remote host closed the connection]
rok has quit [Quit: rok]
sp4rrow has joined #crystal-lang
Philpax has quit [Ping timeout: 252 seconds]
pawnbox has quit [Remote host closed the connection]
umurgdk has joined #crystal-lang
umurgdk has quit [Ping timeout: 246 seconds]
Gasher has joined #crystal-lang
pawnbox has joined #crystal-lang
pawnbox has quit [Ping timeout: 260 seconds]
knoopx has joined #crystal-lang
knoopx has quit [Remote host closed the connection]
bcardiff has joined #crystal-lang
bcardiff has quit [Client Quit]
dome22xl has quit [Ping timeout: 276 seconds]
Gasher has quit [Quit: Leaving]
umurgdk has joined #crystal-lang
umurgdk has quit [Ping timeout: 276 seconds]
Ven has joined #crystal-lang
shadeslayer has joined #crystal-lang
Ven has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
pawnbox has joined #crystal-lang
pawnbox has quit [Ping timeout: 248 seconds]
sp4rrow has quit [Quit: The Internet needs a break and I need a cookie]
havenwood has quit [Remote host closed the connection]
havenwood has joined #crystal-lang
pawnbox has joined #crystal-lang
A124 has quit [Quit: '']
A124 has joined #crystal-lang
umurgdk has joined #crystal-lang
umurgdk has quit [Ping timeout: 252 seconds]
Gasher has joined #crystal-lang
Kilo`byte has quit [Ping timeout: 246 seconds]
mondok has joined #crystal-lang
Kilo`byte has joined #crystal-lang
A124 has quit [Quit: '']
umurgdk has joined #crystal-lang
<crystal-gh> [crystal] greyblake opened pull request #2279: Fix typo in Hash#zip doc (master...fix-doc-hash-zip) https://git.io/v2Ajv
A124 has joined #crystal-lang
rao45 has joined #crystal-lang
<crystal-gh> [crystal] greyblake opened pull request #2280: Make Hash#first(n : Int) return subhash (master...hash-first-n) https://git.io/v2xeA
fka has joined #crystal-lang
Ven has joined #crystal-lang
Ven has quit [Client Quit]
<crystal-gh> [crystal] jhass closed pull request #2279: Fix typo in Hash#zip doc (master...fix-doc-hash-zip) https://git.io/v2Ajv
<travis-ci> crystal-lang/crystal#15edccc (master - Merge pull request #2279 from greyblake/fix-doc-hash-zip): The build passed. https://travis-ci.org/crystal-lang/crystal/builds/114088888
rao45 has quit [Remote host closed the connection]
rao45 has joined #crystal-lang
<fka> sdogruyol and me made a huge change due to talk about params yesterday
<fka> thank you to force us make that better :D
bjz has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
rao45 has quit [Remote host closed the connection]
fka has quit [Remote host closed the connection]
bjz has joined #crystal-lang
fka has joined #crystal-lang
bjz has quit [Client Quit]
pawnbox has quit [Remote host closed the connection]
bjz has joined #crystal-lang
pawnbox has joined #crystal-lang
pawnbox has quit [Ping timeout: 260 seconds]
bjz has quit [Ping timeout: 240 seconds]
fka has quit [Remote host closed the connection]
fka has joined #crystal-lang
fka has quit [Remote host closed the connection]
fka has joined #crystal-lang
pawnbox has joined #crystal-lang
<crystal-gh> [crystal] greyblake opened pull request #2281: Implement Array#first(n : Int) and Array#last(n : Int) (master...array-first-n) https://git.io/v2xCu
pawnbox has quit [Ping timeout: 250 seconds]
pawnbox has joined #crystal-lang
pawnbox has quit [Ping timeout: 244 seconds]
fka has quit [Remote host closed the connection]
fka has joined #crystal-lang
fka has quit [Ping timeout: 240 seconds]
Gasher has quit [Quit: Leaving]
trapped has quit [Read error: Connection reset by peer]
pawnbox has joined #crystal-lang
pawnbox has quit [Ping timeout: 252 seconds]
fka has joined #crystal-lang
bcardiff has joined #crystal-lang
fka has quit [Ping timeout: 276 seconds]
sp4rrow has joined #crystal-lang