00:00
<
BlaXpirit >
well actually it's not so bad, but you'd still have to deal with `AllParamTypes`
00:02
<
fka >
@BlaXpirit yep. we already know AllParamTypes is not nice. We need to figure out to remove it. I'm talkin in the name of sdogruyol, actually I don't know what he actually think but he generally cares about the critics about kemal.
00:03
<
BlaXpirit >
fka, you can't get rid of AllParamTypes. just make a way to get request query args as String
00:03
<
BlaXpirit >
(and there is such a way but very long line of code)
00:04
<
fka >
the problem is, we push all the data to @params which is String => AllParamTypes
00:05
<
fka >
you're right with your point
00:05
<
fka >
parse_part(@request.query)
00:05
<
fka >
this code parses query string and pushes to the params which is AllParamTypes
00:05
<
fka >
but it's actually string.
00:06
<
fka >
(the query string)
00:06
<
crystal-gh >
[crystal] javajax opened pull request #2273: resolves segfaults on older kernel versions (master...build_min_version)
https://git.io/v2N5l
00:06
<
fka >
maybe we can generate a @query = {} of String => String
00:06
<
fka >
and push to that hash instead of params
00:07
<
fka >
AllParamTypes is definitely a solve for json body.
00:07
<
umurgdk >
fka: yeah that solves :)
00:08
<
fka >
this part needs AllParamTypes actually
00:08
<
BlaXpirit >
fka, I don't see any reason to have GET query args and json body in the same place, that's the thing. it doesn't even give any convenience
00:08
Gasher^ has quit [Quit: Leaving]
00:08
<
BlaXpirit >
even in dynamic languages, where this works well nobody does such a thing
00:09
<
fka >
you mean, should we leave all the json.body as is (string)?
00:09
<
BlaXpirit >
well no
00:10
<
BlaXpirit >
make 3 hashes. @query or @get, @forms or @post, @json
00:10
<
BlaXpirit >
make access methods for each of these
00:10
<
fka >
makes sense to me.
00:10
<
BlaXpirit >
keep params as is and deprecate it. you can either keep it a separate hash or a proxy over all of these
00:13
<
fka >
makes sense :)
00:17
<
umurgdk >
is there any way to have method reference?
00:17
<
BlaXpirit >
fka, maybe you can get better performance like this: def query_args; @query ||= parse_part(...
00:18
<
BlaXpirit >
umurgdk, if you're trying to implement your previous idea... well, it's impossible
00:19
<
BlaXpirit >
but maybe you can find something interesting in kemal's code
00:21
<
umurgdk >
could be but why do you say its impossible?
00:22
<
BlaXpirit >
i just think it's impossible to have the argument passed to the block be simply Int32
00:22
<
BlaXpirit >
it has to be a union
00:24
<
fka >
@BlaXpirit i try to make it now. I'll show it to sdogruyol what he thinks.
00:24
<
BlaXpirit >
fka, OK. thanks for listening and sorry for rudeness
00:25
<
fka >
no problem :)
00:34
sp4rrow has quit [Quit: The Internet needs a break and I need a cookie]
00:36
shama has quit [Remote host closed the connection]
00:43
sp4rrow has joined #crystal-lang
00:46
<
sp4rrow >
it seems like more of ENUM in the standard lib has a conditional for the attribute "Flag"
00:47
<
sp4rrow >
would it make sense to break this out into 2 Enum structs
00:47
<
sp4rrow >
FEnum and Enum
00:47
<
sp4rrow >
or something similar
00:47
sp4rrow has quit [Client Quit]
00:48
sp4rrow has joined #crystal-lang
00:48
sp4rrow has joined #crystal-lang
00:49
mondok has joined #crystal-lang
00:49
shama has joined #crystal-lang
00:52
shama has quit [Client Quit]
01:32
mondok has quit [Ping timeout: 248 seconds]
01:43
Dreamer3 has quit [Ping timeout: 244 seconds]
01:43
fka has quit [Remote host closed the connection]
01:44
Dreamer3 has joined #crystal-lang
01:44
dome22xl has joined #crystal-lang
01:50
sardaukar has joined #crystal-lang
01:50
Dreamer__ has joined #crystal-lang
01:55
Dreamer3 has quit [Ping timeout: 264 seconds]
01:58
trapped has quit [Read error: Connection reset by peer]
01:59
sardaukar has quit [Quit: sardaukar]
02:24
ragmaanir_ has joined #crystal-lang
02:28
ragmaanir has quit [Ping timeout: 264 seconds]
02:36
ragmaanir_ has quit [Quit: Leaving]
02:36
ragmaanir has joined #crystal-lang
02:44
fka has joined #crystal-lang
02:50
fka has quit [Ping timeout: 248 seconds]
03:19
buggs has quit [Quit: WeeChat 0.4.2]
03:55
krtv` has joined #crystal-lang
04:52
bcardiff has joined #crystal-lang
05:05
bcardiff has quit [Quit: bcardiff]
05:07
bcardiff has joined #crystal-lang
05:09
bcardiff has quit [Client Quit]
05:12
pawnbox has quit [Remote host closed the connection]
05:12
pawnbox has joined #crystal-lang
05:14
sp4rrow has quit [Quit: The Internet needs a break and I need a cookie]
05:20
zeno_ has joined #crystal-lang
05:22
sp4rrow has joined #crystal-lang
06:27
ragmaanir has quit [Quit: Leaving]
06:47
fka_ has joined #crystal-lang
06:47
umurgdk has quit [Remote host closed the connection]
06:51
fka_ has quit [Ping timeout: 240 seconds]
07:39
umurgdk has joined #crystal-lang
07:45
umurgdk has quit [Ping timeout: 260 seconds]
08:39
<
crystal-gh >
[crystal] MaloJaffre opened pull request #2276: Add Char methods and specs, include Comparable. (master...char_classes)
https://git.io/v2AsL
08:48
fka_ has joined #crystal-lang
08:52
fka_ has quit [Ping timeout: 276 seconds]
09:23
fka_ has joined #crystal-lang
09:28
umurgdk has joined #crystal-lang
09:33
umurgdk has quit [Ping timeout: 268 seconds]
09:38
mondok has joined #crystal-lang
09:58
zeno_ has quit [Quit: Page closed]
10:09
Gasher has joined #crystal-lang
10:22
trapped has joined #crystal-lang
10:40
fka_ has quit [Remote host closed the connection]
10:42
fka_ has joined #crystal-lang
11:12
rok has joined #crystal-lang
11:16
umurgdk has joined #crystal-lang
11:20
umurgdk has quit [Ping timeout: 276 seconds]
11:26
mondok has quit [Ping timeout: 244 seconds]
11:29
<
fka_ >
i decoupled it. fingers crossed wish sdogruyol will merge :)
11:49
Gasher has quit [Quit: Leaving]
12:11
<
BlaXpirit >
good job
12:14
sp4rrow has quit [Quit: The Internet needs a break and I need a cookie]
12:15
fka_ has quit [Remote host closed the connection]
12:24
rok has quit [Quit: rok]
12:24
sp4rrow has joined #crystal-lang
12:29
Philpax has quit [Ping timeout: 252 seconds]
12:55
pawnbox has quit [Remote host closed the connection]
13:04
umurgdk has joined #crystal-lang
13:08
umurgdk has quit [Ping timeout: 246 seconds]
13:13
Gasher has joined #crystal-lang
13:55
pawnbox has joined #crystal-lang
14:00
pawnbox has quit [Ping timeout: 260 seconds]
14:18
knoopx has joined #crystal-lang
14:25
knoopx has quit [Remote host closed the connection]
14:31
bcardiff has joined #crystal-lang
14:32
bcardiff has quit [Client Quit]
14:43
dome22xl has quit [Ping timeout: 276 seconds]
14:47
Gasher has quit [Quit: Leaving]
14:52
umurgdk has joined #crystal-lang
14:58
umurgdk has quit [Ping timeout: 276 seconds]
15:07
Ven has joined #crystal-lang
15:15
shadeslayer has joined #crystal-lang
15:20
Ven has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:43
pawnbox has joined #crystal-lang
15:47
pawnbox has quit [Ping timeout: 248 seconds]
15:56
sp4rrow has quit [Quit: The Internet needs a break and I need a cookie]
16:13
havenwood has quit [Remote host closed the connection]
16:15
havenwood has joined #crystal-lang
16:29
pawnbox has joined #crystal-lang
16:38
A124 has quit [Quit: '']
16:38
A124 has joined #crystal-lang
16:40
umurgdk has joined #crystal-lang
16:45
umurgdk has quit [Ping timeout: 252 seconds]
16:52
Gasher has joined #crystal-lang
17:03
Kilo`byte has quit [Ping timeout: 246 seconds]
17:19
mondok has joined #crystal-lang
17:31
Kilo`byte has joined #crystal-lang
18:23
A124 has quit [Quit: '']
18:24
umurgdk has joined #crystal-lang
18:24
<
crystal-gh >
[crystal] greyblake opened pull request #2279: Fix typo in Hash#zip doc (master...fix-doc-hash-zip)
https://git.io/v2Ajv
18:25
A124 has joined #crystal-lang
18:38
rao45 has joined #crystal-lang
18:53
<
crystal-gh >
[crystal] greyblake opened pull request #2280: Make Hash#first(n : Int) return subhash (master...hash-first-n)
https://git.io/v2xeA
18:57
fka has joined #crystal-lang
19:02
Ven has joined #crystal-lang
19:03
Ven has quit [Client Quit]
19:13
<
crystal-gh >
[crystal] jhass closed pull request #2279: Fix typo in Hash#zip doc (master...fix-doc-hash-zip)
https://git.io/v2Ajv
19:23
rao45 has quit [Remote host closed the connection]
20:14
rao45 has joined #crystal-lang
21:01
<
fka >
sdogruyol and me made a huge change due to talk about params yesterday
21:02
<
fka >
thank you to force us make that better :D
21:15
bjz has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
21:23
rao45 has quit [Remote host closed the connection]
21:24
fka has quit [Remote host closed the connection]
21:29
bjz has joined #crystal-lang
21:30
fka has joined #crystal-lang
21:30
bjz has quit [Client Quit]
21:30
pawnbox has quit [Remote host closed the connection]
21:31
bjz has joined #crystal-lang
21:31
pawnbox has joined #crystal-lang
21:36
pawnbox has quit [Ping timeout: 260 seconds]
21:45
bjz has quit [Ping timeout: 240 seconds]
21:50
fka has quit [Remote host closed the connection]
21:51
fka has joined #crystal-lang
21:52
fka has quit [Remote host closed the connection]
21:52
fka has joined #crystal-lang
22:30
pawnbox has joined #crystal-lang
22:32
<
crystal-gh >
[crystal] greyblake opened pull request #2281: Implement Array#first(n : Int) and Array#last(n : Int) (master...array-first-n)
https://git.io/v2xCu
22:35
pawnbox has quit [Ping timeout: 250 seconds]
23:01
pawnbox has joined #crystal-lang
23:05
pawnbox has quit [Ping timeout: 244 seconds]
23:14
fka has quit [Remote host closed the connection]
23:16
fka has joined #crystal-lang
23:20
fka has quit [Ping timeout: 240 seconds]
23:24
Gasher has quit [Quit: Leaving]
23:24
trapped has quit [Read error: Connection reset by peer]
23:30
pawnbox has joined #crystal-lang
23:35
pawnbox has quit [Ping timeout: 252 seconds]
23:48
fka has joined #crystal-lang
23:52
bcardiff has joined #crystal-lang
23:52
fka has quit [Ping timeout: 276 seconds]
23:53
sp4rrow has joined #crystal-lang