rohitpaulk has quit [Remote host closed the connection]
alexherbo2 has joined #crystal-lang
alexherbo27 has joined #crystal-lang
alexherbo2 has quit [Ping timeout: 255 seconds]
_whitelogger has joined #crystal-lang
devil_tux has quit [Read error: Connection reset by peer]
DTZUZO has quit [Ping timeout: 268 seconds]
fanta1 has joined #crystal-lang
fanta1 has quit [Quit: fanta1]
DTZUZO has joined #crystal-lang
alexherbo270 has joined #crystal-lang
alexherbo27 has quit [Ping timeout: 245 seconds]
DmitryBochkarev has joined #crystal-lang
laaron has quit [Remote host closed the connection]
laaron has joined #crystal-lang
DTZUZU has quit [Ping timeout: 245 seconds]
fanta1 has joined #crystal-lang
laaron has quit [Remote host closed the connection]
laaron has joined #crystal-lang
laaron has quit [Remote host closed the connection]
DTZUZO has quit [Ping timeout: 245 seconds]
laaron has joined #crystal-lang
hightower2 has joined #crystal-lang
teardown has quit [Ping timeout: 252 seconds]
teardown has joined #crystal-lang
laaron has quit [Remote host closed the connection]
laaron has joined #crystal-lang
laaron has quit [Client Quit]
laaron has joined #crystal-lang
hightower2 has quit [Ping timeout: 246 seconds]
ashirase has quit [Ping timeout: 244 seconds]
ashirase has joined #crystal-lang
<FromGitter>
<ananagame> how long does it take to a PR to be approved
alexherbo2707 has joined #crystal-lang
alexherbo270 has quit [Ping timeout: 245 seconds]
fanta1 has quit [Quit: fanta1]
_whitelogger has joined #crystal-lang
alexherbo2707 has quit [Ping timeout: 255 seconds]
Jenz has joined #crystal-lang
Jenz has quit [Ping timeout: 246 seconds]
alexherbo2707 has joined #crystal-lang
DmitryBochkarev has quit [Remote host closed the connection]
DmitryBochkarev has joined #crystal-lang
<FromGitter>
<Blacksmoke16> depends, couple hours to a few weeks
<FromGitter>
<Blacksmoke16> i.e. on the scope, when ppl have time irl to review it, if changes are required then waiting on author to implement those changes, maybe some discussion on the feature, etc
fanta1 has joined #crystal-lang
DTZUZO has joined #crystal-lang
bcardiff has joined #crystal-lang
bcardiff has left #crystal-lang [#crystal-lang]
DmitryBochkarev has quit [Ping timeout: 245 seconds]
DmitryBochkarev has joined #crystal-lang
jrayhawk has joined #crystal-lang
<FromGitter>
<kinxer> @dscottboggs_gitlab Can you use modules for that?
<FromGitter>
<paulcsmith> Hmm just now trying out Docker with Crystal and getting *much* slower compile times (about 2-3 times slower). Is that normal for Crystal + Docker? Here is the project if you want to see the Dockerfile and compose file. Maybe I'm just doing something dumb https://github.com/paulcsmith/website-v2
rohitpaulk has joined #crystal-lang
rohitpaulk has quit [Remote host closed the connection]
rohitpaulk has joined #crystal-lang
Jenz has quit [Quit: leaving]
<FromGitter>
<j8r> @paulcsmith are you only with Linux + Docker (no Docker on mac or whatever)?
DTZUZO has quit [Quit: WeeChat 2.0]
DmitryBochkarev has quit [Ping timeout: 250 seconds]
DmitryBochkarev has joined #crystal-lang
DmitryBochkarev has quit [Max SendQ exceeded]
DmitryBochkarev has joined #crystal-lang
DmitryBochkarev has quit [Max SendQ exceeded]
DmitryBochkarev has joined #crystal-lang
DmitryBochkarev has quit [Max SendQ exceeded]
DmitryBochkarev has joined #crystal-lang
DmitryBochkarev has quit [Max SendQ exceeded]
DmitryBochkarev has joined #crystal-lang
DmitryBochkarev has quit [Client Quit]
<FromGitter>
<paulcsmith> @j8r Docker on Mac. Which I know has performance issues, but 2-3 slower compile times seems a bit much :S
<FromGitter>
<j8r> Docker on Mac uses an hypervisor with a Linux inside, which has Docker
<FromGitter>
<j8r> I can't tell, 2-3 times seems quite big
laaron has quit [Remote host closed the connection]
laaron has joined #crystal-lang
rohitpaulk has quit [Ping timeout: 246 seconds]
<mps>
j8r: I have one failed spec test when building 0.28.0
<mps>
it is "Stack overflow" which was also in previous version, 0.27.x
<mps>
I have patch which change 'it' to 'pending' for this problem
<mps>
iirc, straight-shoota told me earlier that this will be fixed in 0.28.0 and he sent me url about that but I can't find this url
<mps>
for now, I will add this patch again to build it
CommanderViral has joined #crystal-lang
return0e has quit [Read error: Connection reset by peer]
return0e has joined #crystal-lang
rohitpaulk has joined #crystal-lang
DTZUZU has joined #crystal-lang
rohitpaulk has quit [Remote host closed the connection]
<FromGitter>
<tenebrousedge> hay Jens
<FromGitter>
<tenebrousedge> what did your benchmark look like? were you using --release ? I'm kinda curious whether the compiler is smart enough to optimize that down to the final value
druonysus has joined #crystal-lang
confact has quit [Ping timeout: 264 seconds]
jetpack_joe has quit [Ping timeout: 264 seconds]
confact has joined #crystal-lang
jetpack_joe has joined #crystal-lang
lucasb has joined #crystal-lang
return0e_ has joined #crystal-lang
Vexatos has quit [Remote host closed the connection]
woodruffw has quit [Ping timeout: 246 seconds]
FromGitter has quit [Ping timeout: 246 seconds]
FromGitter has joined #crystal-lang
return0e has quit [Ping timeout: 246 seconds]
[spoiler] has quit [Ping timeout: 246 seconds]
livcd has quit [Ping timeout: 246 seconds]
robacarp has quit [Ping timeout: 246 seconds]
robacarp has joined #crystal-lang
[spoiler] has joined #crystal-lang
woodruffw has joined #crystal-lang
Vexatos has joined #crystal-lang
<FromGitter>
<dscottboggs_gitlab> Are there any guides on how `Iterator.of` works? I thought you were supposed to yield from the block to create the Iterator but that gives an error about yeilding from captured blocks...
<FromGitter>
<Blacksmoke16> wonder if it has to do with the iterator being called in the yield of the read_array
<FromGitter>
<Blacksmoke16> sec
<FromGitter>
<dscottboggs_gitlab> well, yeah, so the yeild of `#read_array` only happens if `@kind` is already *not* `:end_array` (what I was hoping to check with the if statement).. but like it should yeild 5 times and stop...?