00:20 <FromGitter> <js:nil.im> huh, too *much* contract? I know that too little contrast is an a11y problem, but too much?

00:21 <FromGitter> <js:nil.im> highlighting via JS would be nice indeed, though

00:23 <FromGitter> <oprypin:matrix.org> js (https://matrix.to/#/@js:nil.im): https://www.google.com/search?q=astigmatism+dark+contrast

00:24 <FromGitter> <js:nil.im> interesting - I'm actually one of those having problem with reading black text on white (burns my eyes), so there is no one size fits all solution, I suppose

12:46 <FromGitter> <oprypin:matrix.org> oh god this API is *so good* ⏎ https://github.com/encode/httpx/blob/c09e61d50c8f169187cada6dbf14b89c7763c63f/httpx/_client.py#L886 -> L685 -> L732

12:46 <FromGitter> <oprypin:matrix.org> wish crystal's client was anything like this

12:46 <Stephie> i've thought that many times

12:46 <Stephie> i havent got around to putting in the design effort though

12:47 <Stephie> it can be tricky to compose something high-level while keeping the low-level features that the current HTTP::Client has

12:48 <Stephie> the interesting question is whether it can be done without a breaking change

12:48 <Stephie> especially stuff like middleware which could be useful, especially for cookies

14:10 <yxhuvud> Argh. Where the heck am I waking that fiber except for the intended place?

14:11 <yxhuvud> I've been stuck on this bug for weeks now :(

14:33 <straight-shoota> oprypin, the API of HTTP::Client isn't even that different, is it?

14:34 <straight-shoota> the implementation is a bit confusing, but that's internal details

14:35 <FromGitter> <oprypin:matrix.org> here they are not internal, that's the difference

14:35 <straight-shoota> Stephie, my concerns are not so much about design (I think I have a good concept for that, already partly implemented in a PR), but the hard part is a solid implementation for reusable connection

14:36 <straight-shoota> *s

14:38 <straight-shoota> but aren't those methods just get, exec(method), exec(request) ?

14:43 <FromGitter> <oprypin:matrix.org> yea

14:45 <FromGitter> <oprypin:matrix.org> hold up, hm maybe it is possible?

14:46 <FromGitter> <oprypin:matrix.org> i used to run into issues that just overriding exec wasn't enough https://github.com/crystal-lang/crystal/blob/a94a823f98d3d94915f594fbe5abbd0bc5c62a08/src/http/client.cr#L418

14:47 <FromGitter> <oprypin:matrix.org> this is the weird part https://github.com/crystal-lang/crystal/blob/a94a823f98d3d94915f594fbe5abbd0bc5c62a08/src/http/client.cr#L808

14:47 <straight-shoota> that's self.exec though

15:35 <Stephie> @straight-shoota, i worry more about API than implementation, because API is what hurts to change more

15:35 <Stephie> but thats fair

15:40 <straight-shoota> true