purr changed the topic of #elliottcable to: a
cloudhead has quit [Ping timeout: 240 seconds]
devyn has quit [Ping timeout: 276 seconds]
devyn has joined #elliottcable
wraithgar has joined #elliottcable
wraithgar has quit [Quit: This computer has gone to sleep]
cloudhead has joined #elliottcable
meowrobot has quit [Ping timeout: 250 seconds]
meowrobot has joined #elliottcable
thealphanerd has quit [Quit: farewell for now]
thealphanerd has joined #elliottcable
dsamarin has quit [Ping timeout: 252 seconds]
dsamarin has joined #elliottcable
cloudhead has quit [Ping timeout: 244 seconds]
ec\ has quit [Ping timeout: 260 seconds]
ec\ has joined #elliottcable
purr has quit [Ping timeout: 258 seconds]
purr has joined #elliottcable
cloudhead has joined #elliottcable
Sgeo_ has quit [Ping timeout: 252 seconds]
cloudhead has quit [Quit: leaving]
<jfhbrook> ljharb: how would you fix this https://gist.github.com/jfhbrook/43da2426149f5c426e687bf8c5622512 D:
<jfhbrook> I'm thinking about putting a sanity limit on url length
<jfhbrook> that code is there because of https://github.com/jfhbrook/node-ecstatic/issues/16 afaict
<jfhbrook> also thinking about just removing that and crossing fingers that node core fixed this
wraithgar has joined #elliottcable
<ljharb> jfhbrook: hm
<jfhbrook> right?
<ljharb> jfhbrook: maybe instead of `.replace`, use `.indexOf` (which should be faster and not require a regex) and error out?
<jfhbrook> like just say "lolno" rather than strip?
<purr> lol.
<jfhbrook> that's an interesting idea
<ljharb> that would surface the error more quickly
<ljharb> especially since it's hard to reproduce
<jfhbrook> in 0.12 it throws a null bytes not allowed error
<jfhbrook> apparently
<jfhbrook> but not in v4?
<jfhbrook> whatever
<jfhbrook> I'm an awful maintainer :)
<pikajude> :^)
<pikajude> contract for monsanto: yes or no
<pikajude> I feel like they're evil
<ljharb> to do what for them
<pikajude> I don't know
<pikajude> probably something involving computers
<pikajude> It's also in Missouri
<pikajude> It's more than twice as much as I effectively make hourly, which I'm guessing they'll compensate for by not providing medical insurance
Sgeo_ has joined #elliottcable
embri0n has joined #elliottcable
embri0n_ has joined #elliottcable
embri0n has quit [Ping timeout: 260 seconds]
embri0n_ has quit [Ping timeout: 250 seconds]
eligrey has joined #elliottcable
wraithgar has quit [Quit: This computer has gone to sleep]