tomjoro has quit [Remote host closed the connection]
pitr-ch has quit [Ping timeout: 250 seconds]
daicoden_ has quit [Remote host closed the connection]
daicoden_ has joined #jruby
pawnbox has joined #jruby
subbu has quit [Quit: Leaving]
jeremyevans has joined #jruby
yfeldblum has joined #jruby
yfeldblum has quit [Read error: Connection reset by peer]
yfeldblum has joined #jruby
<daicoden_>
first thing I'm looking at... the default respectfulness of method visibility is different when invoking from jruby executable vs scripting container.
<daicoden_>
if a class is not public, and ruby tries to call a public method, should it work, or should it fail? either way I think is ok, it just is bad that the default is different for each invocation method.
daicoden_ has quit [Remote host closed the connection]
pitr-ch has joined #jruby
daicoden has joined #jruby
tomjoro has joined #jruby
pawnbox_ has joined #jruby
pawnbox has quit [Ping timeout: 260 seconds]
tomjoro has quit [Ping timeout: 244 seconds]
kphns has quit [Ping timeout: 268 seconds]
thedarkone2 has quit [Quit: thedarkone2]
daicoden has quit [Remote host closed the connection]
tomjoro has joined #jruby
tomjoro has quit [Ping timeout: 260 seconds]
daicoden has joined #jruby
<kares>
chrisseaton: ExecJS does not care about exposing a JS interface (it is not its goal) but the embed runtimes usually ... that is at the moment therubyracer and therubyrhino
<kares>
there's also a JS<->Ruby behavior spec suite (redjs) those gems used to have interoperability
<kares>
so if you claim you expose a JS interface maybe you're interested whether you really do :)
daicoden has quit [Remote host closed the connection]
daicoden_ has joined #jruby
pitr-ch_ has joined #jruby
pitr-ch has quit [Read error: Connection reset by peer]
CaptainHeavy has joined #jruby
mistergibson has quit [Quit: Leaving]
<GitHub41>
[jruby] jtulach opened pull request #3749: TCK expects execution of each test in an isolated environment. Creati… (truffle-head...AnEnginePerTckTest) https://git.io/va9MA
vtunka has joined #jruby
<GitHub172>
[jruby] mkristian pushed 1 new commit to jruby-1_7: https://git.io/va9DR
<GitHub172>
jruby/jruby-1_7 2a7d6a9 Christian Meier: something broke after the release of jossl-0.9.14 or later
pawnbox has quit [Ping timeout: 264 seconds]
brauliobo_ has quit [Ping timeout: 248 seconds]
brauliobo_ has joined #jruby
<GitHub101>
[jruby] mkristian opened issue #3750: load path from the command line -I should use the same splitting as for GEM_PATH https://git.io/va9S7
<GitHub64>
jruby/master aeaf963 kares: rename countCommon19 to strCount - support helper class should get rid of 19 suffix
<Lan5432>
I have a lot of files unupdated on my fork, what would be the best way to update it and keep my fix for an issue?
yfeldblum has quit [Remote host closed the connection]
<GitHub23>
[jruby] Lan5432 opened pull request #3752: Fixing for issue #3275 (master...master) https://git.io/va9hA
<Lan5432>
Ah... so that's me :D (I have more or less a clue about what I'm doing)
<Lan5432>
kares: I got the pull request going, I think
<kares>
lan5432: great! thank. couple notes on improving your oss contributions :)
<kares>
- instead of "Fixing for issue #3275" as a message describe what its doing - "removing new class method from interfaces \n\n see #3275"
<kares>
- no need to comment-out code - just remove it
<Lan5432>
Yeah, I was doubting between "reference issues for the sake of avoiding redundancy" or "small details". And about commenting, yeah, I should've deleted, that was a temporal fix, when I was working on it
<Lan5432>
Do you want me to change all of that?
<kares>
lan5432: would be great to update the commit - but its no biggie
<kares>
you can always do cleanup as you add the spec for this feature :)
<kares>
... in another commit
<Lan5432>
I have the spec done, the one I sent you, but it didn't upload
<Lan5432>
Oh, yeah
<Lan5432>
Maybe because the IDE doesn't take into account those
<kares>
just use the git command line than
<kares>
git status should show that there's a spec change
daicoden_ has quit [Remote host closed the connection]
<kares>
you need to lean how to rebase and squash or ammend commits
<Lan5432>
I learned how to ammend, but I'm working on the rest
<kares>
also my comment was just a hint: removing 'new' class method from interfaces \n See issue 3275
<kares>
\n was meant to be a line break
<kares>
a non-escaped new-line in the commit
<kares>
AFK
<Lan5432>
I got a little confused with the whole thing, sorry
<Lan5432>
I thought the command line would interpret it on the commit message
<GitHub120>
[jruby] pitr-ch pushed 7 new commits to master: https://git.io/vaHkH
<GitHub120>
jruby/master 8d3d86f Petr Chalupa: [Truffle] Do not read thread status twice
<GitHub120>
jruby/master c7bee12 Petr Chalupa: [Truffle] formatting
<GitHub120>
jruby/master fc8e6b7 Petr Chalupa: [Truffle] Recover when SafopointAction is not executed due to thread being dead
pawnbox has joined #jruby
vtunka has quit [Quit: Leaving]
daicoden_ has joined #jruby
<Lan5432>
So, should I squash the whole history into one commit? kares
yfeldblum has quit [Ping timeout: 248 seconds]
drbobbeaty has joined #jruby
daicoden_ has quit [Remote host closed the connection]
vtunka has joined #jruby
<kares>
lan5432: whatever works just get rid of the merge commits - pull from master and add your changes
<kares>
if you open a PR there's no need to merge with master as you add changes - the common way if you do need to make it up-to-date with master is to :
<kares>
git pull --rebase origin master
<kares>
and --force push
<Lan5432>
Understood, I will come back when the commit history is simpler
<Lan5432>
Thanks again
shellac_ has joined #jruby
shellac has quit [Ping timeout: 248 seconds]
<kares>
lan5432: feel free to close and open a new one if its too much of a hustle to get your master into shape
<Lan5432>
I think I will do that, but if I can get it done today maybe I'll learn a couple of things about how it works
<GitHub29>
[jruby] kares closed issue #3751: Need to make `oj` work because of its runtime dependency on `boxr`. https://git.io/va9N6
<kares>
lan5432: just be sure to be prepared for potential rebasing as master is still not completely green
<Lan5432>
Is that my fault or is it because we have an ongoing problem in the build?
emarkine has joined #jruby
<emarkine>
Can I use JRuby from Ruby project?
<kares>
lan5432: not your fault - do not worry about it
<kares>
emarkine: hey! what do you mean?
<Lan5432>
I think I got the PR a bit cleaner, but the inner message of the commit still holds the commit messages
<kares>
lan5432: najs I see - you're on the right track
<kares>
what you can try doing now to get the message right :
<kares>
prepare the message you want and: git commit --amend -m "THE-PREPARED-MESSAGE"
<kares>
on the command line
pawnbox has quit [Ping timeout: 244 seconds]
pawnbox has joined #jruby
donV has quit [Quit: donV]
tcrawley-away is now known as tcrawley
djellemah has quit [Remote host closed the connection]
<Lan5432>
Finally got it, the command line was complaining about that command for god knows what reason. The commit should be all clean now, kares . Sorry for all the mess XD
Lan5432 has quit [Quit: Lost terminal]
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #jruby
dfr has quit [Ping timeout: 250 seconds]
lance|afk is now known as lanceball
pawnbox has quit [Remote host closed the connection]
<GitHub189>
[jruby] jtulach closed pull request #3749: TCK expects execution of each test in an isolated environment. Creati… (truffle-head...AnEnginePerTckTest) https://git.io/va9MA
skade has quit [Quit: Computer has gone to sleep.]
brauliobo has joined #jruby
brauliobo_ has quit [Ping timeout: 244 seconds]
shellac has quit [Quit: Computer has gone to sleep.]
shellac has joined #jruby
shellac has quit [Client Quit]
camlow32_ has joined #jruby
camlow32_ has quit [Read error: Connection reset by peer]
camlow32_ has joined #jruby
ITXpander has quit [Quit: Leaving.]
camlow325 has quit [Ping timeout: 246 seconds]
camlow32_ has quit [Remote host closed the connection]
subbu is now known as subbu|meeting
daicoden_ has joined #jruby
camlow325 has joined #jruby
camlow325 has quit [Remote host closed the connection]
daicoden_ has quit [Remote host closed the connection]
norc_ has joined #jruby
skade has joined #jruby
lance|afk is now known as lanceball
subbu|meeting is now known as subbu
subbu is now known as subbu|lunch
shellac has joined #jruby
<GitHub8>
[jruby] chrisseaton pushed 14 new commits to master: https://git.io/vaQFB
<GitHub8>
jruby/master c29964a Chris Seaton: [Truffle] All foreign access factories can share the same IS_NULL
<GitHub8>
jruby/master 9c434de Chris Seaton: [Truffle] Share HAS_SIZE between all factories.
<GitHub8>
jruby/master a01aac6 Chris Seaton: [Truffle] SIZE can also be shared between all factories, even if they return false for HAS_SIZE.
camlow325 has joined #jruby
camlow325 has quit [Remote host closed the connection]
thedarkone2 has joined #jruby
camlow325 has joined #jruby
<GitHub177>
[jruby] chrisseaton pushed 1 new commit to truffle-head: https://git.io/vaQbI
<GitHub177>
jruby/truffle-head 962999a Chris Seaton: Merge branch 'master' into truffle-head
daicoden_ has joined #jruby
shellac has quit [Quit: Computer has gone to sleep.]
subbu|lunch is now known as subbu
camlow325 has quit [Read error: Connection reset by peer]
camlow325 has joined #jruby
shellac has joined #jruby
<GitHub38>
[jruby] chrisseaton pushed 2 new commits to master: https://git.io/vaQpr
<GitHub38>
jruby/master 8c885ab Chris Seaton: [Truffle] We don't need the old ForeignAccessFactory any more.
<GitHub38>
jruby/master 5f82cf2 Chris Seaton: [Truffle] Remove old interop stuff.
daicoden_ has quit [Remote host closed the connection]
ITXpander has joined #jruby
daicoden_ has joined #jruby
robbyoconnor has quit [Ping timeout: 276 seconds]
camlow32_ has joined #jruby
camlow325 has quit [Read error: Connection reset by peer]
<mango-habanero>
hi if I want to get involved in contributing to JRuby what are some good places/simple tasks to start with? I've retrieved the source/built it and have hacked at it a bit locally just to check it out.
erikhatcher has quit [Quit: erikhatcher]
<chrisseaton>
mango-habanero: I think there's a tag for issues suitable for beginners
<enebo>
donV: So I am not sure that is a foolproof check on MRI
<donV>
I only want to detect “—debug” on JRuby to trigger eager load of code for proper coverage.
<enebo>
donV: Without sleithing through the code I don’t know if we set anything ruby facing or whether you need to use a little JI and ask JRuby.runtime somehow
<donV>
OK. Thanks.
<enebo>
donV: a question for you
<donV>
Go ahead :)
subbu|away is now known as subbu
<enebo>
donV: I believe I have fixed 1196 on master but I do not feel like the effort to try and fix this on 1.7 is worth my time right now
<enebo>
1.7 has a completely different runtime so I cannot just cherry-pick the commit
<donV>
9.1.0.0 only is OK by me.
<enebo>
Perhaps this will be just another carrot to get people to move
<donV>
:)
<enebo>
I do see two other failures in MRI tests we excluded
<enebo>
I will look into those briefly to see if we can have no known bugs in coverage
tcrawley is now known as tcrawley-away
<donV>
enebo: That would be great!
lanceball is now known as lance|afk
kares has quit [Ping timeout: 260 seconds]
grs has quit [Ping timeout: 260 seconds]
Antiarc_ has joined #jruby
Antiarc has quit [Ping timeout: 260 seconds]
kares has joined #jruby
daicoden_ has joined #jruby
robbyoconnor has joined #jruby
daicoden_ has joined #jruby
<donV>
enebo: We still need a way to determine if coverage is available. simplecov uses “JRuby.runtime.debug?”, but that is not switched on by “—debug”.
robbyoconnor has quit [Read error: Connection reset by peer]
shellac has quit [Quit: Computer has gone to sleep.]
<donV>
enebo: Java::OrgJruby::RubyInstanceConfig.FULL_TRACE_ENABLED <== This seems to do the trick.
<donV>
enebo: I am thinking of submitting a PR to simplecov to use this test for their JRuby coverage warning. Good idea? Should this be considered a public interface?
grs has joined #jruby
<enebo>
donV: yeah I think it is a good idea…some day we might not need it but we do now.
pawnbox has quit [Ping timeout: 268 seconds]
<enebo>
donV: I was thinking about whether there is a nicer mechanism since I hate those scrunged constants in JI
<enebo>
donV: like org.jruby.RubyInstanceConfig::FULL_TRACE_ENABLED
<donV>
enebo: Somehow that does not work, but org.jruby.RubyInstanceConfig.FULL_TRACE_ENABLED does.
<donV>
You like that better?
<enebo>
oh I think because it makes a method out of it
<enebo>
donV: I do but I dislike the implicit knowledge of those scrunched constants
<enebo>
OrgJRuby:: is pretty weird and bugs me :)
<donV>
OK, but org.jruby is OK. I’ll submit the PR to simplecov.
pawnbox has joined #jruby
pitr-ch_ has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
pitr-ch has joined #jruby
<donV>
enebo: is there a “.jrubyrc” option to set “—debug” ?
<donV>
enebo: Found it: “fullTrace”
<donV>
…or not...
<donV>
enebo: debug.fullTrace works
lance|afk is now known as lanceball
<donV>
enebo: Do you know how far back these options work as they work now? Only 9K?
slash_kick is now known as slash_nick
yfeldblum has quit [Ping timeout: 268 seconds]
<GitHub108>
[jruby] chrisseaton pushed 3 new commits to master: https://git.io/va7lh
<GitHub108>
jruby/master e481f0f Chris Seaton: Revert "[Truffle] Remove old interop stuff."...
<GitHub108>
jruby/master 635e1b6 Chris Seaton: Revert "[Truffle] We don't need the old ForeignAccessFactory any more."...
<GitHub108>
jruby/master b088a32 Chris Seaton: Revert "[Truffle] Use the foreign access DSL."...
<donV>
enebo: Seems like the “—debug” flag on the command line and in JRUBY_OPTS does the trick on JRuby 1.7.20 and master, but the “debug.fullTrace” option in “.jrubyrc” only works on JRuby 9k. Correct?
<enebo>
donV: I don’t know. It is possible
<enebo>
donV: perhaps you need =true
<enebo>
I think in 9k we made the values optional
<enebo>
for boolean options
<donV>
You are right!
<donV>
“debug.fullTrace=true” works with 1.7.20 and 9K
<enebo>
gah some of these tests show how weak our impl may be
shellac has joined #jruby
<enebo>
if you Coverage.start and then get results it is supposed to reset data but if you never have visited the file then I guess it lives through the reset
<enebo>
OR maybe reset just resets all values back to 0 perhaps
<enebo>
hmmm
daicoden_ has quit [Remote host closed the connection]