<headius>
probably early next week if we can get everything we want resolved
<headius>
we're trying to wrap up issues now
<etehtsea>
headius in this case I better start improving socket specs in ruby/spec going commit by commit through your branch. rubysl-socket specs are awesome but they can't be simply copied to ruby/spec due to relicensing issues
<headius>
I think the rubysl-socket specs are still licensed like rubyspec was
<etehtsea>
headius I think this is not a big deal to add LICENSE in every spec, but I have no clue how to support (extend/fix) them after
<headius>
hmm
<headius>
I have some code in the specs history and I did not authorize a relicense
<headius>
etehtsea: I asked Yorick for confirmation
<headius>
for now I think it's enough to just include BSD license at project root with a listing of the files to which it applies
<headius>
BSD does not require license header in the file
<etehtsea>
ok, got it
<etehtsea>
headius as long as you here: there is an issue which is blocking me from fixing (get|set)sockopt: https://github.com/jnr/jnr-constants/issues/16 I can't say that I precisely looked through socket man, but I have a feeling that SOMAXCONN shouldn't be found through its value
<headius>
I'm confused...it looks like MRI has the same value for both too
<headius>
is the problem that it's doing a reverse lookup of the value?
<headius>
oh I think I understand
<headius>
they do have the same value, that's not a problem
<etehtsea>
yep, all socket options are inside hashmap and it looks like SOMAXCONN overrides SO_LINGER because of equal values
<headius>
the problem is that SOMAXCONN is not part of the SO enum
<headius>
but we represent it as such
<headius>
so when we go to get the option from the value, we get SOMAXCONN and don't think it's valid
<headius>
is that right?
<etehtsea>
yep
<headius>
ok
<headius>
hmm
<headius>
etehtsea: I guess the right fix is to move SOMAXCONN out of SocketOption eh?
<headius>
it's not there on all platforms
<headius>
e74f5211b98797377236e41a41301a4918352dc8 in jnr-constants
etehtsea has quit [Quit: Computer has gone to sleep.]
pawnbox has quit [Ping timeout: 252 seconds]
etehtsea has joined #jruby
pitr-ch has joined #jruby
etehtsea has quit [Quit: Computer has gone to sleep.]
TheWhip_ has joined #jruby
TheWhip has quit [Ping timeout: 244 seconds]
dinfueh__ has joined #jruby
dinfuehr_ has quit [Ping timeout: 265 seconds]
claudiuinberlin has joined #jruby
etehtsea has joined #jruby
pitr-ch has quit [Ping timeout: 244 seconds]
pitr-ch has joined #jruby
<GitHub172>
[jruby] kares opened issue #4091: concurrent loading does not resolve loaded constant https://git.io/v6PQR
pitr-ch has quit [Read error: Connection reset by peer]
pitr-ch has joined #jruby
pitr-ch has quit [Read error: Connection reset by peer]
pitr-ch_ has joined #jruby
etehtsea has quit [Quit: Computer has gone to sleep.]
TheWhip_ has quit [Remote host closed the connection]
TheWhip has joined #jruby
vtunka has joined #jruby
etehtsea has joined #jruby
<chrisseaton>
headius: I'll fix that today
<eregon>
headius etehtsea: about ruby/spec and rubysl specs: the licensing situation is not ideal but it's not worth duplicating specs writing either since the licenses are so close.
<eregon>
headius: I am not sure what's the "right" thing to do though. By just reading the BSD license it seems including it in the file header would be one option.
<eregon>
If it's added to the root then do we need some COPYING file to list files with a different license? What about the license of the project as a whole?
<etehtsea>
eregon there is other interesting thins. mspec used in rubysl-socket has version 2.9.1 and latest available in ruby/mspec is 2.8.0
<etehtsea>
and I didn't find repo with it. only gem on rubygems.org/gems/mspec
<eregon>
it's probably the mspec in rubinius/rubinius
<etehtsea>
I'm trying to do bin/jruby -S rake spec:fetch_latest_mspec_repo --trace and it fails with error NameError: uninitialized constant MSPEC_GIT_REPO
<etehtsea>
where these constant expected to be defined?
shellac has joined #jruby
etehtsea has quit [Quit: Computer has gone to sleep.]
dinfueh__ has quit [Remote host closed the connection]
dinfuehr_ has joined #jruby
dinfuehr_ has quit [Remote host closed the connection]
zacts has joined #jruby
etehtsea has joined #jruby
etehtsea has quit [Quit: Computer has gone to sleep.]
claudiuinberlin has quit [Remote host closed the connection]
nowhereFast has joined #jruby
prasunanand has quit [Remote host closed the connection]
claudiuinberlin has joined #jruby
zacsek has joined #jruby
lanceball is now known as lance|afk
claudiuinberlin has quit [Ping timeout: 260 seconds]
<GitHub99>
jruby/master fc1f469 Mark Prins: fix up appveyor.yml...
<GitHub99>
jruby/master e7b55eb Thomas E Enebo: Merge pull request #4092 from mprins/patch-1...
lance|afk is now known as lanceball
<bascule>
_____ ____ ___ ____ _ __ ___ _ _
<bascule>
| ___| _ \|_ _| _ \ / \\ \ / / | | |
<bascule>
| |_ | |_) || || | | |/ _ \\ V /| | | |
<bascule>
| _| | _ < | || |_| / ___ \| | |_|_|_|
<bascule>
|_| |_| \_\___|____/_/ \_\_| (_|_|_)
<bascule>
temporalfox has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<zacsek>
Hi! When you're implementing a Java interface in Ruby, and the interface has several overloaded methods, how can you specify which function should work for which Java signature ( if you use jrubyc then you have java_signature, but can you use it otherwise also, or what's the equivalent)
enebo has quit [Quit: enebo]
claudiuinberlin has joined #jruby
TheWhip has joined #jruby
dminuoso has quit [Ping timeout: 258 seconds]
temporalfox has joined #jruby
isjaylee has joined #jruby
<headius>
java_signature doesn't support overloads well at the moment either
<headius>
the unfortunate answer at present is you have to define a single method for all overloads and then inspect the types of the parameters
<headius>
zacsek: ^
<headius>
etehtsea: those tasks may be a little stale...eregon set us up with a subtree relationshp to ruby/spec that requires a small incantation to update
<GitHub160>
[jruby] headius closed issue #4020: Rails app on 9.1.2.0 raises stackoverflow exceptions after 6-8 hours of activity following an upgrade from 1.7. https://git.io/vKwYN
claudiuinberlin has quit [Remote host closed the connection]
isjaylee has left #jruby [#jruby]
<GitHub26>
[jruby] chrisseaton pushed 1 new commit to master: https://git.io/v61IF
<GitHub26>
jruby/master 5f939b2 Chris Seaton: [Truffle] Ignore alias of #allocate in ostruct.
dinfueh__ has joined #jruby
dinfuehr_ has quit [Read error: Connection reset by peer]
<eregon>
mmh, but the trick is library specs don't seem to run in that job :p
<eregon>
probably time to review the jruby.2.3.mspec config file :)
<headius>
we cut out many specs to keep CI runs reasonable
<headius>
the "fast" spec run only does language and core
<eregon>
maybe it would be useful to run the rest in another CI job? If that's too long, then just exclude those spawning sub rubies but not the whole library/ or files
<headius>
yeah, that would be useful if it doesn't add a lot to total CI run
<headius>
or perhaps just pull in specs that exercise libraries that are different in JRuby
<eregon>
I have an automatic tagger of "slow" specs in the truffle.mspec config, essentially anything that calls ruby_exe, ruby_cmd etc gets tagged as slow and doesn't run
<headius>
ahh, that's nice
<headius>
automatic?
<eregon>
yeah, just running specs creates the tag, then you can commit the tags
<headius>
I could see us pulling in library specs for native JRuby libraries like sockets
<headius>
sounds like a feature that should go in mspec