<GitHub67>
[jruby] headius pushed 1 new commit to ruby-2.4: https://git.io/vQi11
<GitHub67>
jruby/ruby-2.4 8275435 Charles Oliver Nutter: Coercion fixes for bitwise operators on Integer and custom types.
<headius>
subbu: whitespace o_O
<headius>
and other formatting
<headius>
good change otherwise, nice to remove another frame field
<subbu>
headius, i know .. sorry .. i was lazy to back out the change, suppress it in my vim config, etc.
<headius>
git add -p helps me in those cases, only add the lines I want
<headius>
no worries
<subbu>
ah, right .. i forgot about that.
<subbu>
i was trying to look if there was another way of handling the break issue without the try-finally ... but looks like the finally is the best solution right now .. couple quick ideas i examined (by code inspection, not coding) based on frame, dynscope can be brittle.
<headius>
subbu: yeah it's unfortunate
<headius>
I do not have good measurements to tell how much overhead it has
<headius>
subbu: we only need to do this for break, right?
<headius>
I don't think we use the escaped status for anything else right now
<headius>
that would reduce it a lot...most blocks don't have break in them