<
GitHub32>
jruby/master 538b5e0 kares: creating a new shared US-ASCII string instance shall hold on to its name
<
GitHub92>
jruby/ji-to-java-file 0ac10ac kares: [ji] support converting Ruby File -> Java File; no need to set meta-class
<
GitHub18>
[jruby] kares opened pull request #4756: [ji] support converting Ruby File -> Java File (master...ji-to-java-file)
https://git.io/v5swk
claudiuinberlin has joined #jruby
vtunka has joined #jruby
_whitelogger has joined #jruby
<
GitHub25>
jruby/jruby-9.1.13.0 916b1e1 kares: Class#subclasses should work correctly - not return internal wrappers...
vtunka has quit [Quit: Leaving]
vtunka has joined #jruby
<
GitHub140>
[jruby] kares closed pull request #4756: [ji] support converting Ruby File -> Java File (master...ji-to-java-file)
https://git.io/v5swk
<
GitHub12>
jruby/master 7a5a14b Karol Bucek: [ji] support converting Ruby File -> Java File; no need to set meta-class...
drbobbeaty has joined #jruby
<
GitHub165>
[jruby] original-brownbear opened pull request #4757: #4752 Start adding JMH benchmarks (master...jmh)
https://git.io/v5sbU
bbrowning_away is now known as bbrowning
vtunka has quit [Quit: Leaving]
vtunka has joined #jruby
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
claudiuinberlin has joined #jruby
claudiuinberlin has quit [Client Quit]
<
GitHub163>
jruby/ji-io-to-java 67adda7 kares: [ji] make RubyIOs Java Closeable/Flushable + to_java to return stream...
<
GitHub163>
jruby/ji-io-to-java 55c26a7 kares: RubyIO cleanup - deprecate 19/unused methods; less isNil() checks
claudiuinberlin has joined #jruby
vtunka_ has joined #jruby
vtunka_ has quit [Client Quit]
vtunka has quit [Quit: Leaving]
vtunka has joined #jruby
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
claudiuinberlin has joined #jruby
<
GitHub136>
jruby/master 112e365 kares: RubyIO cleanup - deprecate 19/unused methods; less isNil() checks
<
kares>
enebo: headius: will be updating jossl for 9.1.13 - IBM JVM users have been noisy about having it in asap
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
claudiuinberlin has joined #jruby
<
enebo>
kares: great
<
GitHub61>
jruby/jruby-9.1.13.0 89ed3b6 Karol Bucek: upgrade jruby-openssl to 0.9.21 (#4726)...
<
GitHub131>
jruby/ji-io-to-java 9878cf0 kares: [ji] make RubyIOs Java Closeable/Flushable + to_java to return stream...
vtunka has quit [Quit: Leaving]
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
vtunka has joined #jruby
<
headius>
kares: +1
vtunka has quit [Quit: Leaving]
claudiuinberlin has joined #jruby
<
GitHub95>
[jruby] kares opened pull request #4758: [ji] make RubyIOs Java Closeable/Flushable + to_java to return stream (master...ji-io-to-java)
https://git.io/v5GBB
<
headius>
checking off a lot of boxes on 2.4 bug today
<
GitHub63>
jruby/master cdb9423 Charles Oliver Nutter: Clarify reason for this exclusion.
<
GitHub63>
jruby/master 5ff7385 Charles Oliver Nutter: DateTime#to_time now preserves timezone. #4293....
<
GitHub63>
jruby/master 02169fa Charles Oliver Nutter: Doco.
<
kares>
if you guys have a chance to look at the native set.rb PR
<
kares>
hoping to get all my PRs done this week ... as I might be off a few :)
<
headius>
9.1.13 should go out soon and then we'll shore up 2.4
<
headius>
I mean 9.2
<
headius>
I'm going to pivot back to perf this week since it looks like we're high 9X% done with 2.4 features
<
headius>
enebo: a quick chat about 2.4
<
headius>
that's the original set of 2.4.0 items
<
headius>
the majority of unfinished stuff falls into two categories: refinements (more reflection support, introspection) and case-folding updates
<
headius>
at this point I think we're probably close enough for a 9.2.0
<
enebo>
I don't really understand 4687 if we have a ruby 2.4 label
<
headius>
we are running up-to-date 2.4 tests from just a month or two ago
<
enebo>
seems we can just make one issue per and then just search for ruby 2.4 label
<
headius>
labels are only good if we file issues...do you want separate issues?
<
enebo>
for individual missing features in 2.4?
<
headius>
there's dozens of minor excludes
<
enebo>
Issues like these tend to never close so that is my only concern
<
enebo>
or several years later we make a few issues and finally close it
<
headius>
well the one I opened for 2.3 drew in a number of PRs
<
headius>
it was one-stop shopping for a list of stuff we don't do
<
enebo>
yeah I guess it is only a minor thing to me
<
headius>
I'm fine making everything separate issues, and I did do it for bigger things like case handling
<
headius>
it was just a lot of small things that didn't seem worthy of their own issues
<
enebo>
well we should definitely be making individual issues for things someone can observe as fix so we can add them to release notes
<
enebo>
that perhaps is less an issue for first 2.4 release but subsequent point releases we should be
<
enebo>
but with that said if this issue helps people find missing 2.4 behavior then that has value
<
headius>
sure, it's just time consuming to figure out which failures should group together, what MRI feature or change they're associated with, etc
<
enebo>
yeah earlier in the cycle we just know something is not passing but not specifically is wrong
<
headius>
we are much better off for 2.4 than we were for 2.3
<
headius>
that was a big leap and we left more stuff behind
<
enebo>
oh yeagh I just foudn it
<
headius>
I was going to follow a similar format for the 2.4 issue, with a checklist of things we didn't get to or weren't sure how to do
<
enebo>
hahah ObjectSpace.count_imemo_objects
<
headius>
you see some of these boxes got their own issues later and then got resolved
<
enebo>
I think I understand the motivation
<
enebo>
It is ok to have this
<
headius>
it's also a nice single place to link in 9.2 release notes
<
enebo>
we only have 7 issues marked against ruby 2.3 including that one
<
headius>
nothing appears to have changed since I last audited this list
<
headius>
meaning it's up to date
<
headius>
so then for now I'll proceed with wrapping up the remaining checklist items into the 2.4 leftovers bug
<
headius>
probably a good time for a call to uses to start checking out master?
<
enebo>
yeah I guess it will also show people our intention again as well
<
headius>
ci snapshot index is weird again
<
headius>
only shows the full listing of objects and I can't go into snapshots/master
claudiuinberlin has joined #jruby
claudiuinberlin has quit [Read error: Connection reset by peer]
tenderlove has joined #jruby
tenderlove has quit [Remote host closed the connection]
tenderlo_ has joined #jruby
tenderlo_ is now known as tenderlove
m4rCsi has quit [Read error: Connection reset by peer]
m4rCsi has joined #jruby
bbrowning is now known as bbrowning_away