<GitHub100>
[jcodings] lopex pushed 1 new commit to master: https://git.io/vpLEN
olle has quit [Quit: olle]
shellac has quit [Quit: Computer has gone to sleep.]
rdubya has joined #jruby
shellac has joined #jruby
sidx64 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
sidx64 has joined #jruby
rdubya has quit [Quit: Leaving.]
sidx64 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
sidx64 has joined #jruby
<enebo>
kares: so you never replied to me over a week ago about the extra noisy logging via instrumentation. Can you give me a way of reproducing that?
<enebo>
I am wondering if you see a warning come up
<nirvdrum>
That `run' method is undefined.
<enebo>
nirvdrum: I actually think my logic for 'if (!tokenSeen || !warnings.isVerbose()) {'
<enebo>
is wrong
<enebo>
oh!!
<enebo>
!tokenSeen || warnings.isVerbose
<enebo>
not !isVerbose
<enebo>
heh
<enebo>
nirvdrum: someone reported seeing the warning in that eval for frozen-string-literakl being set too late
<enebo>
nirvdrum: but that logic is clearly weird...I will only try and go into it after first token if !isVerbose
<nirvdrum>
MRI no-ops on any of the magic comments if a token has already been seen.
<nirvdrum>
At least that was my read of it.
<nirvdrum>
It will still warn, though, if warnings are enabled.
<enebo>
nirvdrum: funny I was pretty confused and then once you showed up on chat...boom that is obvious :)
<enebo>
nirvdrum: our sets have warns in them if tokenSeen and return without doing it
<enebo>
nirvdrum: so I think that is similar to how MRI does it
<enebo>
There is still something weird though
<enebo>
my tokenSeen guarding the warning seems like it has to be the same as MRIs at that point but they do not have this extra if around magic comment processing we both do
<enebo>
so they must noop that some place else
<enebo>
Maybe I shouldn't care though tokenSeen optimization accomplishes whatever I am missing in MRI source
sidx64 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<GitHub126>
[jruby] enebo pushed 1 new commit to jruby-9.1: https://git.io/vptmY
<GitHub126>
jruby/jruby-9.1 07e2088 Thomas E. Enebo: Fix #5128. eval in Rack::Builder prints "warning: `frozen_string_literal' is ignored after any tokens"....
<GitHub163>
[jruby] enebo closed issue #5128: eval in Rack::Builder prints "warning: `frozen_string_literal' is ignored after any tokens" https://git.io/vx1oE