<headius[m]> kares: delete your module/class locking branch plz
drbobbeaty has joined #jruby
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
lucasb has quit [Quit: Connection closed for inactivity]
nirvdrum has quit [Remote host closed the connection]
nirvdrum has joined #jruby
victori_ has quit [Ping timeout: 240 seconds]
nirvdrum has quit [Ping timeout: 268 seconds]
victori has joined #jruby
rusk has joined #jruby
<kares[m]> done, thanks
travis-ci has joined #jruby
travis-ci has left #jruby [#jruby]
<travis-ci> jruby/jruby (master:256a673 by Karol Bucek): The build is still failing. https://travis-ci.org/jruby/jruby/builds/598012613 [48 min 53 sec]
nirvdrum has joined #jruby
nirvdrum has quit [Ping timeout: 265 seconds]
nirvdrum has joined #jruby
shellac has joined #jruby
KeyJoo has joined #jruby
<kares[m]> * done, thanks for the reminder
<kares[m]> what's up with com.github.jnr:jffi:jar:1.2.21 not being found?
<kares[m]> its not on central - do not even see at sonatype's
nirvdrum has quit [Ping timeout: 268 seconds]
KeyJoo has quit [Quit: KeyJoo]
nirvdrum has joined #jruby
<headius[m]> Hmm
<headius[m]> Yeah it's not out there
nirvdrum has quit [Remote host closed the connection]
<headius[m]> I'll deal with that today...I know I closed and released it but it must have failed after that
nirvdrum has joined #jruby
lucasb has joined #jruby
<olleolleolle[m]> "I think I will run this a few times" hehe
<headius[m]> olleolleolle: oh I suppose these are needed for runs that don't use the JRuby launcher
<headius[m]> kares: I reverted the release commits and running it again
<olleolleolle[m]> https://github.com/rspec/rspec-rails/pull/2148 This is now green @head
<olleolleolle[m]> * https://github.com/rspec/rspec-rails/pull/2148 This is now green @headius
<headius[m]> @oll
<headius[m]> olleolleolle: very cool! I the warnings were causing failures I guess?
<headius[m]> kares: it would sure help release process if Sonatype would run this on something larger than a pocket calculator
<headius[m]> I swear it gets slower every time
<kares[m]> heh ;)
<headius[m]> kares: should be on its way now
<headius[m]> you can build an install the tag if you're stuck
<olleolleolle[m]> The failures earlier were of the type:
<olleolleolle[m]> LoadError: load error: childprocess/jruby -- java.lang.reflect.InaccessibleObjectException: Unable to make field private int java.io.FileDescriptor.fd accessible: module java.base does not "opens java.io" to module org.jruby.dist
<headius[m]> We need to get 9.2.9 out...that shouldn't happen
<headius[m]> 9.2.9 does reflection "the right way" (I hope) by querying a class's module to see if it's open or not
<headius[m]> so it would fail to get the fd field but fall back on non-native IO stuff
drbobbeaty has joined #jruby
<olleolleolle[m]> Wonderful, https://github.com/rspec/rspec-rails/pull/2148 is now merged.
<enebo[m]> so let's see what we need to do for 9.2.9
<headius[m]> stdlib needs to happen, I'll get on that now
<headius[m]> that was delayed...in progress already
<headius[m]> ahh I suppose RG needs update too
<headius[m]> must remember not to include bundler
<headius[m]> enebo: actually looks like we default to a newer RG than 2.5.7 anyway
<headius[m]> so I think this may be it, pushing stdlib update branch PR
<enebo> coolio
<headius[m]> gonna grab coffee while travis chews on that
<headius[m]> er
<headius[m]> what the heck is going on with jffi
<headius[m]> it's out there now but build still failed...caching I suppose
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
drbobbeaty has joined #jruby
<olleolleolle[m]> headius: PR 5917 had some "JRuby-related code comments" removed, my question in the PR was "did you remove those intentionally, or by accident?", were they hand-crafted by the JRuby team, or existing in the stdlib codebase?
xardion has quit [Remote host closed the connection]
<headius[m]> yeah I notice some of those now
<headius[m]> and there's some calls to openssl session_new_cb that we don't appear to have
xardion has joined #jruby
<headius[m]> olleolleolle: thank you!
subbu is now known as subbu|away
<headius[m]> ok I missed a few other chunks in resolv.rb
<headius[m]> ok comments restored and the missing OpenSSL calls reverted back to how they were done before
<headius[m]> I'm reviewing changes to resolv.rb because that patch didn't apply cleanly
travis-ci has joined #jruby
<travis-ci> jruby/jruby (master:256a673 by Karol Bucek): The build was fixed. https://travis-ci.org/jruby/jruby/builds/598012613 [246 min 21 sec]
travis-ci has left #jruby [#jruby]
<headius[m]> kares: we'll have to chat about https://github.com/jruby/jruby-openssl/issues/190
shellac has quit [Ping timeout: 250 seconds]
<headius[m]> looks like it's going green now
<headius[m]> enebo: probably good to go on that PR
subbu|away is now known as subbu
<enebo> headius[m]: ok if things pass merge it since it addresses 3 CVEs
<enebo> so we sort of need it
<headius[m]> rdoc was in already
<headius[m]> what were the other CVEs?
<enebo> (2 are webrick and 1 is rdoc)
<headius[m]> ah ok
<enebo> err I think one is rdoc
<enebo> so fnmatch does not apply
<enebo> and shell is so uncommon that you will execute an untrusted $0 for a shell command I don't know why it is a CVE
<headius[m]> well it's all in there anyway
<enebo> yeah I am justifying why this was not a fire drill I guess :)
<headius[m]> that's the current diff of stdlib vs MRI 2.5.7
<headius[m]> we should try to whittle that thing down
<enebo> lol what is that ludump change for
<enebo> ah masking warn
<headius[m]> merged and Ruby version constants updated on master
<enebo> this sort of makes me wish date was a gem
<enebo> or most of this parsing code anyways
<headius[m]> it is in MRI
<headius[m]> but it's almost all ext
<headius[m]> we have our own hybrid
<enebo> if we could commit to that gem then I suppose we would still need to deal with those differences but this overall diff would shrink a lot
<headius[m]> we could certainly push our version as a jruby-date gem...with or without the ext bits
<headius[m]> with ext bits would mean moving the date code out of our repo
<enebo> is this because we use 'java' right?
<headius[m]> DateLibrary etc
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
<headius[m]> yes
<enebo> ah yeah true
<headius[m]> some of these changes would be trivial to push back to MRI I suppose
<enebo> I guess MRI probably does not want rbconfig to load there if they don't need to
<headius[m]> it should work the same
<enebo> next if RUBY_ENGINE == 'jruby' && !m.respond_to?(:instance_methods)
<headius[m]> ah, that's true
<headius[m]> could make it a PR and see how they receive it
<headius[m]> pretty sure that one is for package modules
<headius[m]> our really blank slate stuff screws up the objectspace walking there
<enebo> hehe that 2186 one is from codehaus
<headius[m]> yeah
<enebo> probably JI modules not having it
<headius[m]> package modules
<headius[m]> heh, apparently this commit kept getting wiped out: https://github.com/jruby/jruby/search?q=2186&type=Commits
<enebo> yeah that was what I meant...I know kares[m] recently added some method back
<headius[m]> s'possible it is fine now, I'm not sure
<enebo> we could probably even add instance_methods back to java modules since the liklihood of a java package being named that is fairly small
<headius[m]> yeah pretty unlikely
<enebo> It really is a bummer Java never had package aliases
<headius[m]> heh yeah, it's not there at present
<headius[m]> so until that changes this patch is necessary
<enebo> headius[m]: yeah I am wondering if we will get bitten by adding it back as a method or not :)
<enebo> That one dude shows up who happens to be using a package named that
<enebo> tbh I only see a few things which probably can be upstreamed
<headius[m]> I assume everything we do bites us in some way at this point, so it would just be nice to get rid of the diff
<enebo> comments about proxies could since they just reference JRuby
<headius[m]> for that one dude he can still import using a string
<enebo> yeah I agree it is worth the trouble
<headius[m]> it really only affects the lazy package walking stuff
<enebo> true
<headius[m]> the comments about proxies go with JRuby-specific code changes
<headius[m]> though...hmmm
<headius[m]> why did those code changes not show up here
<headius[m]> ahhh
<headius[m]> 90da3007e205cfe864c4f364f6a92a9bb79e693c
<headius[m]> moved to generic.rb
<headius[m]> so it's still cool
rusk has quit [Remote host closed the connection]
<lopex> kares[m]: nope, it's just provided with logstash
subbu is now known as subbu|lunch
nirvdrum has quit [Ping timeout: 265 seconds]
subbu|lunch is now known as subbu
nirvdrum has joined #jruby
nirvdrum has quit [Ping timeout: 276 seconds]