15:36 <headius[m]> Good morning!

15:49 <havenwood> headius[m]: g'mornin'!

15:52 <headius[m]> 👋

15:53 <headius[m]> only one 9.2.9 bug report related to debugging, so far not too bad

16:11 <rdubya[m]> headius: do you know if there is a good spot for documentation on the difference between the --client and --server flags for jruby?

16:19 <headius[m]> They mostly do nothing now

16:20 <headius[m]> back when you could switch modes at the JDK level they just passed through -client and -server

16:20 <headius[m]> I believe those options are ignored by all JDKs from the last decade+

16:20 <rdubya[m]> lol

16:20 <rdubya[m]> ok, makes sense

16:23 <headius[m]> Probably could deprecate and remove at some point 😀

16:26 <headius[m]> enebo: so I found where intellij/rubymine keeps the ruby-debug-base gem but I don't see any unpacked version of it

16:27 <enebo[m]> headius: so maybe they will need to roll it into next release

16:27 <headius[m]> if we can even find someone to release the gem

16:28 <headius[m]> we can probably build a version for this user to swap in but unsure if it will get picked up

16:28 <headius[m]> should have had a jruby-debug-base gem 😶

16:29 <enebo[m]> ouch this is actually a project where we make a jar for another project

16:29 <headius[m]> yeah

16:30 <enebo[m]> OMGZ this downloads and patches test files from ruby-debug

16:31 <enebo[m]> https://github.com/jruby/jruby-debug/blob/master/patch-0.10.4.diff

16:32 <enebo[m]> haha I don't remember doing this at all but I remember doing weird shit to make nb ruby to debug

16:32 <headius[m]> oif

16:32 <enebo[m]> no doubt all the line number related aspects are fixed

16:33 <headius[m]> too bad this has all fallen into disrepair...it was one of the few places we collaborate across a number of impls and with multiple IDE developers

16:33 <enebo[m]> number of frames probably is better or fixed

16:33 <enebo[m]> If I remembered it existed I probably would have made it 9.x only and fixed it

16:35 <enebo[m]> in any case I do not think ruby-debug-base is even used by ruby-debug anymore

16:35 <enebo[m]> https://rubygems.org/gems/debase

16:35 <enebo[m]> is the 2.x backend for ruby-debug now

16:36 <headius[m]> aha

16:36 <enebo[m]> this library hooks TracePoint directly in C

16:36 <headius[m]> Ushakov still working on it

16:36 <enebo[m]> but it is the proper path forward for a long-term solution

16:36 <enebo[m]> for JRuby?

16:37 <enebo[m]> ah in general

16:38 <headius[m]> debase is present in the gems from my ruby plugin install

16:39 <headius[m]> https://www.reddit.com/r/ruby/comments/drjl6o/jruby_9290_released/

16:39 <enebo[m]> ~1700 lines of C...likely ~1/2 in Java assuming we can get any reasonable parity. I would think so

16:44 <headius[m]> I pinged mr Ushakov on twitter

17:00 <headius[m]> enebo: changing gears for a moment...I just managed to make a gem that builds the async-profiler JVM plugin

17:01 <headius[m]> the idea being that a user could install jruby-async-profiler and then get a launcher for JRuby that starts it up with appropriate flags

17:02 <headius[m]> I wanted to try this out after deprecating --client and --server and realizing that there's no replacement for the --sample flag's use of -Xprof in Java 10+

17:02 <headius[m]> so --sample needs to be able to find async-profiler to do an equivalent profile

17:18 <enebo[m]> headius: that sounds cool enough

17:20 <headius[m]> I have --sample using it if present now and warning on JDK9+ when it's not present

17:20 <headius[m]> this is turning out easier than I thought

17:23 <travis-ci> jruby/jruby (master:b1377e1 by kares): The build was broken. https://travis-ci.org/jruby/jruby/builds/607239130 [202 min 10 sec]

20:14 <travis-ci> jruby/jruby (master:b1377e1 by kares): The build was broken. https://travis-ci.org/jruby/jruby/builds/607239130 [202 min 13 sec]

20:55 <headius[m]> So I have something working now

20:56 <headius[m]> I'm trying to figure out how to filter out the native calls in async-profiler's flat sample because they dominate these profiles

21:00 <headius[m]> https://gist.github.com/headius/4490fdac21b663527512ca11b5e799e7

21:01 <headius[m]> I tried this with only three times loops and Java code doesn't even show up in the top 30 or so entries

21:01 <headius[m]> and that top entry is from the agent itself for its profile gathering...so there's gotta be a way to filter this

21:16 <enebo[m]> I had a similar issue with async when looking at gem list and it was dominated with libc and lower stuff

21:17 <enebo[m]> a lot of extra locking jvm internals making the actual program meat very slender in a flame graph

21:20 <headius[m]> yeah

21:21 <headius[m]> I mean this profile is interesting but the actionable bits are lost in the native noise

21:21 <headius[m]> much of this is from Hotspot's C2 JIT

21:22 <headius[m]> now I should point out that async-profiler has several much more useful formats...I'm just trying to get this to be a rough equivalent to the java-only -Xprof output

21:23 <headius[m]> ideally I think this jruby-async-profiler gem can install a launcher script that spits out a flame graph or flat or call stacks as text, with sampled methods and async and locks and such all as simple options

21:25 <enebo[m]> yeah something which can be a little more friendly than that command line itself

21:26 <enebo[m]> which should also be possible to use but it is not friendly

21:33 <headius[m]> yeah mostly the sampled and allocation profiles will be best, but also passing flags to force JIT to get more Ruby in the results (especially for allocation profile)