ur5us__ has joined #jruby
ur5us__ has quit [Remote host closed the connection]
ur5us__ has joined #jruby
ur5us__ has quit [Ping timeout: 276 seconds]
ur5us__ has joined #jruby
ur5us__ has quit [Ping timeout: 252 seconds]
nirvdrum has joined #jruby
<headius[m]> Ok time for .17
shellac has joined #jruby
<headius[m]> g'day folks
<headius[m]> what is up with master
shellac has quit [Ping timeout: 268 seconds]
<headius[m]> surprising number of fixes for a two week delta
<headius[m]> er, three?
<headius[m]> I removed parens around the issues lists and added alt text of the bug titles
<headius[m]> where is your script for generating issue list? might save me time putting together the more detailed notes
<headius[m]> hmm I think I like it better with parens
<headius[m]> enebo: I am done fiddling with it
<headius[m]> now to these master failures
<headius[m]> enebo: I think these are related to the isBuiltin fix altering how it detects reopened float and fixnum, but it doesn't appear to impact 9.2
<enebo[m]> well that is good
<enebo[m]> for posterity the script for issues is the rake task issues on our website
<headius[m]> ok
<headius[m]> enebo: where are you in release process
<headius[m]> I am checking on this thing... only seems to affect overridden methods in Complex
<enebo[m]> all bits are released
<enebo[m]> website is getting updated soon
<headius[m]> cow's out of the barn then I guess
<enebo[m]> I am aediting that now
<enebo[m]> yeah I mean we have to do it hours before we put out any annoucement
<enebo[m]> so I usually do this in the morning
<headius[m]> yeah
<enebo[m]> so are you concerned we broke something with that callsite change?
<headius[m]> I can't prove we didn't yet
<headius[m]> these tests all rewrite Rational or Complex math methods and test that they get picked up so it would not be a severe issues if we did
enebo has joined #jruby
ChanServ changed the topic of #jruby to: Get! http://jruby.org/ | http://wiki.jruby.org | http://logs.jruby.org/jruby/ | http://bugs.jruby.org | Paste at http://gist.github.com
enebo has left #jruby [#jruby]
<headius[m]> I figured out the issue
<headius[m]> this is an old line of code but it should be returning method.isBuiltin(), not just true
<headius[m]> my fix did not break anything but since it properly caches now it hits this bad logic
<headius[m]> I am checking to see what all is affected
<headius[m]> it appears to only be used by the math sites, and in 9.2 I do not see any code calling it outside those sites
<headius[m]> I think 9.2 is safe!
<enebo[m]> great
<enebo[m]> If it was only math sites I would not be super concerned anyways
<headius[m]> but master calls it for some improved Complex logic which is why we see the failures there
<enebo[m]> Not enough to do another immediate release anyways
<headius[m]> these tests may not exist on 9.2 branch but in any case this isBuiltin does not appear to be used there
<headius[m]> 😌
<headius[m]> whew
<enebo[m]> I am updating releases entry/tag via github
<headius[m]> ok I have a fix for this in process but will finish release stuff shortly
travis-ci has joined #jruby
travis-ci has left #jruby [#jruby]
<travis-ci> jruby/jruby (jruby-9.2:84d363d by Thomas E. Enebo): The build was broken. https://travis-ci.com/jruby/jruby/builds/221548876 [179 min 19 sec]
<enebo[m]> like clockwork
<enebo[m]> commit coming up for SNAPSHOT version
<headius[m]> fixed on 9.2 and master
<headius[m]> master should go green now
<headius[m]> back to release items
<enebo[m]> weird...GH releases is putting each issue on its own line I guess because of the newlines
<headius[m]> enebo: yeah I fixed that
<enebo[m]> ok I am merging them to be one line which looks to do the job
<headius[m]> that is wierd... next line indented same should be part of the same first bullet line
<headius[m]> I already did on the GH release
<headius[m]> looks like you already did all this so I will move on to other tasks
<enebo[m]> yeah so tweet and docker
<headius[m]> download page points at 9.1.17 notes
<enebo[m]> 9.2.16
<enebo[m]> fixing
<headius[m]> er yeah that
<enebo[m]> I did notice how weird it looks to see both 9.1.17 and 9.2.17 on the same page too
<enebo[m]> soon 9.1 will be off that page though
<headius[m]> yeah
<travis-ci> jruby/jruby ( by Thomas E. Enebo): The build failed. https://travis-ci.com/jruby/jruby/builds/221548887 [176 min 32 sec]
travis-ci has left #jruby [#jruby]
travis-ci has joined #jruby
<headius[m]> like and subscribe
<rdubya[m]> 🎉
<headius[m]> I think that'
<headius[m]> that's everything
<travis-ci> jruby/jruby (jruby-9.2:4d82c26 by Thomas E. Enebo): The build was fixed. https://travis-ci.com/jruby/jruby/builds/221551048 [178 min 43 sec]
travis-ci has joined #jruby
travis-ci has left #jruby [#jruby]
travis-ci has joined #jruby
<travis-ci> jruby/jruby (master:324cd78 by Charles Oliver Nutter): The build was fixed. https://travis-ci.com/jruby/jruby/builds/221551172 [213 min 46 sec]
travis-ci has left #jruby [#jruby]
<headius[m]> woot
<headius[m]> enebo: do you do anything to update installers?
<enebo[m]> no but I sent out the email to people on release
<headius[m]> yeah I figured I would do this to get it moving on GHA
ur5us__ has joined #jruby
<headius[m]> enebo: I fixed favicon on jruby.org site so it will show up in link expanders and such
<headius[m]> it was still using an old favicon.ico windows file and not the formats modern web uses
<headius[m]> hmm
<headius[m]> not quite perfect I guess
<headius[m]> aargh
nirvdrum has quit [Ping timeout: 268 seconds]
ur5us__ has quit [Ping timeout: 258 seconds]