<krzk>
mszyprow: memeka: "mali" for regulator_get() is a supply name so it should match what is in DT before "-supply"...
<krzk>
Therefore mszyprow you're right....
<krzk>
and this patch should not work
<mszyprow>
krzk: this patch might work, because regulator_get might check for global regulator name, which in case of odroid is vdd_g3d
<krzk>
Mhmm... didn't know but makes sense
freekurt has quit [Read error: Connection reset by peer]
freekurt has joined #linux-exynos
oliv3r[m] has joined #linux-exynos
<memeka>
mszyprow krzk the patch is being carried over since 4.0, there was no mali-supply i think back then, and had to be set vdd_g3d ... it continued working and didn't really think if it's needed anymore :)
<mszyprow>
memeka: it should be safe to drop it now
<memeka>
mszyprow: correct, thank you
<memeka>
mszyprow: [ 2.048248] mali 11800000.gpu: Failed to get regulator
<memeka>
[ 2.051946] mali 11800000.gpu: Power control initialization failed
<mszyprow>
memeka: deferred probe?
<mszyprow>
memeka: with mali->vdd_g3d it ends with the following message: "mali 11800000.gpu: Continuing without Mali regulator control"
wwilly__ has joined #linux-exynos
<mszyprow>
memeka: second mali probe is succesfull
<mszyprow>
memeka: I've just tried your odroidxu4-5.4.y branch with commit 45e94493c31cacfc5c500fc4df853cd6d2731f83 reverted
<memeka>
mszyprow ok so after that error, it works on a second probe?
<mszyprow>
yep
wwilly_ has quit [Ping timeout: 240 seconds]
<memeka>
mszyprow: i see, thanks
<mszyprow>
memeka: in case of defered proba, mali driver should simply avoid printing any error message
<mszyprow>
# dmesg | grep mali
<mszyprow>
[ 1.507917] mali 11800000.gpu: Power control initialization failed
<mszyprow>
[ 1.504228] mali 11800000.gpu: Failed to get regulator
<mszyprow>
[ 2.562628] mali 11800000.gpu: GPU identified as 0x0620 r0p1 status 0
<mszyprow>
[ 2.568069] mali 11800000.gpu: Protected mode not available
<mszyprow>
[ 2.573856] mali 11800000.gpu: Probed as mali0