avsm changed the topic of #mirage to: Good news everyone! Mirage 3.0 released!
ansiwen has quit [Quit: No Ping reply in 210 seconds.]
ansiwen has joined #mirage
yomimono has quit [Ping timeout: 268 seconds]
copy` has quit [Quit: Connection closed for inactivity]
smkz_ has joined #mirage
smkz has quit [Ping timeout: 255 seconds]
insitu has joined #mirage
insitu has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
insitu has joined #mirage
mort___ has joined #mirage
pyvpx has quit [Read error: Connection reset by peer]
pyvpx has joined #mirage
mort___ has quit [Quit: Leaving.]
mort___ has joined #mirage
mephage has joined #mirage
<mephage>
New ocamler here, I'm going through the mirage tutorial. Can't tell if there's an error or I'm just not getting it: https://mirage.io/wiki/hello-world
<mephage>
On the tutorial/hello/config.ml explanation, the module "Main" is referenced but only the "Hello" module exists - 'Notice that we refer to the module name as a string ("Unikernel.Main")'
<mephage>
A previous sentence says the same 'In this case, the main variable declares that the entry point of the process is the Main module from the file unikernel.ml'
<mephage>
I was going to submit a PR to fix it but wanted to be sure I wasn't just missing something obvious.
<reynir>
I think you're right that it's an error
<hannes>
mephage: well spotted, please submit a PR. The module is Hello, not Main!
<mephage>
Sweet, does the PR need to be accompanied by an issue? Or is just a PR fine?
<hannes>
a PR is fine, no need to create an issue
<mephage>
Cool. Thanks for the help
<hannes>
thank _you_ for spotting and fixing this :)
<hannes>
mephage: (there are 2 Main -> Hello and another Hello.Main -> Unikernel.Hello required afaics)
dinosaure has quit [Ping timeout: 260 seconds]
dinosaure has joined #mirage
<mephage>
hannes: Thanks, yeah I saw that. PR submitted - 21:34 < mephage> A previous sentence says the same 'In this case, the main variable declares that the entry point of
<mephage>
the process is the Main module from the file unikernel.ml'