<arigato>
it fails when reading a random binary file
<kenaan>
arigo default 643daedf4ed9 /rpython/rlib/: issue #2557: file.read(1) could return 2 bytes on Windows
<amaury>
great, thank you
<amaury>
so it was the \r\n translation
<arigato>
after a \r not followed by \n, the following char gets inside a one-char buffer, and was always appended the next time ignoring the fact that we asked for only one char
<arigato>
yes, of course
<amaury>
Didn't we consider at some point to use FILE* like CPython?
<amaury>
I think I remember changes in this direction
<arigato>
right, but at the same time it wouldn't apply to pypy3.x anyway
<amaury>
Sure. But the code would probably be simpler than this early pre-version of io.py
<amaury>
and at pypy2 would be bug-compatible with CPython.
<kenaan>
antocuni faster-rstruct-2 09d1f6469168 /rpython/rlib/rstruct/standardfmttable.py: add a fastpath for floats and doubles
<kenaan>
antocuni faster-rstruct-2 38cd23755b61 /rpython/rlib/rstruct/: use the fast path also for the native float/double packing
<kenaan>
antocuni faster-rstruct-2 91e0aa0b6c31 /: rename fmtiter.result into wbuf, which makes more sense
<kenaan>
antocuni faster-rstruct-2 00ab2f34b4af /pypy/module/struct/: pass an external wbuf to PackFormatIterator
<kenaan>
antocuni faster-rstruct-2 a8366709a997 /pypy/module/struct/: now that we have all the necessary infrastructure, implement pack_into in a more efficient way, so that...
<kenaan>
antocuni faster-rstruct-2 973fa84efaef /: whoo... finally reach the whole point of the branch: struct.pack_into(bytearray...) takes the fast path :)
<kenaan>
antocuni faster-rstruct-2 6c228d591ce8 /rpython/rlib/rstruct/: we cannot use the fastpath for '<f' or '>f', because we need to check for overflow in that case. It is ...
<kenaan>
antocuni faster-rstruct-2 e18391926354 /rpython/jit/: fix the tests in jit/backend/x86/test/test_llop.py:test_gc_store*
<kenaan>
antocuni faster-rstruct-2 1bffd7929b3f /pypy/module/pypyjit/test_pypy_c/test_struct.py: fix the test_pypy_c tests about the struct module, now that we have the fast path also for packing
<kenaan>
antocuni faster-rstruct-2 4c03a04236a1 /pypy/module/pypyjit/test_pypy_c/test_struct.py: add tests for the fast paths of struct.unpack on raw buffers and bytearrays
<kenaan>
antocuni faster-rstruct-2 b3c274e5c60c /pypy/module/pypyjit/test_pypy_c/test_struct.py: add tests for the fast path of pack_into