00:00
danieljabailey has joined #pypy
00:44
asmeurer_ has joined #pypy
01:16
marky1991 has joined #pypy
01:35
asmeurer_ has quit [Quit: asmeurer_]
01:58
marr has quit [Ping timeout: 240 seconds]
02:00
slackyy has quit [Read error: Connection reset by peer]
02:30
adamholmberg has joined #pypy
02:39
slackyy has joined #pypy
02:43
tbodt has joined #pypy
03:02
ArneBab has joined #pypy
03:02
adamholmberg has quit [Remote host closed the connection]
03:02
adamholmberg has joined #pypy
03:06
ArneBab_ has quit [Ping timeout: 240 seconds]
03:07
adamholmberg has quit [Ping timeout: 240 seconds]
03:26
pilne has quit [Quit: Quitting!]
03:42
marky1991 has quit [Ping timeout: 260 seconds]
03:59
ArneBab_ has joined #pypy
04:03
ArneBab has quit [Ping timeout: 240 seconds]
04:14
adamholmberg has joined #pypy
04:25
adamholmberg has quit [Remote host closed the connection]
04:26
adamholmberg has joined #pypy
04:31
adamholmberg has quit [Ping timeout: 260 seconds]
04:44
tbodt has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
05:09
jamesaxl has joined #pypy
06:02
zmt00 has quit [Quit: Leaving]
06:28
adamholmberg has joined #pypy
06:33
adamholmberg has quit [Ping timeout: 260 seconds]
07:07
oberstet has quit [Ping timeout: 268 seconds]
07:12
the_drow has quit [Ping timeout: 260 seconds]
07:29
adamholmberg has joined #pypy
07:34
adamholmberg has quit [Ping timeout: 268 seconds]
07:39
asmeurer_ has joined #pypy
07:41
asmeurer_ has quit [Client Quit]
07:53
the_drow has joined #pypy
08:30
adamholmberg has joined #pypy
08:35
adamholmberg has quit [Ping timeout: 250 seconds]
08:59
slackyy has quit [Ping timeout: 250 seconds]
09:04
<
fijal >
XXX I think errors are not handled correctly here
09:05
<
fijal >
date: Wed Nov 14 19:28:11 2007 +0000
09:05
<
fijal >
cfbolz: that's your commit from just over 10 years ago :-)
09:05
<
fijal >
in runicode.py
09:05
<
fijal >
I think so too tbh
09:05
<
fijal >
they're surely brittle and untested
09:05
<
cfbolz >
I claim innocence
09:05
<
fijal >
I believe you!
09:06
<
fijal >
cfbolz: do you want to pair on writing hypothesis tests?
09:06
<
cfbolz >
sorry, we're having visitors in like 20 min
09:06
<
fijal >
no worries :)
09:06
<
fijal >
maybe I can drag someone else
09:21
jamesaxl has quit [Read error: Connection reset by peer]
09:22
jamesaxl has joined #pypy
09:29
<
arigato >
fijal: I'm draggable, if you want me to
09:29
<
fijal >
arigato: cool!
09:30
<
fijal >
arigato: and yes, I want to, should we try that atom teletype feature btw?
09:30
<
fijal >
or regular screen?
09:30
<
fijal >
let me finish the current incarnation
09:31
<
arigato >
I'm fine with Atom Teletype, but isn't that an OS/X only product?
09:32
<
fijal >
does not seem to be
09:32
<
fijal >
it used to be, I think
09:32
<
fijal >
I mean if you exceed ~5min trying to get it to run Im ok giving up :)
09:38
marr has joined #pypy
09:39
<
arigato >
sorry, busy with unexpected things, will be back in 10min
09:44
<
fijal >
oh hey, python is adding module.__getattr__, AMAZING
09:45
antocuni has joined #pypy
10:14
<
kenaan_ >
fijal unicode-utf8 3e5acb0a1e81 /pypy/: start working on more obscure codecs and completely remove hacks that go via UCS4 from unicodehelper. Now unic...
10:32
adamholmberg has joined #pypy
10:37
adamholmberg has quit [Ping timeout: 268 seconds]
10:44
<
kenaan_ >
arigo unicode-utf8 0a3c81c3f67d /rpython/rlib/: Rename this directory to avoid name conflict with "rutf8.py"
10:53
<
kenaan_ >
fijal unicode-utf8 e4a80363506c /pypy/interpreter/: in progress
10:53
<
kenaan_ >
fijal unicode-utf8 78c8a9571b3d /rpython/rlib/: merge
11:02
demonimin has joined #pypy
11:29
jcea has joined #pypy
11:33
adamholmberg has joined #pypy
11:38
adamholmberg has quit [Ping timeout: 248 seconds]
11:49
oberstet has joined #pypy
12:06
raynold has quit [Quit: Connection closed for inactivity]
12:34
adamholmberg has joined #pypy
12:38
adamholmberg has quit [Ping timeout: 264 seconds]
12:41
lritter has joined #pypy
12:57
<
kenaan_ >
fijal unicode-utf8 4668380f4c79 /pypy/: * Improve ascii/utf8 codecs and unicode escape * Raise instead of looping infinitely when errorhandler returns...
13:16
Rhy0lite has joined #pypy
13:20
<
kenaan_ >
stian math-improvements e6c9af023bc5 /: Test and fix for int rbinop overflow to long, also add a deeper test for int_floordiv
13:33
<
kenaan_ >
stian math-improvements 89a762f37f25 /pypy/objspace/std/test/test_intobject.py: Add test for overflow with regular binops too, now there should be test for all changes to intobject
13:35
adamholmberg has joined #pypy
13:41
adamholmberg has quit [Ping timeout: 248 seconds]
14:02
<
kenaan_ >
stian math-improvements 9291ee92df89 /: Test for int_pow, test+fix for pow ValueError with third argument as 0
14:08
<
kenaan_ >
stian math-improvements 6ba5b9334842 /rpython/rlib/rbigint.py: Typo in comment
14:12
jcea has quit [Quit: jcea]
14:15
<
kenaan_ >
fijal unicode-utf8 d17afc06eedf /pypy/interpreter/: fixes
14:32
adamholmberg has joined #pypy
14:40
marky1991 has joined #pypy
14:45
marky1991 has quit [Ping timeout: 268 seconds]
14:56
marky1991 has joined #pypy
15:00
the_drow has quit [Ping timeout: 240 seconds]
15:04
marky1991 has quit [Ping timeout: 248 seconds]
15:09
yuyichao_ has quit [Ping timeout: 240 seconds]
15:11
<
kenaan_ >
mattip default d632e9ca79ae /rpython/rlib/rvmprof/test/test_rvmprof.py: call register_code to profile functions, cleanup
15:13
mattip_ has joined #pypy
15:13
the_drow has joined #pypy
15:14
marky1991 has joined #pypy
15:19
mattip_ has left #pypy ["bye"]
15:21
yuyichao_ has joined #pypy
15:32
<
kenaan_ >
fijal unicode-utf8 d18dd16d58c7 /rpython/rlib/rposix.py: silence a warning on OS X
15:43
<
kenaan_ >
fijal default 6c9c3791d06a /rpython/rlib/rposix.py: silence a warning on OS X
15:43
<
kenaan_ >
fijal default 21fd35c44d66 /rpython/: merge
15:53
<
arigato >
seems not to work. I'll try to restart the buildmaster next
15:54
bbot2 has quit [Quit: buildmaster reconfigured: bot disconnecting]
15:54
bbot2 has joined #pypy
15:55
<
kenaan_ >
fijal unicode-utf8 f074b4987d57 /pypy/: fixes until we get to formatting problems
15:56
<
arigato >
mattip: fixed I think
15:57
<
fijal >
arigato: it seems maybe I'm getting somewhere
16:03
<
fijal >
merge will be a nightmare, but other than that I'm almost done with removing all the references to runicode
16:03
<
fijal >
formatting is a big leftover
16:12
mattip_away has joined #pypy
16:14
<
mattip_away >
arigato: thanks. I will look at installing virtualenv as part of the tests a bit later
16:19
mattip_away has quit [Remote host closed the connection]
16:20
<
fijal >
space.newunicode(''.join(self.getdata()).decode('latin-1'))
16:20
<
fijal >
how many copies does that do....
16:26
<
Alex_Gaynor >
Does `getdata` allocate stuff, or just return a value?
16:26
<
Alex_Gaynor >
And does it return `list of strings` or `list of chars`?
16:27
KronTMX has joined #pypy
16:27
<
Alex_Gaynor >
Assuming it's list of chars, `"".join()` gets you one alloc + copy. `decode('latin-1')` is another alloc + copy.
16:27
<
fijal >
getdata returns a value
16:27
<
fijal >
list of chars, I believe
16:28
<
Alex_Gaynor >
I think it's two allocs + copies then.
16:54
zmt00 has joined #pypy
16:55
the_drow has quit [Ping timeout: 240 seconds]
17:03
marky1991 has quit [Ping timeout: 264 seconds]
17:04
lritter has quit [Remote host closed the connection]
17:05
lazy1 has joined #pypy
17:07
<
lazy1 >
I wonder if someone is willing to have a look at my code embedding pypy and see if there are obvious speed improvements that can be done.
17:08
<
fijal >
lazy1: that's quite a few, no?
17:08
<
lazy1 >
We aim for 100k+
17:08
the_drow has joined #pypy
17:11
<
fijal >
C.strdup(val.encode('utf-8'))
17:11
<
fijal >
what is that for?
17:11
<
fijal >
and keep the result alive till the end of the function
17:11
<
fijal >
but what you should do is:
17:11
<
lazy1 >
IIRC I read it on the cffi docs somewhere. Sharing memory between two runtimes is tricky
17:11
<
fijal >
that seems wrong
17:11
<
lazy1 >
Go strings are encoded as utf-8 and from what I saw if I don't use strdup pypy might claim the memory while Go is still using it
17:11
<
fijal >
ffi.new("char*", val.encode("utf8")
17:11
<
fijal >
so x = ffi.new("char*", val.encode("utf8"))
17:11
<
fijal >
and then x survives till the function dies
17:11
<
lazy1 >
There are two cases. One is there I call C functions exported from Go and then I can do that
17:12
<
lazy1 >
But in the result I can't since it's returned to Go
17:12
<
fijal >
also your dicts have 2 dict-of-indirection
17:12
<
fijal >
but you free the result right?
17:12
<
lazy1 >
Yes, in get_result
17:12
<
lazy1 >
For some reason freeing it from Go sometimes caused a segfault
17:13
marky1991 has joined #pypy
17:13
<
lazy1 >
What do you mean by dict-of-indirection?
17:13
raynold has joined #pypy
17:13
marky1991 has quit [Remote host closed the connection]
17:13
<
fijal >
it's lower_dict -> another dict
17:13
<
fijal >
I have no idea TBH where the time is spent
17:13
<
lazy1 >
Oh, that's since it' HTTP headers and they are case insensitive
17:13
marky1991 has joined #pypy
17:14
<
fijal >
yeah but you can do that more efficient on lookup
17:14
<
fijal >
I would run it under valgrind or perf (with pypy with debug symbols) and see where the time is spent before actually looking
17:16
<
lazy1 >
Are there instructions online somewhere on how to do that?
17:16
<
fijal >
how to do what?
17:16
<
fijal >
a) you compile pypy yourself and b) you run valgrind --tool=callgrind pypy <something>
17:16
<
fijal >
and c) send me the output
17:17
<
fijal >
it's a regular c-level profiler, that's about 30x slower
17:17
<
fijal >
you can try to use perf instead
17:17
<
lazy1 >
What about cProfile?
17:17
<
fijal >
lazy1: what I mean is that by using a C-level profiler, you should be able to tell what's taking time. Go? Python? layer in between?
17:17
<
fijal >
cProfile is garbage
17:18
<
fijal >
vmprof is what we recommend (also has problems, but less so than cProfile, maybe)
17:18
<
antocuni >
note that nowadays nightly builds include debug symbols
17:18
<
antocuni >
so no need to recompile pypy
17:19
<
lazy1 >
IIRC compiling pypy was a lot of coffee
17:19
the_drow has quit [Ping timeout: 248 seconds]
17:19
<
fijal >
takes ~40min, but indeed, use nightly
17:20
<
lazy1 >
fijal: How is vmprof better than cProfile?
17:20
<
fijal >
it's a statistical profiler
17:20
<
fijal >
so comes with virtually no overhead
17:20
<
fijal >
the overhead in cProfile depends a lot from function to function, which means the output cannot be sanely trusted
17:21
<
antocuni >
also, vmprof knows about the JTI
17:21
<
lazy1 >
OK, will give it a try
17:21
<
fijal >
antocuni: well, cProfile does too, to an extent
17:22
<
fijal >
lazy1: I wish vmprof was a bit better though, it has somewhat hard to read errors every now and again
17:22
<
antocuni >
I'd say that cProfile gives completely screwed data
17:29
oberstet has quit [Ping timeout: 248 seconds]
17:33
the_drow has joined #pypy
17:39
<
fijal >
arigato: do you know stuff about formatting by any chance?
17:39
<
fijal >
ah never mind found what I was looking for
17:45
lazy1 has quit [Ping timeout: 268 seconds]
17:48
the_drow has quit [Ping timeout: 240 seconds]
17:59
jcea has joined #pypy
18:01
the_drow has joined #pypy
18:03
antocuni has quit [Ping timeout: 252 seconds]
18:14
<
fijal >
pom pom pom
18:14
<
fijal >
formatting looks like it should
*almost* work as is
18:23
<
fijal >
(but it's slicing utf8 strings so it's a bit awkward)
18:28
marky1991 has quit [Ping timeout: 248 seconds]
18:33
oberstet has joined #pypy
18:35
<
LarstiQ >
snow! snow!
18:35
<
kenaan_ >
rlamy py3.5 feaba8e9bb0a /pypy/module/_io/: Bug-for-bug compatibility (and performance optimisation) in BufferedReader.readinto1()
18:48
tbodt has joined #pypy
18:49
<
kenaan_ >
rlamy py3.5 a5d1206f11e4 /lib-python/3/test/test_io.py: Remove comment: this test is not supposed to fail any more
19:06
<
kenaan_ >
rlamy py3.5 5c2561dd0c89 /lib-python/3/test/test_pydoc.py: Fix tests to match PyPy behaviour
19:07
lazy1 has joined #pypy
19:11
lazy1 has quit [Ping timeout: 240 seconds]
19:25
<
kenaan_ >
rlamy py3.5 a84f8ceb8740 /lib-python/3/test/test_tracemalloc.py: Skip tracemalloc tests
19:33
<
fijal >
pom pom pom...
19:38
slackyy has joined #pypy
19:47
tbodt has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
19:49
asmeurer has joined #pypy
20:11
asmeurer has quit [Quit: asmeurer]
20:12
asmeurer__ has joined #pypy
20:22
asmeurer__ has quit [Quit: asmeurer__]
20:26
tbodt has joined #pypy
20:30
Rhy0lite has quit [Quit: Leaving]
20:32
marky1991 has joined #pypy
20:42
KronTMX has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
21:35
marky1991 has quit [Remote host closed the connection]
21:35
marky1991 has joined #pypy
21:44
marky1991 has quit [Ping timeout: 248 seconds]
21:54
antocuni has joined #pypy
21:56
<
fijal >
test/test_dictmultiobject.py::AppTest_DictMultiObject::test_internal_delitem RPython traceback:
21:56
<
fijal >
Fatal RPython error: KeyError
21:56
<
fijal >
Abort trap: 6
21:58
<
arigato >
pypy 5.9?
21:58
<
fijal >
no, older one
21:58
<
arigato >
I think there was a bug like that, yes
21:59
<
fijal >
test_mutate_while_extend loops infinitely
21:59
<
fijal >
(or at least takes forever)
21:59
<
fijal >
trying to run objspace tests on top of pypy
21:59
<
arigato >
try running on pypy 5.9?
21:59
<
fijal >
I have a more recent build even
21:59
<
arigato >
right, even better
21:59
<
fijal >
arigato: try running objspace/std/test on pypy-c? (without -A)
22:00
marky1991 has joined #pypy
22:00
marky1991 has quit [Remote host closed the connection]
22:01
marky1991 has joined #pypy
22:04
<
arigato >
I have 38ac9e4520a1, still running
22:06
<
kenaan_ >
fijal unicode-utf8 b2f3bd9151c0 /: work on formatting
22:08
<
arigato >
no, works fine with this version
22:08
<
arigato >
what version are you using exactly (both of pypy-c and of the pypy source code)?
22:10
<
fijal >
10e8aaa42286+
22:10
<
fijal >
not very useful :-/
22:10
<
fijal >
b2f3bd9151c0+ (unicode-utf8) tip
22:11
<
fijal >
that's the branch
22:14
<
arigato >
seems my version is slightly older
22:16
<
fijal >
arigato: I
*think* the only thing left is charmap encoding
22:17
<
fijal >
(and billions of small things and a merge to py3k)
22:17
<
arigato >
cool, you're definitely getting into things that I don't even know they exist :-)
22:20
<
arigato >
note that the Fatal RPython KeyError you get is documented in the test itself
22:21
<
arigato >
but you only got that with the old PyPy, right? not with 10e8aaa42286+
22:22
<
arigato >
ok, and test_mutate_while_extend might just be a bit fragile
22:26
marky1991 has quit [Read error: Connection reset by peer]
22:26
marky1991 has joined #pypy
22:31
pybot has quit [Ping timeout: 252 seconds]
22:32
pybot has joined #pypy
22:32
jamesaxl has quit [Read error: Connection reset by peer]
22:41
tbodt has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
22:41
tbodt has joined #pypy
22:44
traverseda has quit [Ping timeout: 268 seconds]
22:56
traverseda has joined #pypy
22:58
adamholmberg has quit [Remote host closed the connection]
22:58
adamholmberg has joined #pypy
23:02
adamholmberg has quit [Ping timeout: 240 seconds]
23:11
pilne has joined #pypy
23:28
asmeurer__ has joined #pypy
23:30
antocuni has quit [Ping timeout: 268 seconds]
23:54
tbodt has quit [Quit: My Mac has gone to sleep. ZZZzzz…]