00:06
jcea has joined #pypy
00:14
adamholmberg has quit [Remote host closed the connection]
00:15
adamholmberg has joined #pypy
00:58
speeder39_ has joined #pypy
01:28
xcm has quit [Read error: Connection reset by peer]
01:29
xcm has joined #pypy
01:36
jcea has quit [Quit: jcea]
02:30
dddddd has quit [Remote host closed the connection]
02:48
oberstet_ has quit [Remote host closed the connection]
03:18
speeder39_ has quit [Quit: Connection closed for inactivity]
03:41
<
mattip >
scikit-build wraps cmake and is needed to build opencv
03:41
<
mattip >
python-opencv
03:56
_whitelogger has joined #pypy
05:06
<
cfbolz >
mattip: nice!
06:28
Masklinn has joined #pypy
06:32
tsaka__ has quit [Ping timeout: 272 seconds]
06:47
xcm has quit [Remote host closed the connection]
06:49
xcm has joined #pypy
07:07
oberstet has joined #pypy
07:10
inhahe has joined #pypy
07:35
mattip has quit [Ping timeout: 244 seconds]
07:38
themsay has quit [Read error: Connection reset by peer]
07:39
themsay has joined #pypy
07:57
tsaka__ has joined #pypy
08:02
mattip has joined #pypy
09:01
mattip has quit [Ping timeout: 258 seconds]
09:05
themsay has quit [Ping timeout: 246 seconds]
09:18
jacob22 has quit [Read error: Connection reset by peer]
09:21
antocuni has joined #pypy
09:21
jacob22 has joined #pypy
09:21
mattip has joined #pypy
09:24
rubdos_ is now known as rubdos
09:35
themsay has joined #pypy
09:59
themsay has quit [Read error: Connection reset by peer]
10:00
themsay has joined #pypy
10:02
mvantellingen has quit [Ping timeout: 252 seconds]
10:10
pierreg has joined #pypy
10:11
mvantellingen has joined #pypy
10:22
mvantellingen has quit [Ping timeout: 252 seconds]
10:22
pierreg has quit [Quit: Page closed]
10:22
pierreg has joined #pypy
10:45
xcm has quit [Remote host closed the connection]
10:47
xcm has joined #pypy
10:47
dddddd has joined #pypy
11:02
jamadden has joined #pypy
11:09
antocuni has quit [Ping timeout: 272 seconds]
11:22
mvantellingen has joined #pypy
11:23
jcea has joined #pypy
11:46
kajetanj has joined #pypy
11:46
kajetanj has left #pypy [#pypy]
11:46
kajetanj has joined #pypy
11:50
kajetanj has quit [Client Quit]
11:58
adamholmberg has quit [Remote host closed the connection]
11:59
adamholmberg has joined #pypy
12:03
adamholmberg has quit [Ping timeout: 248 seconds]
12:18
lritter has joined #pypy
12:29
antocuni has joined #pypy
13:00
Masklinn has quit [Ping timeout: 246 seconds]
13:02
Masklinn has joined #pypy
13:02
jcea has quit [Remote host closed the connection]
13:06
adamholmberg has joined #pypy
13:11
jcea has joined #pypy
13:17
pierreg has quit [Quit: Page closed]
13:33
<
kenaan >
mattip py3.6 b0cb066e7e1f /pypy/: trivial fixes
13:33
Rhy0lite has joined #pypy
14:08
<
arigato >
issue 3014: "how could it ever have worked"
14:08
<
arigato >
I think it's caused by the following optimization pass:
14:10
<
arigato >
p95 = new_array(4, descr=<ArrayU 1>)
14:10
<
arigato >
# copy 4 bytes into this new array:
14:10
<
arigato >
# read the initial two bytes as a single operation:
14:10
<
arigato >
i127 = gc_load_indexed_i(p95, 0, 1, 16, 2)
14:10
<
arigato >
call_n(ConstClass(ll_arraycopy__arrayPtr_arrayPtr_Signed_Signed_Signed), p96, p95, 0, 0, 4, descr=<Callv 0 rriii EF=2 OS=1>)
14:10
<
arigato >
gets optimized as:
14:10
<
arigato >
p182 = new_array(4, descr=<ArrayU 1>)
14:10
<
arigato >
i235 = gc_load_indexed_i(p182, 0, 1, 16, 2)
14:10
<
arigato >
setarrayitem_gc(p182, 0, i183, descr=<ArrayU 1>)
14:10
<
arigato >
setarrayitem_gc(p182, 1, i186, descr=<ArrayU 1>)
14:10
<
arigato >
setarrayitem_gc(p182, 2, i188, descr=<ArrayU 1>)
14:10
<
arigato >
setarrayitem_gc(p182, 3, i190, descr=<ArrayU 1>)
14:10
<
arigato >
the load has been moved before the four setarrayitem_gc's
14:11
<
arigato >
or more precisely the setarrayitem_gc have been delayed and occur later in the trace
14:14
<
mattip >
since what you have here definitely looks wrong
14:15
Graypup_ has joined #pypy
14:17
<
antocuni >
I am using struct.unpack extensively in capnpy and in gambit we have lots of processing reading them 7/24, never found any error
14:17
<
arigato >
it's clearly what occurs, I could write an optimizeopt test
14:19
<
arigato >
note that in pypy, the problem only seems to occur by struct.unpack(.., bytearray(..)[:slice])
14:19
<
antocuni >
ah I see, it's the slice which produces the ll_arraycopy
14:19
<
arigato >
yes, but for some reason the optimizeopt test doesn't require ll_arraycopy
14:19
<
antocuni >
ok, this is a pattern I never use, so it explains why I never encountered the bug
14:20
<
arigato >
maybe it's a pattern where you build a bytearray somehow and then pass it to struct.unpack()
14:24
<
arigato >
ah, if you manipulate a string (and not a bytearray) then you get lots of copystrcontent, which are not reordered
14:40
Masklinn has quit [Ping timeout: 246 seconds]
14:41
irclogs_io_bot has quit [Remote host closed the connection]
14:48
<
kenaan >
arigo default 4570c3e9b030 /rpython/jit/metainterp/optimizeopt/: Issue #3014 The gc_load family of operations must force the lazy setfields and setarrayitems to occur first
14:50
<
kenaan >
arigo default 7419bb5bbb41 /rpython/jit/metainterp/optimizeopt/heap.py: meh, fix for 4570c3e9b030
14:52
irclogs_io_bot has joined #pypy
14:54
<
kenaan >
arigo default 631c5b49bd25 /rpython/jit/metainterp/optimizeopt/test/test_optimizeopt.py: Improve the test, still passing
14:57
Masklinn has joined #pypy
15:14
Masklinn has quit []
15:41
<
cfbolz >
arigato: ouch
15:41
<
cfbolz >
That's really terrible
17:00
moei has joined #pypy
17:15
antocuni has quit [Ping timeout: 248 seconds]
17:28
jamadden has quit [Quit: Leaving.]
17:29
<
arigato >
yes, bad us
17:37
jacob22 has quit [Read error: Connection reset by peer]
17:41
jacob22 has joined #pypy
18:17
Ai9zO5AP has joined #pypy
18:52
lritter has quit [Remote host closed the connection]
18:57
speeder39_ has joined #pypy
19:12
mattip has quit [Ping timeout: 244 seconds]
19:18
mattip has joined #pypy
19:21
Rhy0lite has quit [Quit: Leaving]
19:46
xcm has quit [Remote host closed the connection]
19:49
lritter has joined #pypy
19:50
xcm has joined #pypy
20:32
xcm has quit [Remote host closed the connection]
20:35
xcm has joined #pypy
21:19
xcm has quit [Remote host closed the connection]
21:20
xcm has joined #pypy
21:22
adamholmberg has quit [Remote host closed the connection]
21:23
adamholmberg has joined #pypy
21:27
adamholmberg has quit [Ping timeout: 246 seconds]
21:29
adamholmberg has joined #pypy
21:30
adamholmberg has quit [Remote host closed the connection]
21:49
oberstet has quit [Remote host closed the connection]
21:49
xcm has quit [Remote host closed the connection]
21:51
xcm has joined #pypy
22:03
Ai9zO5AP has quit [Quit: WeeChat 2.4]
22:11
rubdos has quit [Ping timeout: 252 seconds]
22:19
moei has quit [Quit: Leaving...]
22:24
rubdos has joined #pypy
22:58
lritter has quit [Quit: Leaving]
23:17
xcm has quit [Remote host closed the connection]
23:18
xcm has joined #pypy
23:54
jacob22 has quit [Read error: Connection reset by peer]
23:57
jacob22 has joined #pypy