<chenglou>
sspi: wasn't there some artifacts to check in when you ran `npm start`?
<chenglou>
Iwan_: not Core because it's huge and not portable. Core_kernel, soon
<chenglou>
cannedprimates: I'm working on jengaboot. I believe jengaboot's now at CommonML's spec compliancy (minus the fact that jengaboot asks for flat src/)
<chenglou>
right now refmt doesn't align those tokens
<sspi>
chenglou: I'll check when I'm in public transport
<chenglou>
Iwan_: adding `threads` to `jengaboot.ocamlfindDependencies` didn't work I guess?
Algebr` has quit [Ping timeout: 250 seconds]
<sspi>
npm start gives some errors but that is expected - it actually gives errors already without the PR...
<sspi>
chenglou: ^
<sspi>
removing all the of's and everything works (which is what #596 does)
iwan__ has joined #reasonml
<sspi>
chenglou: ah do you mean the generates js files?
<sspi>
generated
<sspi>
chenglou: do I need to do something special to get a correct build?
<chenglou>
sspi: what does `npm start` give you?
<chenglou>
and yeah that's what you run to get the generated script
<chenglou>
otherwise, how did you get it to work?
<chenglou>
because you did get it to work, lol
<sspi>
npm start gives errors - but fix it by removing all the of's (#596) - then run npm start
<sspi>
and indeed get the generated js
<chenglou>
oh that error
<sspi>
but seems a bit too different from the current js
<sspi>
as in I'm seeing the full variable names
<chenglou>
also, if you got it running right now, can you try again with jengaboot v0.0.22
<chenglou>
full variable names is weird indeed
<sspi>
chenglou: what commit is 0.0.22?
<sspi>
or can I just take master?
<chenglou>
0.0.22 is better. I forgot what commit it was and I have no idea why I didn't tag my releases...
<iwan__>
Chenglou, If you want I can make a PR that looks for an extra "compileFlags" under "jengaboot" in package.json
<chenglou>
Iwan__: what would they be used for?
<chenglou>
sspi: yeah you're not the first to have problems with the pinning of jenga. I wonder why Iwan__ didn't have problem doing that
<iwan__>
Apparently you need the -thread flag, to user (Janestreet's) Core. This is an example.
<iwan__>
Not sure if this will be necessary when Core_kernel is accepted
copy` has quit [Quit: Connection closed for inactivity]
<chenglou>
bsansouci: ^
<chenglou>
sspi: I'll check the pinning issue again in the morning. Not sure if opam was capable of pinning a commit
<chenglou>
through if Iwan__ pinned that one then that's weird...
iwan__ has quit [Quit: Page closed]
<sspi>
chenglou: okay :-) I don't think this PR is in a hurry - I would prefer to go the extra mile once we get proper HTML support for descriptions within Atom
rgrinberg has joined #reasonml
pierpa has joined #reasonml
Algebr` has joined #reasonml
iwan__ has joined #reasonml
iwan__ has quit [Ping timeout: 250 seconds]
<bsansouci>
chenglou: not needed for core_kernel
<bsansouci>
Otherwise I'm not sure how we'd compile to JS :p
Algebr` has quit [Ping timeout: 250 seconds]
Algebr` has joined #reasonml
Algebr` has quit [Ping timeout: 250 seconds]
Algebr` has joined #reasonml
Algebr` has quit [Ping timeout: 250 seconds]
Algebr` has joined #reasonml
rgrinberg has quit [Ping timeout: 244 seconds]
copy` has joined #reasonml
Algebr` has quit [Ping timeout: 250 seconds]
rgrinberg has joined #reasonml
Algebr` has joined #reasonml
rgrinberg has quit [Quit: WeeChat 1.5]
rgrinberg has joined #reasonml
iwan__ has joined #reasonml
iwan__ has quit [Ping timeout: 250 seconds]
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
struk|desk has quit [Read error: Connection reset by peer]