<mpapis>
drbrain, samkottler: ping about cstrahan PR ^
<mpapis>
cstrahan, I also like the idea of checksums, how about md5 also?
<cstrahan>
mpapis: I could add md5, too, if we'd like.
<mpapis>
cstrahan, rvm works on md5s and sha512, so either md5 or sha512, sha256 would not help for rvm users, and it's still widely used ;)
<cstrahan>
Would it be too much to have all three?
<cstrahan>
I know we probably don't want to bloat the index, so we may have to give that some thought.
<cstrahan>
(I mean, there's little holding us back from at least getting the checksums into the DB, I think)
<mpapis>
cstrahan, I guess md5 would be enough
<cstrahan>
mpapis: k, I'll add that to the PR.
<mpapis>
cstrahan, thank you!
applerebel has quit [Ping timeout: 250 seconds]
Rennex has quit [Ping timeout: 244 seconds]
Rennex has joined #rubygems
huoxito has quit [Remote host closed the connection]
redmenace has quit [Ping timeout: 240 seconds]
<cstrahan>
when I add md5, do you suppose I should just hex-encode it? or should I use base64 encoding, as I did with sha256?
redmenace has joined #rubygems
huoxito has joined #rubygems
workmad3 has joined #rubygems
havenwood has quit [Remote host closed the connection]
havenwood has joined #rubygems
robotblake has quit [Read error: Connection reset by peer]
robotblake has joined #rubygems
tbuehlmann has quit [Remote host closed the connection]
havenwood has quit [Remote host closed the connection]
<cstrahan>
mpapis: i just added md5 :)
havenwood has joined #rubygems
havenwood has quit [Ping timeout: 264 seconds]
newUser1234 has joined #rubygems
newUser1234 has quit [Remote host closed the connection]
<mpapis>
cstrahan, I saw the message in the PR, thanks!
newUser1234 has joined #rubygems
jaimef has quit [Excess Flood]
newUser1_ has joined #rubygems
newUser1234 has quit [Ping timeout: 260 seconds]
x1337807x has joined #rubygems
x1337807x has quit [Client Quit]
jaimef has joined #rubygems
<samkottler>
mpapis: why would we add md5?
<samkottler>
mpapis: if possible I'd like to see rvm use sha-256 instead of us just adding a bunch of sha's
workmad3 has quit [Ping timeout: 245 seconds]
<mpapis>
samkottler, rvm uses md5 and sha512, if not md5 - then I would ask for sha512
<samkottler>
mpapis: is there any reason you can't add sha256 support?
<samkottler>
I don't want to support a large number of different types
<mpapis>
samkottler, most important reason is that rvm is closed for new features, and you are just adding this to rubygems
<mpapis>
samkottler, more strictly - rvm1 is closed for new code, rvm2 can add support for anything, but till then adding something that is already supported is the best way
<samkottler>
I'm not particularly inclined to add stuff specifically for RVM.
<dwradcliffe>
mpapis: how are the checksums used in rvm? I haven't used rvm in a while.
<samkottler>
Other people are then going to come out of the woodwork and ask for stuff.
<samkottler>
mpapis: also how would you consume this without changing RVM?
bbrowning is now known as bbrowning_away
<mpapis>
samkottler, last survey I have seen shows still 70% use rvm, I guess it's good enough to say rvm is still important target
<mpapis>
samkottler, rvm does not consume those directly, but anyone can validate that rvm has a proper value
<mpapis>
dwradcliffe, ^
<dwradcliffe>
how?
<mpapis>
there is a file with checksums in rvm, anyine would be able to compare them with the release notes from RG
<samkottler>
mpapis: I'm not saying RVM isn't an important target, but I'm objecting to the fact that you're claiming it wouldn't need integration.
<samkottler>
wait so you're going to store all the checksums of every gem in RVM itself?
<mpapis>
samkottler, till now all the checksums were added manually, no special integration so far for anything except the binaries we provide
<mpapis>
samkottler, and now I see my mistake, I skimmed the ticket and assume it was for rubygems not for the gems
<samkottler>
right, it's for the gems themselves
<mpapis>
samkottler, commenting on the ticket to correct it
<samkottler>
thank you
<dwradcliffe>
ah that makes more sense :)
<mpapis>
was there also work on checksums for rubygems? I thought someone mentioned it few weeks/months ago.
denym_OFF is now known as denym_
newUser1_ has quit [Remote host closed the connection]