#rubygems on 2015-11-09 — irc logs at freenode.irclog.whitequark.org

2015-11-03 19:54 imperator changed the topic of #rubygems to: RubyGems 2.5.0: http://blog.rubygems.org/2015/11/03/2.5.0-released.html - Latest status: http://twitter.com/rubygems_status and http://status.rubygems.org

00:31 huoxito has joined #rubygems

02:17 c355E3B has quit [Quit: Connection closed for inactivity]

02:48 huoxito has quit []

03:31 nateberkopec has quit [Quit: Leaving...]

03:40 UtkarshRay has quit [Remote host closed the connection]

03:53 UtkarshRay has joined #rubygems

04:05 houhoulis has joined #rubygems

05:11 UtkarshRay has quit [Remote host closed the connection]

05:14 UtkarshRay has joined #rubygems

05:31 UtkarshRay has quit [Remote host closed the connection]

05:59 UtkarshRay has joined #rubygems

06:17 houhoulis has quit [Remote host closed the connection]

08:01 adac has joined #rubygems

08:32 djbkd_ has quit [Quit: Leaving...]

08:57 jvanbaarsen has joined #rubygems

09:44 jvanbaarsen has quit [Quit: Textual IRC Client: www.textualapp.com]

10:27 Gidogeek has joined #rubygems

10:52 Gidogeek has quit [Quit: (null)]

11:13 adac has quit [Ping timeout: 250 seconds]

12:17 adac has joined #rubygems

13:08 nateberkopec has joined #rubygems

13:14 adac has quit [Ping timeout: 240 seconds]

13:26 bbrowning_away is now known as bbrowning

13:29 adac has joined #rubygems

13:29 nateberkopec has quit [Ping timeout: 260 seconds]

13:54 ckrailo has quit [Ping timeout: 264 seconds]

13:56 ckrailo has joined #rubygems

14:05 imperator has joined #rubygems

14:05 petems has quit [Ping timeout: 264 seconds]

14:07 petems has joined #rubygems

14:08 huoxito has joined #rubygems

14:08 adac has quit [Ping timeout: 246 seconds]

14:15 adac has joined #rubygems

14:24 nateberkopec has joined #rubygems

14:28 nateberkopec has quit [Ping timeout: 240 seconds]

14:31 nateberkopec has joined #rubygems

15:41 roger_rabbit has quit [Ping timeout: 255 seconds]

16:00 roger_rabbit has joined #rubygems

17:58 bbrowning is now known as bbrowning_away

18:05 djbkd has joined #rubygems

18:06 erbesharat has joined #rubygems

18:06 djbkd has quit [Remote host closed the connection]

18:07 <erbesharat> how can i set proxy for bundle ?

18:07 djbkd has joined #rubygems

18:28 bbrowning_away is now known as bbrowning

18:35 adac has quit [Ping timeout: 260 seconds]

18:49 erbesharat has quit [Quit: erbesharat]

19:00 djbkd has quit [Remote host closed the connection]

19:03 djbkd has joined #rubygems

19:19 adac has joined #rubygems

19:30 djbkd has quit [Remote host closed the connection]

19:39 djbkd has joined #rubygems

19:39 djbkd has quit [Read error: Connection reset by peer]

19:39 djbkd has joined #rubygems

19:50 <imperator> tenderlove, yo

19:50 <tenderlove> hi

19:50 djbkd has quit [Remote host closed the connection]

19:50 <tenderlove> :D

19:51 <imperator> just making sure you saw my note :)

19:51 <tenderlove> O_O

19:51 <tenderlove> note?

19:51 <tenderlove> O_____O

19:52 <imperator> https://github.com/rubygems/rubygems/commit/b73f19e5c31d02999aa1f4379bca61c0648824a2

19:52 <imperator> https://github.com/rubygems/rubygems/pull/1332

19:52 <imperator> yes, they shouldn't be nil, but sometimes they are

19:55 <tenderlove> hmmmm

19:56 <tenderlove> imperator: and there's no other fix?

19:57 <imperator> i guess i don't see the problem with that check

19:58 <imperator> do you have a different solution in mind?

19:59 <tenderlove> well, we clearly have other code that assumes they are not nil.

19:59 <tenderlove> https://github.com/rubygems/rubygems/blob/master/lib/rubygems/specification.rb#L853-L859

19:59 <tenderlove> it would be nice to know how they are being nil

20:01 <tenderlove> the source of the stubs are here https://github.com/rubygems/rubygems/blob/master/lib/rubygems/specification.rb#L747-L753

20:01 <tenderlove> and here: https://github.com/rubygems/rubygems/blob/master/lib/rubygems/specification.rb#L756-L760

20:01 <tenderlove> neither of those methods can return nil: https://github.com/rubygems/rubygems/blob/master/lib/rubygems/stub_specification.rb#L57-L63

20:03 <tenderlove> I could see a race condition between instantiating the stub, and the stubline being read

20:03 <tenderlove> but still the stub object would not be nil

20:05 <tenderlove> I will put these comments on GitHub

20:06 <imperator> alright, i guess until Peter provides a reproducable test case, we can revert it

20:24 djbkd has joined #rubygems

20:33 adac has quit [Ping timeout: 276 seconds]

20:48 adac has joined #rubygems

21:26 huoxito_ has joined #rubygems

21:29 DanKnox[away] is now known as DanKnox

21:30 huoxito has quit [Ping timeout: 244 seconds]

21:34 adac has quit [Ping timeout: 255 seconds]

21:37 DanKnox is now known as DanKnox[away]

21:42 DanKnox[away] is now known as DanKnox

22:12 bbrowning is now known as bbrowning_away

22:32 huoxito has joined #rubygems

22:35 huoxito_ has quit [Ping timeout: 240 seconds]

22:58 imperator has quit [Quit: Leaving]

23:35 djbkd has quit [Remote host closed the connection]

23:46 djbkd has joined #rubygems

23:55 djbkd has quit [Read error: Connection reset by peer]

23:55 djbkd has joined #rubygems

23:56 djbkd has quit [Remote host closed the connection]