makomo has quit [Ping timeout: 272 seconds]
_whitelogger has joined #slime
_whitelogger has joined #slime
makomo has joined #slime
scymtym has quit [Ping timeout: 245 seconds]
scymtym has joined #slime
catalinbostan has joined #slime
defaultxr has quit [Ping timeout: 245 seconds]
makomo has quit [Ping timeout: 248 seconds]
_whitelogger has joined #slime
<
luis>
hey adlai, long time no see!
<
luis>
adlai: Instead of (length "<presentation>"), try just "<presentation>" to see what's going on under the hood.
<
luis>
CL-USER> "0"
<
luis>
"#.(swank:lookup-presented-object-or-lose 18.)"
<
luis>
adlai: not sure we could/should be much smarter than this
<
luis>
ck_: I have no recollection of that issue, sorry.
Godel[m] has joined #slime
<
ck_>
okay. what do we do with those old PRs now? can anybody look into them?
<
luis>
ck_: what do you mean?
<
luis>
ck_: so, if you find one you're interested in, trying it out, reviewing it, etc, would be very helpful.
<
ck_>
naturally I vouch for its excellent usability and practical value ;) also, I wrote it on a request of a very seasoned lisper
<
ck_>
I'd just like to know what the criteria for merging these are, if any. Do you know?
<
luis>
ck_: the main criteria is time/motivation, I'm afraid.
<
luis>
ck_: anyway, #172 looks fine to me. Can you rebase it on top of the latest master and confirm it still works?
<
ck_>
will do. thanks.
<
ck_>
I did; it does.
<
ck_>
I don't see a way to update the old pull request with the new commit sha-1 (?) Do I just write a comment with the link in it?
<
ck_>
Oh, sorry, that's my fault -- I had forgotten that it's not the master branch in my fork
<
ck_>
luis: the pull request is up and current, again. Thanks for taking some time to speak to me about this.
moldybits has quit [Quit: WeeChat 2.4]
moldybits has joined #slime
makomo has joined #slime
scymtym has quit [Ping timeout: 248 seconds]
defaultxr has joined #slime