<bdilly>
because it's kind of ridiculous, right? hahahah
<dorileo>
we still have lots of people using 14.04, I agree ridiculous any way
<bdilly>
uhm... it seems semaphore is still using 14.04
<bdilly>
yeah, it doesn't makes sense
<bdilly>
at least upgrade to the newest lts version
<bdilly>
hehehe
<dorileo>
:)
<dorileo>
bdilly: I would for now just revert glima' patch
<dorileo>
I sent a test pull req to rever it but it seems semaphore will not run on that PR
<bdilly>
why not? it should build all prs
<dorileo>
dont know
<dorileo>
I included the revert on my first/original PR lets see how it goes
<dorileo>
bdilly: passed the "License, style and docs" batch
<bdilly>
great
<dorileo>
I would just assume this revert as the proper fix and think though it later on
elfgoh has joined #soletta
<dorileo>
ok, semaphore passing on my patches
<bdilly>
cool
ceolin is now known as ceolin[AWAY]
elfgoh has quit [Quit: This computer has gone to sleep]
<glima>
dorileo: you mean we're all in red state for patches WRT style?
zkis has joined #soletta
<glima>
either we drop style checks altogether or we fix the version on ubuntu there
<glima>
why just roll back the patch?
<glima>
(sorry, just saw it now)
bdilly_ has joined #soletta
bdilly has quit [Ping timeout: 260 seconds]
zkis has quit [Ping timeout: 240 seconds]
glima has quit [Remote host closed the connection]
glima has joined #soletta
glima has joined #soletta
glima has quit [Changing host]
ederson has quit [Remote host closed the connection]
_whitelogger has joined #soletta
ceolin[AWAY] is now known as ceolin
glima has quit [Ping timeout: 240 seconds]
glima has joined #soletta
glima has joined #soletta
glima has quit [Changing host]
glima has quit [Ping timeout: 240 seconds]
glima has joined #soletta
<dorileo>
glima: yep, based on what we talked early today, it seems to make more sense fix it by upgrading the uncrustify package. Will se if I get some time to do that.
<glima>
kewl
zkis has joined #soletta
caiortp has quit [Remote host closed the connection]
ceolin is now known as ceolin[AWAY]
zkis has quit [Ping timeout: 240 seconds]
<dorileo>
glima: pushed new version fixing the rebase mess, also removing the revert patch. thanks.
<glima>
dorileo: thank you, +1ed
<glima>
(this new review thing is for the whole PR, not the patch, got me)