fche changed the topic of #systemtap to: http://sourceware.org/systemtap; email systemtap@sourceware.org if answers here not timely, conversations may be logged
<agentzh> writing tests took me much longer :P
<fche> hm, not sure it should need to be a new_stat
<fche> e.g. if the array has already been analyzed with a prior op, like for stat_9.stp
<fche> println(@count(a[2]) before the foreach
<fche> hm, I see the visit_stat_op structure is similar
fche has quit [Quit: Leaving]
fche has joined #systemtap
<fche> sorry, irc malfunction
<fche> anyway upon rereading the code lgtm, thanks dude
<agentzh> good to commit?
<fche> yup
<agentzh> great, thanks
<fche> thank you!
<agentzh> sure
<agentzh> fche: yeah, i could save the new_stat for the other branch.
<agentzh> if you wish.
<fche> yeah, no big deal, it's just a little bit of stack memory, auto-freed
<fche> so it's fine as is
<agentzh> *nod*
<agentzh> fche: looking good? https://pastebin.com/wMzGkQCw
<agentzh> just made this change
<agentzh> code is shorter now.
<fche> sure.
<agentzh> great
<fche> if statistics_decl ctor could be given the stat_ops flag as a param, even shorter
<agentzh> can it?
<fche> well sure, would just change the class decl to take one (optionally)
<agentzh> ah, that's a bigger change.
<agentzh> you want me to do that?
<fche> not much, just a few more lines in session.h
<fche> up to you
<agentzh> doing now :)
<fche> - statistic_decl()
<fche> - linear_low(0), linear_high(0), linear_step(0), bit_shift(0), stat_ops(0)
<fche> + linear_low(0), linear_high(0), linear_step(0), bit_shift(0), stat_ops(_stat_ops)
<fche> : type(none),
<fche> + statistic_decl(int _stat_ops = 0)
<fche> hm wonder if sorting by variance works
<agentzh> fche: it doesn't.
<fche> ok. am sure we could make it work, but not important
<agentzh> it takes arguments though.
<agentzh> unlike the other @xxx.
<agentzh> so maybe @variance(...)+ ?
<fche> could be made to work, but probably not worth the effort.
<agentzh> i'll leave it as a TODO then.
<agentzh> the @xxx+ feature is not documented in the reference manual it seems.
<agentzh> i found them in the source code.
<fche> [man stap] covers them
<fche> under foreach
<agentzh> okay
<agentzh> thanks for the pointer.
<agentzh> committed.
<agentzh> fche: what do you think of this small bugfix patch? https://sourceware.org/ml/systemtap/2018-q3/msg00179.html
<fche> right, we came across that a few weeks ago, right?
<fche> yeah lgtm
higgins` has quit [Quit: Leaving]
<agentzh> fche: yeah. great.
<agentzh> committed.
<agentzh> thanks
higgins has joined #systemtap
orivej has quit [Ping timeout: 244 seconds]
_whitelogger has joined #systemtap
orivej has joined #systemtap
orivej has quit [Ping timeout: 252 seconds]
orivej has joined #systemtap
orivej has quit [Ping timeout: 252 seconds]
orivej has joined #systemtap
orivej has quit [Ping timeout: 272 seconds]
_whitelogger has joined #systemtap
mjw has joined #systemtap
mjw has quit [Quit: Leaving]
orivej has joined #systemtap
jhg_ has quit [Ping timeout: 252 seconds]
orivej has quit [Ping timeout: 272 seconds]
<agentzh> fche: what do you think of this x86 register patch? https://sourceware.org/ml/systemtap/2018-q3/msg00183.html
<fche> agentzh, looks good
* fche won't be able to talk live for a few days
orivej has joined #systemtap
<agentzh> fche: great. thanks
orivej has quit [Ping timeout: 272 seconds]