fche changed the topic of #systemtap to: http://sourceware.org/systemtap; email systemtap@sourceware.org if answers here not timely, conversations may be logged
CME has joined #systemtap
irker074 has quit [Quit: transmission timeout]
orivej has quit [Ping timeout: 245 seconds]
khaled has joined #systemtap
orivej has joined #systemtap
hpt has joined #systemtap
hpt has quit [Ping timeout: 246 seconds]
vbernat has quit [Quit: The future belongs to those who believe in the beauty of their dreams.]
vbernat has joined #systemtap
gromero_ has quit [Ping timeout: 252 seconds]
<agentzh> fche2: i saw you attempted an optimization in the varuse_collecting_visitor::visit_embeddedcode() method by introducing a memo map in tagged_p().
<agentzh> but it is not very helpful, just saving 17% on my side.
<agentzh> this is the inversed flame graph
<agentzh> the memo map itself still involves rbtree and string comparisons.
<agentzh> the string comparison is similarly expensive to the original string search operation.
<agentzh> my patch using dedicated boolean flags can reduce 90% of the phase 2 time.
<agentzh> and this part is almost gone from the flame graph.
<agentzh> i'm preparing a patch for submitting to the mailing list.
agentzh has quit [Ping timeout: 245 seconds]
agentzh has joined #systemtap
agentzh has joined #systemtap
agentzh has quit [Changing host]
eck has joined #systemtap
<agentzh> fche2: patch just submitted to the mailing list: https://sourceware.org/ml/systemtap/2019-q1/msg00071.html
<agentzh> it'll be great if you can have a quick look.
<agentzh> thanks