fche changed the topic of #systemtap to: http://sourceware.org/systemtap; email systemtap@sourceware.org if answers here not timely, conversations may be logged
<kerneltoast> fche, hullo
<kerneltoast> tl;dr my patch to fix that php huge page bug accidentally broke _stp_umodule_relocate() for PIE binaries
<fche> I'm afraid all the offsets and deltas and bases are too complicated for little brained me to figure
<fche> Is there a test case already in the suite that this un-regresses ?
hpt has joined #systemtap
sscox has quit [Ping timeout: 258 seconds]
<kerneltoast> am not sure
<kerneltoast> but
<kerneltoast> this just adds the old code back
<kerneltoast> and then adds what's needed to make php work
<kerneltoast> nothing more
<kerneltoast> so it's "less invasive"
<kerneltoast> fyi half of this is magic to me
<kerneltoast> i'm not 100% certain why old code works
<kerneltoast> my test scenario is a stap script that reads a global variable from a C program
irker204 has quit [Quit: transmission timeout]
orivej has joined #systemtap
fLiPr3VeRsE has quit [Ping timeout: 245 seconds]
fLiPr3VeRsE has joined #systemtap
orivej has quit [Ping timeout: 268 seconds]
sscox has joined #systemtap
khaled has joined #systemtap
orivej has joined #systemtap
orivej has quit [Ping timeout: 252 seconds]
ema has quit [Quit: leaving]
ema has joined #systemtap
fdalleau_away is now known as fdalleau
hpt has quit [Ping timeout: 268 seconds]
hpt has joined #systemtap
<fche> ok, can you show that program/script?
hpt has quit [Ping timeout: 252 seconds]
orivej has joined #systemtap
mjw has joined #systemtap
tromey has joined #systemtap
khaled has quit [Quit: Konversation terminated!]
khaled has joined #systemtap
orivej has quit [Ping timeout: 260 seconds]
orivej has joined #systemtap
mjw has quit [Quit: Leaving]
<kerneltoast> fche, this is what i've been using on centos 7: https://gist.github.com/kerneltoast/563d5f258989b456e545958644c8d811#file-test-sh
<kerneltoast> doesn't work on f33 for some reason
<fche> -fPIE defaults perhaps the cause
<fche> I -believe- serhei may have identified a preexisting test case whose regression was implicated in this patch
<fche> something re. the at_var*s?
<kerneltoast> i just googled "systemtap atvar" and got some very strange results
<fche> brave soul
<kerneltoast> fche, btw i mean my test.sh doesn't work on f33
<kerneltoast> just to be clear
<kerneltoast> but my tester works as expected on centos 7
<kerneltoast> before my patch, it gives a read fault
<kerneltoast> after my patch, it reads out 0xfc4e from the global var and prints it out
<fche> what does it do on f33 ?
<kerneltoast> just read faults always
<kerneltoast> before and after my patch
<fche> might just not be paged in
<fche> would suggest a variant of the test where some code actually accesses a, then calls another function or something else that you probe
<fche> you could also print & $a
<fche> $OFFSET egads why do such manujal things
<fche> just & $a and let stap figure it out
<kerneltoast> does it look like i know stap
<fche> well it's about time!!!
<kerneltoast> ;_;
wcohen has quit [Remote host closed the connection]
wcohen has joined #systemtap
<serhei> pong
<serhei> I listed the at_var testcases in https://sourceware.org/bugzilla/show_bug.cgi?id=27728 as it happens
<fche> serhei, and do I remember correctly that your tool associated these test cases with the previous relocation-related change that kerneltoast is about to revise?
<serhei> which commit id was that change in?
<fche> d1b554876c68f3
<serhei> interesting
<serhei> that's associated with a regression in a different set of testcases
<serhei> namely exelib.exp, usymbols.exp, sdt_global_var.exp
<serhei> + process-begin-user.exp
<serhei> ah, and also the at_var_* cases documented in the PR
* serhei can post slices of the grid view I'm looking at e.g. http://people.redhat.com/~smakarov/grid-view-at_var.html
<kerneltoast> funny we caught this on the same day
* serhei doesn't mind giving up the credit here
<serhei> we have the buildbots but the scripting for making the results easily visible testcase-by-testcase hasn't started coming together until very recently
<serhei> currently the primary product is a mondo 40MB of HTML tables that threatens to crash my firefox if I have too many copies open. Working on filtering that down a bit
<serhei> the html I posted is 'only' 440kb, still a bit big for bugzilla attachment
<serhei> I'm not sure how firefox's <table> rendering manages to translate MB's of HTML into GB's of swap space but it does ..
<serhei> anyways
<kerneltoast> probably the same way chromium translates a new tab into GB's of swap space
<serhei> chromium doesn't even try to render my entire html, just displaying the 'sad tab' after a while
<kerneltoast> serhei, speaking of testing, are the buildbots doing parallel testing yet?
<serhei> no, they're not
<kerneltoast> a lot of bugs were caught just running the stap testsuite in parallel
* serhei finds the prior instances this was discussed in my transcript
<serhei> ah, and removing superfluous testcases too. there were 64 (of a total 460) whose results don't seem to change over the time period I looked, some *may* be superfluous
<serhei> hmm, parallel testing over one testsuite run, or multiple testsuite runs in parallel?
<kerneltoast> multiple
<serhei> ah
<kerneltoast> i don't know of any bugs right now
* serhei notices GDB testsuite supports parallel testsuite execution with -j, not sure we did
<kerneltoast> i guess the low hanging fruit was fixed
<kerneltoast> but who knows what's still out there
<tromey> to make -j work for gdb, I took the Makefile bits from gcc, but also instrumented the gdb testsuite so I could use inotify to watch file creations, to find races where different tests wrote to the same files
<serhei> thanks
<serhei> hmm, attempting to run stap make installcheck with -j currently gives a ton of
<serhei> AIL: abort: TEST 7: abort() in timer.profile (more concurrency and no globals): stdout: string should be "", but got "make[3]: Entering directory '/opt/stap-checkout/stap_build/testsuite'
<serhei> so more crucial than file interference would be the makefile bits to keep testcases from seeing each other's make output in stdout
<serhei> the parallel testing method with two parallel installcheck runs would just be a matter of adding e.g.
<serhei> cd /usr/share/systemtap-testsuite && make installcheck &
<serhei> to my stap testing script
<serhei> probably with more output suppression
tromey has quit [Quit: ERC (IRC client for Emacs 27.1)]
fdalleau is now known as fdalleau_away
mjw has joined #systemtap
orivej has quit [Ping timeout: 265 seconds]