sb0 changed the topic of #m-labs to: ARTIQ, Migen, MiSoC, Mixxeo & other M-Labs projects :: fka #milkymist :: Logs http://irclog.whitequark.org/m-labs
ylamarre has quit [Quit: ylamarre]
_rht has joined #m-labs
sb0 has joined #m-labs
<GitHub178> [artiq] sbourdeauducq pushed 2 new commits to master: https://git.io/vwGNj
<GitHub178> artiq/master 89f92a6 Sebastien Bourdeauducq: RELEASE_NOTES: 1.0rc3
<GitHub178> artiq/master b00089c Sebastien Bourdeauducq: browser: simplify and fix state restore
<sb0> rjo, this fixes the "bogus folder in right column at startup" bug
<sb0> plus the "restarting the browser makes it go to the parent folder" bug
<bb-m-labs> build #355 of artiq-kc705-nist_clock is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-kc705-nist_clock/builds/355
<bb-m-labs> build #130 of artiq-win64-test is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/130
<bb-m-labs> build #616 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/616
sandeepkr_ has quit [Ping timeout: 240 seconds]
sb0 has quit [Quit: Leaving]
EvilSpirit has quit [Ping timeout: 260 seconds]
EvilSpirit has joined #m-labs
kuldeep has quit [Quit: Leaving]
kuldeep has joined #m-labs
mumptai has joined #m-labs
kuldeep_ has joined #m-labs
kuldeep has quit [Ping timeout: 244 seconds]
sandeepkr_ has joined #m-labs
sb0 has joined #m-labs
<sb0> it doesn't seem to do anything when I comment out those lines
<sb0> ah, it didn't do anything because state restore hidden the corresponding columns. it does something when starting the browser without a state file.
<sb0> why does it need to be in showEvent though, and why do we need to store the state of the header?
mumptai has quit [Remote host closed the connection]
<sb0> whitequark, i fixed the file list layout resize problem.
<sb0> it needed a setResizeMode(QtWidgets.QListView.Adjust)
EvilSpirit has quit [Ping timeout: 260 seconds]
<GitHub31> [artiq] sbourdeauducq pushed 1 new commit to master: https://git.io/vwZgH
<GitHub31> artiq/master c805102 Sebastien Bourdeauducq: browser: various fixes, handle startup path, connect activated
<bb-m-labs> build #356 of artiq-kc705-nist_clock is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-kc705-nist_clock/builds/356
<sb0> rjo, it may make sense to put the file browser as central widget, and the experiment arguments in docks
<bb-m-labs> build #131 of artiq-win64-test is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/131
<sb0> the main feature of artiq_browser is browsing files, that of artiq_dashboard is running experiments. the central widget reflects that.
<sb0> plus there isn't enough screen space for MDI windows in artiq_browser
<bb-m-labs> build #617 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/617
sb0 has quit [Quit: Leaving]
<rjo> sure there is enough space.
<rjo> artiq browser also does replay.
<rjo> for replay you need to open experiments.
<GitHub111> [artiq] jordens pushed 7 new commits to master: https://git.io/vwZKT
<GitHub111> artiq/master 1f92e03 Robert Jordens: Revert "browser: various fixes, handle startup path, connect activated"...
<GitHub111> artiq/master f09bfa2 Robert Jordens: Revert "browser: simplify and fix state restore"...
<GitHub111> artiq/master 686f670 Robert Jordens: browser: redo tree/list models
<rjo> the usability limitation will be somewhere else: to do proper replay, i also want to be able to load an experiment from hdf5 in the dashboard to be able to edit and re-submit it with the master scheduling etc.
<bb-m-labs> build #357 of artiq-kc705-nist_clock is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-kc705-nist_clock/builds/357
EvilSpirit has joined #m-labs
<bb-m-labs> build #132 of artiq-win64-test is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/132
<bb-m-labs> build #618 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/618
Gurty has quit [Excess Flood]
Gurty has joined #m-labs
<GitHub73> [artiq] jordens pushed 1 new commit to master: https://git.io/vwZP7
<GitHub73> artiq/master 3d393e4 Robert Jordens: browser: add root dir option, load only one file on restore
<GitHub59> [artiq] jordens pushed 1 new commit to master: https://git.io/vwZ14
<GitHub59> artiq/master 8567061 Robert Jordens: browser: be arrogant re changing state dump formats
<bb-m-labs> build #358 of artiq-kc705-nist_clock is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-kc705-nist_clock/builds/358
<bb-m-labs> build #133 of artiq-win64-test is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/133
<bb-m-labs> build #619 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/619
<bb-m-labs> build #359 of artiq-kc705-nist_clock is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-kc705-nist_clock/builds/359
<bb-m-labs> build #134 of artiq-win64-test is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/134
<bb-m-labs> build #620 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/620
sb0 has joined #m-labs
<sb0> rjo, my proposal is to use docks instead of mdi windows to open experiments; everything else remains the same
<rjo> what's different from dashboard?
<GitHub13> [artiq] jordens pushed 1 new commit to master: https://git.io/vwZjO
<GitHub13> artiq/master 2f24618 Robert Jordens: browser: use activated
<sb0> rjo, how about removing setRootIsDecorated(False)?
<rjo> sb0: any particular reason? for me this just wastes space.
<sb0> rjo, 1) the file explorer in the browser takes more space than the experiment explorer in the dashboard 2) the central feature is browsing results not running experiments
<sb0> rjo, yes. not having arrows/pluses for some tree elements that can be expanded is confusing
<rjo> why does 1) preclude it being a dock?
<sb0> Qt requires a central widget, it has bugs otherwise
<rjo> and the feature is "experiment browser/replay". replay is central as well.
<sb0> it's reanalyze, no?
<rjo> but it being larger than the experiment explorer does not make a reason for it not being a dock. experiment editor docks would be large as well
<rjo> sb0: "Ability to replay a past experiment, performing all experiment
<rjo> operations (build(), prepare(), run(), analyze(), GUI, plot, fitting) but
<rjo> ignoring pdb writes."
<sb0> so you want to connect to the master from the browser and everything?
<rjo> sb0: no. i would say we add the feature of loading an experiment dock from hdf5 to the dashboard. and the browser gets the reduced feature set of only running analyze (without the master-features: scheduler etc)
<sb0> yes. so, in the browser, the central feature is looking at files, thumbnails, results, and offline tweaking of analyze()/fits
<sb0> as a satellite feature
<sb0> *is
<rjo> re root decoration: i guess i can fine some that don't decorate the root. what is the root on windows anyways?
<rjo> i would try to mirror the appearance and behavior of the dashbord as much as possible. the files browser being a bit larger is not a reason to dump the mdi imho.
<sb0> the file browser is a *lot* larger
<rjo> we can also split it and have the tree on the left, the listview on the right
<bb-m-labs> build #360 of artiq-kc705-nist_clock is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-kc705-nist_clock/builds/360
<sb0> with those large icons, two columns take a lot of space
<sb0> and btw you reverted my layout bugfix ...
<rjo> is fine here.
<sb0> self.rl.setResizeMode(QtWidgets.QListView.Adjust)
<rjo> yes. i reverted all your commits. we said that i would be working on the browser. if you want to take over, let me know.
<bb-m-labs> build #135 of artiq-win64-test is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/135
<rjo> and if you feel that the files browser is large, we can just make it wider.
<bb-m-labs> build #621 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/621
<rjo> i really don't see the compelling argument to switch docks and centralwidget between browser and dashboard.
<sb0> rjo, well in this case, i fixed your layout bug: dragging the QSplitter doesn't add/remove icon columns
<rjo> ack.
<GitHub186> [artiq] jordens pushed 1 new commit to master: https://git.io/vwnUl
<GitHub186> artiq/master 89772c6 Robert Jordens: browser: resize-adjust list
<sb0> rjo, i reckon people will want >=2 columns
<sb0> so it should be the central widget, or the icons should be smaller
<rjo> ok. let's do: a) tweak minimumsize hint and icon size so that there are two columns. b) add zoom with scroll wheel.
<sb0> mh
<sb0> zoom with scroll wheel, in a file browser?
<rjo> ctrl-scroll
<rjo> this is how my file browsers behave.
<rjo> ctrl-wheel
<sb0> ok
<bb-m-labs> build #361 of artiq-kc705-nist_clock is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-kc705-nist_clock/builds/361
<bb-m-labs> build #136 of artiq-win64-test is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/136
<sb0> rjo, why do you do self.rt.header().save/restoreState()?
<bb-m-labs> build #622 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/622
<rjo> ack. can go now with only one column
<sb0> you could have read those commits...
rohitksingh has joined #m-labs
<sb0> rjo, don't you need to call close() on hdf5 files?
<sb0> they even implement the context manager protocol
<rjo> i am using it as a context manager
<rjo> sb0: let's try to avoid stomping on each others feet in the future.
<rjo> you should have checked with me.
<whitequark> sb0: pcbs and components ordered
FabM has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.2/20160407164938]]
rohitksingh has quit [Ping timeout: 250 seconds]
<rjo> sb0: defaulting to two columns for the file list is not a good idea because it breaks sequential scrolling through subsequent results with the keyboard. the arrows don't wrap, QTBUG-2302
<sb0> Created:17/Jun/08 11:54 PM
rohitksingh has joined #m-labs
sb0 has quit [Quit: Leaving]
rohitksingh1 has joined #m-labs
rohitksingh has quit [Ping timeout: 244 seconds]
rohitksingh1 has quit [Client Quit]
rohitksingh has joined #m-labs
rohitksingh has quit [Ping timeout: 260 seconds]
rohitksingh has joined #m-labs
<GitHub175> [artiq] jordens pushed 4 new commits to master: https://git.io/vwnDS
<GitHub175> artiq/master c9daa50 Robert Jordens: browser: PATH metavar
<GitHub175> artiq/master 7be3ffe Robert Jordens: scanwidget: spelling
<GitHub175> artiq/master 3578ba1 Robert Jordens: browser: zommable file icons
ylamarre has joined #m-labs
<bb-m-labs> build #362 of artiq-kc705-nist_clock is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-kc705-nist_clock/builds/362
<bb-m-labs> build #137 of artiq-win64-test is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/137
<bb-m-labs> build #623 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/623
mumptai has joined #m-labs
<bb-m-labs> build #211 of artiq-pipistrello-nist_qc1 is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-pipistrello-nist_qc1/builds/211
rohitksingh has quit [Quit: Leaving.]
mumptai has quit [Quit: Verlassend]
EvilSpirit has quit [Ping timeout: 260 seconds]
mumptai has joined #m-labs
acathla has quit [Quit: Coyote finally caught me]
acathla has joined #m-labs
_rht has quit [Quit: Connection closed for inactivity]
acathla has quit [Changing host]
acathla has joined #m-labs
mumptai has quit [Remote host closed the connection]