faustinoaq changed the topic of #amber to: Welcome to Amber Framework community! | https://amberframework.org | Developer happiness, productivity and bare metal performance | GH: https://github.com/amberframework | Docs: https://docs.amberframework.org | Gitter: https://gitter.im/amberframework/amber | IRC Logger: https://irclog.whitequark.org/amber | Amber::Server.start
<FromGitter> <eliasjpr> I really like the shards sites way much better than the “official” one
<FromGitter> <eliasjpr> I normally use shards.info
<FromGitter> <eliasjpr> But I’ll be switching over
<FromGitter> <eliasjpr> One small note I would like to make is to use the shard detail banner to place the name instead
<FromGitter> <eliasjpr> The name of the shard instead of “shards detail”
<FromGitter> <eliasjpr> @jwaldrip ^^ great work btw
<FromGitter> <jwaldrip> What if I just made the shard detail section smaller?
<FromGitter> <jwaldrip> like that?
<FromGitter> <jwaldrip> @eliasjpr
<robacarp> @jwaldrip yeah, the serializer stuff needs refinement. Json is a nice idea...but I'm not sure I know how to make crystal de/serialize with ducktyping like that
<FromGitter> <jwaldrip> What do you mean?
<robacarp> I like the right column in that screenshot, nice work.
<robacarp> like your method here works because you know what type you're expecting: https://gitlab.com/crystalshards/crystalshards/-/blob/master/src/jobs/github/project_update_queued_job.cr#L76
<FromGitter> <jwaldrip> Ya, but so do you ;-)
<FromGitter> <jwaldrip> the params macro contains the typing you need
<FromGitter> <jwaldrip> just make that map to a JSON.mapping for the runner
<robacarp> I think I see what you mean. I'd have to tinker with it but it's a good suggestion, thanks
<FromGitter> <jwaldrip> You can also loop through the types and create what you need from the initializer too.
<FromGitter> <jwaldrip> Almost all scalar classes respond to to_json/from_json
<FromGitter> <jwaldrip> then you can also get rid of the named serializers within the job itselg.
<FromGitter> <jwaldrip> Its also very easy for someone to add their own to_json/from_json methods to custom classes as well.
<robacarp> Yeah, the custom serializer thing as it currently stands is a bit of "well I have no idea what people want out of this, so I'm just going to do the least amount of work possible to let people do _anything_ and we'll see where the dust settles"
<robacarp> I know a bunch of people are using mosquito, but it's rare that I get to see what people are doing with it because so much of that code is in private repos
<FromGitter> <damianham> Hey guys, does anyone have any ideas on how I could use Cucumber with an Amber project ?
<robacarp> paulcsmith has a cucumber-like library over in the luck project, have you looked at that?
<FromGitter> <drujensen> @damianham thanks to @eliasjpr we have selenium chrome driver system testing capabilities in garnet_spec. https://github.com/amberframework/garnet-spec/blob/master/src/garnet_spec/system_test.cr
<FromGitter> <drujensen> Would be interesting to get this to work with Cucumber.
<FromGitter> <eliasjpr> I created a new library to do browser testing using Firefox which is more Filis le
<FromGitter> <eliasjpr> Reliable
<FromGitter> <Blacksmoke16> prob should just use https://www.cypress.io/
<FromGitter> <eliasjpr> See https://github.com/eliasjpr/flux
<FromGitter> <eliasjpr> Is very fast compared to selenium there is no dependencies, just simply need to have firefox installed
raz has quit [*.net *.split]
raz has joined #amber
raz has joined #amber
raz has quit [Changing host]
<FromGitter> <Blacksmoke16> im just of the view where the effort would be better suited towards something else. imagine there are a lot of nuances that need to be handled
<FromGitter> <Blacksmoke16> file uploading, mocking of requests, etc
<FromGitter> <Blacksmoke16> `Fork it (your-github-user/flux/fork)` might want to update that
<FromGitter> <eliasjpr> the library can take screenshots as well
<FromGitter> <eliasjpr> is basically a wrapper around this https://shards.info/github/watzon/marionette/
<FromGitter> <eliasjpr> @jwaldrip that looks much better
<FromGitter> <drujensen> 👍
<FromGitter> <eliasjpr> This is an example test class for a project I am working on using Flux ⏎ ⏎ ```code paste, see link``` [https://gitter.im/amberframework/amber?at=5eab4161b6dd2306979a250b]
<FromGitter> <eliasjpr> ```code paste, see link``` [https://gitter.im/amberframework/amber?at=5eab41a4347bd61630497eb3]
<FromGitter> <eliasjpr> ```code paste, see link``` [https://gitter.im/amberframework/amber?at=5eab41f6adb0ec5c2bd8ee9e]
<FromGitter> <drujensen> Not bad!
<FromGitter> <drujensen> I can read and understand it. Well done.
<FromGitter> <drujensen> I’m not a fan of crystals not_nil! syntax. Sticks out. Wish they would follow swifts syntax here.
<FromGitter> <drujensen> The closer the code reads like a book, the better. That is why I love ruby.
<FromGitter> <eliasjpr> Agreed. I guess I could use `Models::User.query.last!`
<FromGitter> <Blacksmoke16> or use `getter!` to define `last?` and `last`