faustinoaq changed the topic of #amber to: Welcome to Amber Framework community! | https://amberframework.org | Developer happiness, productivity and bare metal performance | GH: https://github.com/amberframework | Docs: https://docs.amberframework.org | Gitter: https://gitter.im/amberframework/amber | IRC Logger: https://irclog.whitequark.org/amber | Amber::Server.start
_whitelogger has joined #amber
_whitelogger has joined #amber
_whitelogger has joined #amber
<FromGitter> <damianham> @andrewc910 while I agree that a pipe based approach would allow you to set a request variable which you could then use to handle the request based on the subdomain - I imagine it would involve delegation from a primary controller to a delegate controller and that decision logic may have to be added to every method in the primary controller. I don't think that is the optimal way to handle subdomains. It might not
<FromGitter> ... be the favoured option of the core team but an extension to the router is the "correct" way to handle subdomains IMHO. Why not do a PR anyway and see if it gains favour.
<FromGitter> <eliasjpr> @andrewc910 @damianham I would like to see how subdomain works with Rails, and to better understand the use cases. I would not mind to reopen the subdomain issue and do a RFC write up to start a conversation we can compare the extension approach with the built in approach.