10:42 <kkleine> LePhilousophe, sorry for not getting back to you earlier. Weekends are reserved for family :). I haven't looked at it but will do shortly.

12:07 <LePhilousophe> no problem

13:20 <kkleine> LePhilousophe, I've seen the pullrequest_filter and I will try it now. But considering my idea on how to use buildbot try with github, this might now work as expected. For example, the filter function only allows to return True or False depending if you want to build the PR or not. But what I want is to control which builder it will be build on. To break down my idea: Consider having a C application that needs to run on x86_64

13:20 <kkleine> all the time and you have good performing machines to build each PR every time it changes. But what if you occasionally (based on a user request) build on Solaris or some other fancy architecture or OS for which you don't have a machines that can run all the time? That's what I mostly want this workflow for. To be able to have PR reviewers control on which builder they might want to try out a patch.

13:22 <kkleine> LePhilousophe, make sense?

13:23 <kkleine> I would really like to have the GitHubCommentPush working when working with buildbot try.

13:25 <kkleine> " this might now work as expected" -> "this might NOT work as expected"

13:27 <kkleine> LePhilousophe, maybe a Dynamic Build factory can help here but I doubt it. http://docs.buildbot.net/2.10.0/manual/configuration/buildfactories.html#dynamic-build-factories

15:05 <LePhilousophe> kkleine: well in this case I think you should provide to buildbot try to missing properties to make GitHubCommentPush happy

15:08 <kkleine> I have all properties set I guess. What else can I provide? buildbot try \

15:08 <kkleine> --master master:8031 \

15:08 <kkleine> --connect='pb' \

15:08 <kkleine> --username='***' \

15:08 <kkleine> --passwd='***' \

15:08 <kkleine> --vc="git" \

15:08 <kkleine> --baserev="main" \

15:08 <kkleine> --branch="main" \

15:08 <kkleine> --comment='TODO(kwk): Come up with a better comment' \

15:08 <kkleine> --who='kwk' \

15:08 <kkleine> --repository='kwk/MYREPO' \

15:08 <kkleine> --property=project='kwk/MYREPO' \

15:08 <kkleine> --property=repository='https://github.com/kwk/MYREPO.git' \

15:08 <kkleine> --diff mydiff

15:09 <kkleine> LePhilousophe, I'm thinking about implementing my own reporters.HttpStatusPush service to make the call to Github.

15:13 <kkleine> LePhilousophe, Or something similar. But essentially I can provide the buildbot try with enough properties to control the call back to github. Maybe this is enough for me http://docs.buildbot.net/current/manual/configuration/steps/http_step.html

15:23 <LePhilousophe> currently working on totally something else, but could you check with a --repository having the full URL?

15:23 <LePhilousophe> maybe it's just this

15:24 <LePhilousophe> properties project and repository are not used as properties, they are taken from the source stamp

15:24 <LePhilousophe> you can see the source stamp in Debug tab of a build, Buildset part

15:29 <LePhilousophe> or you can try to pass --project 'kwk/MYREPO'

15:31 <LePhilousophe> in fact --repository doesn't seem to be used

15:32 <kkleine> LePhilousophe, thanks for your help I will give my best.

15:32 <LePhilousophe> and try with --dryrun to make sure the properties look good

15:32 <LePhilousophe> before actually submitting the job

16:17 <kkleine> LePhilousophe, for some reason the hide_requests_headers param is unknown in my buildbot 2.10 installation from pip: https://docs.buildbot.net/current/full.html#http-requests

16:19 <kkleine> LePhilousophe, this is the error: <class 'buildbot.steps.http_oldstyle.POST'>.__init__ got unexpected keyword argument(s) ['hide_request_headers']

20:17 <LePhilousophe> kkleine: use POSTNewStyle it seems

21:47 <kkleine> LePhilousophe, phantasic. Now that I brought our daughter to bed I was able to try out POSTNewStyle and it works. Thank you.