01:54 <isuckatruby> hey all. i'm playing around with ruby/cinch with pretty much no prior development experience so forgive my ignorance. i'd like to require someone to be a channel operator to be able to issue ! commands for a couple plugins i created.

01:54 <isuckatruby> would anyone be able to help me out for a bit? i know i'm asking a lot.

01:55 <isuckatruby> i've gone through the API and found the #opped? helper, but im not sure how to implement it

02:00 <dominikh> isuckatruby: http://sprunge.us/jIMA

02:02 <isuckatruby> perfect. thank you. did you just type that example up, or is there a repository out there somewhere?

02:03 <dominikh> I typed that up

02:04 <isuckatruby> ok. thanks for the help, and for the framework. i'm using the "cinch-for-twitch" fork. it's made it pretty easy to do what i want it to do, having never touched ruby before today

02:05 <dominikh> (there's nothing special about that code, it's just normal programming)

02:05 <dominikh> there's a fork for twich?

02:05 <isuckatruby> https://github.com/cerebellum42/cinch-for-twitch

02:05 <isuckatruby> it connects, i think some of the functionality was ripped out to make it compatible (i think i remember reading some of the WHOIS checks caused it to fail)

02:06 <dominikh> yeah, that sounds about right

02:06 <dominikh> (twitch isn't technically IRC)

02:06 <isuckatruby> i know their "IRC" implementation is.... lacking

02:07 <isuckatruby> but i'm just trying to put something together for a buddy so it doesn't have to be pretty, though i'd definitely prefer if they did use IRC or implemented the whole RFC correctly

02:08 <dominikh> I've seen numerous streaming websites using "IRC" that wasn't IRC. I think that's a basic requirement internally, having a messy, broken implementation :P

02:08 <isuckatruby> lol

02:08 <dominikh> the fork doesn't look too bad. It's basically the changes I refused to add to Cinch itself

02:10 <isuckatruby> cool. i haven't run into any issues with it, and haven't noticed anything missing that i would have used, but i'm a noob so what do i know

02:11 <isuckatruby> i wouldn't really know of an easy way to diff the files to know what's changed

02:11 <dominikh> https://github.com/cinchrb/cinch/compare/master...cerebellum42:master ;)

02:12 <isuckatruby> lol, figured it was alreayd built into github :P

02:16 <isuckatruby> really not as much changed as i would have expected. pulled out autovoice, some whois checks, and some mask stuff that i'm not sure what entirely it does

02:16 <dominikh> it's really quite hacky tbh. a clean job would've removed more things and restructured others.

02:16 <dominikh> but I guess it's fine for simple twitch bots

02:25 <isuckatruby> i'm sure this is really hacky and i haven't tested it yet, but here's what i'm doing : http://pastebin.com/21v2deEV

02:25 <isuckatruby> anything i should do better to clean that up?

02:27 <dominikh> you should definitely not use #{} to call quoteadd

02:27 <dominikh> string interpolation shouldn't have side effects like that, that just makes the code harder to follow

02:28 <dominikh> id = quoteadd(quote); m.reply("...#{id}")

02:29 <dominikh> and, of course, you shouldn't use string interpolation for your SQL query… line 11 allows for SQL injection

02:29 <dominikh> that should be a prepared statement instead

02:30 <dominikh> stmt = con.prepare("INSERT INTO foo(...) VALUES(?)"); res = stmt.execute(quote); -- or whatever the specific API of that mysql gem is.

02:30 <dominikh> https://en.wikipedia.org/wiki/SQL_injection

02:31 <isuckatruby> yeah i know i'm a sql injection wet dream, i do need to fix that once i have the basic functionality working :)

02:31 <dominikh> apart from that it looks fine

02:33 <isuckatruby> http://pastebin.com/j6DnfZPE - is this better?

02:33 <isuckatruby> barring the sqli

02:34 <isuckatruby> And would that prevent a peasant from writing to the sql database, since i only have the check under def execute and not def quoteadd?

02:34 <dominikh> there's no way for a peasant to call quoteadd, other than by going through execute

02:35 <isuckatruby> so quoteadd isn't called until the execute method defines the quoteid variable?

02:35 <dominikh> until the execute method calls quoteadd, yes

02:36 <isuckatruby> ok, good to know. i should have just joined this channel 6 hours ago. ;) (not only new to ruby, but development in general)

02:37 <dominikh> do note that this channel isn't really for teaching Ruby, or programming, it tends to be for specific questions about Cinch. #ruby is a much better channel for learning Ruby. I don't mind helping out with some things, but I don't generally teach Ruby :)

02:37 <isuckatruby> well thanks a ton for the patience and advice. really appreciate it. gonna get back to it

02:37 <dominikh> enjoy