<FromGitter>
<oprypin:matrix.org> @Sija pls use mkdocstrings :o
hightower2 has quit [Ping timeout: 264 seconds]
<FromGitter>
<watzon> The thing is, writing super detailed "story" docs like Python has takes a but ton of time. But it would be amazing to see Crystal so meticulously documented.
<FromGitter>
<christopherzimmerman> @oprypin:matrix.org I'm moving my docs over to mkdocstrings now, really enjoying the project, looks great!
<FromGitter>
<christopherzimmerman> I've also been working for a while now on a way to dynamically insert the output of code into my docs (including plots), I wonder if I can do it as a plugin to mkdocs.
<FromGitter>
<watzon> I can see no reason why not. I would actually love to have a code runner plugin for running examples.
Volk has quit [Quit: See you next time!]
<FromGitter>
<watzon> Finally finished the Blake2b algo I've been working on
<FromGitter>
<watzon> Man that was a pain
<FromGitter>
<christopherzimmerman> Benchmarked it yet?
<FromGitter>
<watzon> 100000 iterations for each one
<FromGitter>
<watzon> I don't have anything to compare against though
<FromGitter>
<watzon> The ones that start with "hash` are creating a new `Blake2b` instance with each iteration, so they're a tiny bit slower, but .833 seconds to individually hash 100,000 1024 byte records ain't bad imo.
<FromGitter>
<watzon> Wait that's 10GB in less than a second isn't it?
deavmi has quit [Read error: Connection reset by peer]
<FromGitter>
<mattrberry> Sometimes benchmark results confuse me, though... I was curious how bitwise and could compare to mod in applicable cases. I added the "xxx" report after the first 3 runs. For the first 2, the "mod" and "and" reports were similar, but once I added the "xxx" report, the "and" one was always faster.... ⏎ ⏎ ``` code paste, see link``` [https://gitter.im/crystal-lang/crystal?at=6002ad66d5f4bf2965ed07fe]
<FromGitter>
<mattrberry> The "xxx" report was just for a generic modulo test to compare against, where it couldn't simply be converted to a bitwise and
hightower2 has joined #crystal-lang
_ht has joined #crystal-lang
<Andriamanitra>
i wouldn't read into miniscule differences (less than 1.5x slower).. there's always some variation
<hightower2>
oprypin, could you share in brief how to 'use mkdocstrings' ? :)
<hightower2>
Ehm, wanted to do something quick with JSON... How do I convert Array(JSON::Any) to Array(String) ? (I know that the JSON::Anys are strings)
<FromGitter>
<Blacksmoke16> or `data.as_a.map &.as_s`
<FromGitter>
<Blacksmoke16> `.from_json`*
<hightower2>
yes I think I can't use .from_json since it's already JSON::Any, isn't serialized
<hightower2>
gonna try with the map thing
<hightower2>
worked, thanks!
postmodern has quit [Quit: Leaving]
<FromGitter>
<Blacksmoke16> yea would have to be the raw data, but that was assuming you're doing a json.parse first as well
<FromGitter>
<Blacksmoke16> like easier to go from data to string array than data json::any string array
<FromGitter>
<HertzDevil> what's the suggested practice for submitting a pr that depends on another pr
<FromGitter>
<HertzDevil> (of my own)
<oprypin>
HertzDevil, lie on the floor and cry
<FromGitter>
<Blacksmoke16> prob make the first pr into master then create the 2nd pr to the branch of the first pr
<oprypin>
more realistically, just include the exact same commits and more and then add a big text at the start of the description
<FromGitter>
<Blacksmoke16> then when the first one is merged github will auto change base to master
<FromGitter>
<HertzDevil> hmm
<FromGitter>
<Blacksmoke16> where the 2nd pr is a draft
<oprypin>
Blacksmoke16, what you're describing would be a pull request to hertzdevil's repo. not possible like that
<FromGitter>
<Blacksmoke16> hmm fair point, not sure what gh would do in that case
<oprypin>
>a pull request to hertzdevil's repo
<yxhuvud>
I'd simply submit it as a pull request with the target pr as the base you pr into.
<oprypin>
not possible
<yxhuvud>
sure it is. Submit both, then hit edit and choose what branch you want to merge to
<oprypin>
what branch of crystal-lang/crystal repo
<yxhuvud>
ah, hmm.
<FromGitter>
<Blacksmoke16> if pr 1 was made fork branch1 to crystal master, and fork branch2 was made into fork branch1, is gh smart enough to update base to crystal master as well?
<oprypin>
first of all, i've never heard of it updating anything, so i dont know
<oprypin>
2nd of all, i dont think it would move a pull request to hertzdevil's repo to become a pull request to crystal-lang's repo
<yxhuvud>
it definitely updates if both branches are local to the same repo.
<FromGitter>
<jrei:matrix.org> I remember my conversation with oprypin (https://matrix.to/#/@oprypin:matrix.org) when the 1.0 release will come :)
<FromGitter>
<jrei:matrix.org> I was planning end of 2020 - at the end, we were both wrong
<FromGitter>
<asterite> @HertzDevil I left a comment on your commit. I think we can go with your next PR if we check that the method definition matches exactly the one in the std
<FromGitter>
<watzon> I understand now, thanks @oprypin:matrix.org
<FromGitter>
<watzon> I agree that it would be nice to have another release asap rather than waiting for 1.0.0