14:37 <FromGitter> <Dan-Do> > https://play.crystal-lang.org/#/r/b6vj ⏎ ⏎ @naqvis Can you help me out with this? ⏎ ⏎ ```code paste, see link``` [https://gitter.im/crystal-lang/crystal?at=60a91740688a2624b8a6537b]

14:38 <FromGitter> <Dan-Do> I dont want to declare `setter my_proc : Proc(String, JSON::Any, Hash(String, String))`

14:38 <FromGitter> <Dan-Do> the error is ⏎ ⏎ ```code paste, see link``` [https://gitter.im/crystal-lang/crystal?at=60a91780bdecf719a0726174]

14:41 <FromGitter> <Dan-Do> Your code is ⏎ ⏎ ```@my_data = @my_proc.call(layout, JSON.parse(data))``` [https://gitter.im/crystal-lang/crystal?at=60a91813fec22b4786d4c704]

14:42 <FromGitter> <Dan-Do> Isn't the same?

14:44 <FromGitter> <Blacksmoke16> the key is line 31 in that playground link. I.e. converting the hash to a `String` before passing it to render

14:46 <FromGitter> <Dan-Do> oops, my bad :D

14:46 <FromGitter> <Dan-Do> changed it to `@my_data = transform.call(layout, data.to_json)`

14:47 <FromGitter> <Dan-Do> now error is `Error: no overload matches 'Proc(String, JSON::Any, Hash(String, String))#call' with types String, String`

14:47 <FromGitter> <Dan-Do> https://play.crystal-lang.org/#/r/b6zs

14:49 <FromGitter> <Blacksmoke16> now you dont have the `JSON.parse`

14:51 <FromGitter> <Dan-Do> ```code paste, see link``` [https://gitter.im/crystal-lang/crystal?at=60a91a863d43a15a65bd1c24]

14:52 <FromGitter> <Dan-Do> isn't it?

14:53 <FromGitter> <Dan-Do> uhm, no `Error: no overload matches 'JSON.parse' with type JSON::Any`

14:58 <FromGitter> <Blacksmoke16> you didnt have it in line 12 of that link

14:59 <FromGitter> <Blacksmoke16> i.e. when you go to call the proc

15:09 <FromGitter> <Dan-Do> got it, now changed to ⏎ ⏎ ```@my_data = transform.call(layout, JSON.parse(data.to_json))``` [https://gitter.im/crystal-lang/crystal?at=60a91eae0ff6de262b21e128]

15:09 <FromGitter> <Dan-Do> weird, huh :D

15:40 <FromGitter> <naqvis> @Dan-Do please give some love to type annotations, they are going to help you in long run and identify problems at the right spot. ⏎ `def render(layout, data)` Your current method signature doesn't reveal, what is this method expecting to work properly ⏎ ⏎ imagine what would happen when someone call it `foo.render(1, "fooo")` ? [https://gitter.im/crystal-lang/crystal?at=60a925fd0ff6de262b21f364]

15:41 <FromGitter> <naqvis> compiler will yell at you stating that block parameter can't be executed, but that isn't the fault of the block

15:42 <FromGitter> <naqvis> type annotating signature to`def render(layout : String, data : Hash)` will complain at the right location, where problem is happening

15:43 <FromGitter> <naqvis> another point i would like to make is `if var` construct is used if you are working with optional types (types who might be nil)

15:43 <FromGitter> <naqvis> block parameter is never going to be nil (as per the signature), so you needn't to use such construct there

15:43 <FromGitter> <naqvis> just few random thoughts 😄

15:47 <FromGitter> <Dan-Do> yeah, I appreciate that ❤️

15:47 <FromGitter> <naqvis> 👍

19:23 <FromGitter> <lebogan> Please, let me know if this is the right place for my issue. I was using kemal-flash which relied on json.mapping which broke in 0.36.0. Not sure how to fix. Anyone know of a replacement shard for neovintage/kemal-flash? Or maybe steer me to how to fix? Thanks.

19:25 <jhass> JSON.mapping was extracted to https://github.com/crystal-lang/json_mapping.cr

20:05 <FromGitter> <Blacksmoke16> Or ofc update it to use json serializable

20:13 <FromGitter> <lebogan> @Blacksmoke16 , @jhass thank both of you for the quick response. After some struggling, I managed to update to json serialize. I'm notifying the shard maintainer.

21:46 <postmodern> is there a short-hand like enum_for, for calling a method that yields args, and appending them to an Array?

21:47 <FromGitter> <Blacksmoke16> Hm?

21:49 <postmodern> if you have method A which yields data, and you want to write an overloaded version of method A that returns an Array of that data, is there a macro for that?

21:56 <postmodern> i'm assuming i have to write that code which initializes an Array, calls the method with a block, and appends the yielded args to the array, then return the array

21:57 <FromGitter> <Blacksmoke16> yea theres not a macro to do that for you