dkubb changed the topic of #datamapper to: Datamapper v1.2.0 | Mailing List: http://is.gd/aa9D | Logs: http://is.gd/qWAL7V | DataMapper 2 Renamed to ROM, see #rom-rb for development
rsim has quit [Quit: Leaving.]
lgierth_ has joined #datamapper
lgierth has quit [Ping timeout: 240 seconds]
lgierth_ has quit [Quit: Ex-Chat]
rsim has joined #datamapper
mkristian has joined #datamapper
mikecmpbll has joined #datamapper
GB_ has joined #datamapper
GB_ is now known as Guest84163
Guest84163 has left #datamapper [#datamapper]
mbj has joined #datamapper
Ptico has joined #datamapper
<mbj>
ptico: hey man
<Ptico>
mbj: hi
<mbj>
Has been a *long* while till this channel was active.
<Ptico>
:)
<mbj>
We had tons of hi quality coding discussions here.
<mbj>
*high
<mbj>
ptico: feel free to shoot your questions.
<Ptico>
So, i want to make some benchmarks and may be add small optimisations for few methods
<mbj>
ptico: I think thats fine. We should have 100% mutation coverage before doing any optimizations.
<mbj>
This will make sure that the public interface is unaltered during optimization.
<Ptico>
For example in .ordinalize we can cache values from 4 to 16 in Set[] to avoid computations
<Ptico>
Its almost done, only .ordinalize and .uncountable? have few mutants
<Ptico>
btw, why didn't make .uncountable? public? It may be useful sometimes
<mbj>
ptico: I did not design this interface at all.
<mbj>
ptico: I took what was in extlib and factored out a gem with 1:1 API.
<mbj>
Without giving it too much thought.
<mbj>
We needed an inflector for DM2 AKA ROM.
<mbj>
ptico: Are you interested in taking over this gem?
<mbj>
I do not have a primary use case, and I'm not a native speaker.
<Ptico>
me too)
<mbj>
heh
<mbj>
So I think yes, .uncountable? does not need to be a public interface.
<mbj>
Feel free to PR it away.
<mbj>
Next PRs will be easier since the foundations got cleaned up.
<mbj>
ptico: After merging the PR I can take care on that rubocop side of things.
<Ptico>
Ok, i'll kill the rest of mutations
<mbj>
ptico: If you want to target the rubocop stuff by yourself copy the config/rubocop.yml from mutant and fix all the reports.
<mbj>
This is basically what I plan to do.
<Ptico>
I can try this a little bit later
Ptico has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
skade has joined #datamapper
Ptico has joined #datamapper
Ptico has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
Ptico has joined #datamapper
lgierth has joined #datamapper
Ptico has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
skade has quit [Quit: Computer has gone to sleep.]
mikecmpbll has quit [Ping timeout: 255 seconds]
lgierth has quit [Quit: Ex-Chat]
Ptico has joined #datamapper
<Ptico>
@mbj i have some places, where performance of the method increases ~1.5x, but memory usage is also ~1.5x bigger, what is more preffered?
mkristian has quit [Quit: bye]
mikecmpbll has joined #datamapper
mbj has quit [Quit: leaving]
_whitelogger has joined #datamapper
ptico has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
mikecmpbll has quit [Quit: i've nodded off.]
mikecmpbll has joined #datamapper
skade has joined #datamapper
rsim has quit [Quit: Leaving.]
rsim has joined #datamapper
skade has quit [Quit: Computer has gone to sleep.]