<mntmn>
(i'm currently testing how stable my first patch is before publishing a draft)
<austriancoder>
mntmn: please run deqp without and with your patch
<mntmn>
ok
<lynxeye>
mntmn: this only helps when you force-disable early_z, right? I think we are still missing the code to disable early_z when a shader uses discard.
<mntmn>
lynxeye: correct. as far as i understand there is a uses_discard flag in nir structures that can be used for this, but i'm not sure where the right place for that is (in etnaviv_zsa.c? emit?)
<lynxeye>
mntmn: this needs to be a derived state, as we only know at draw time if the zsa state potentially allows using early-z and the currently bound fragment shader doesn't change the fragment depth
<lynxeye>
so really one of two options: a) do it directly in emit, if the logic is simple enough, or b) add a new function to derive the state to etna_state_updates[]
<mntmn>
ok, thanks!
pcercuei has quit [Quit: brb]
pcercuei has joined #etnaviv
pcercuei has quit [Client Quit]
nathanhi- is now known as nathanhi
lynxeye has quit [Quit: lynxeye]
pcercuei has joined #etnaviv
tlwoerner has quit [Quit: Leaving]
berton has quit [Remote host closed the connection]