00:09 <_whitenotifier-f> [glasgow] attie commented on pull request #225: applet.video.ws2818_output: add support for LEDs other than RGB - https://git.io/JTp2S

00:19 <_whitenotifier-f> [glasgow] Error. The Travis CI build could not complete due to an error - https://travis-ci.org/github/GlasgowEmbedded/glasgow/builds/741763883?utm_source=github_status&utm_medium=notification

01:01 <_whitenotifier-f> [glasgow] whitequark closed pull request #224: applet.video.ws2818_output: convert to nmigen - https://git.io/JTAPx

01:01 <_whitenotifier-f> [glasgow] whitequark commented on pull request #224: applet.video.ws2818_output: convert to nmigen - https://git.io/JTpwH

01:01 <_whitenotifier-f> [GlasgowEmbedded/glasgow] whitequark pushed 1 commit to master [+0/-0/±1] https://git.io/JTpwQ

01:01 <_whitenotifier-f> [GlasgowEmbedded/glasgow] attie-argentum 070d9ef - applet.video.ws2818_output: convert to nmigen

01:33 <_whitenotifier-f> [glasgow] Success. The Travis CI build passed - https://travis-ci.org/github/GlasgowEmbedded/glasgow/builds/741775052?utm_source=github_status&utm_medium=notification

01:45 <marcan> Attie: your approach looks sane and simple to me

01:46 <marcan> Attie: but don't you need to separate pix_bytes from pix_bpp?

01:47 <marcan> 'RGBx': ( 4, lambda r,g,b,x: Cat(Const(0, unsigned(8)),b,r,g) ),

01:47 <marcan> that should be pix_bytes = 3, pix_bpp = 32 right?

01:47 <marcan> since there are 8 bits of padding

01:47 <marcan> so rgb in, grb0 out

01:51 <d1b2> <Attie> maybe... an "in size" and "out size" might be a good idea, but I simplified (for now)

01:52 <d1b2> <Attie> e.g: I expected people with RGBW LEDs to feed in RGBA pixels, and then mask off the A to show "color" and avoid white-washing everything due to the alpha component

01:52 <d1b2> <Attie> if you only have RGB LEDs, then just feed in RGB

01:52 <marcan> well, W != A

01:52 <d1b2> <Attie> and if you actually want control kf the white LED, then pick RGBW

01:53 <marcan> you need a specific color transform to properly take advantage of RGBW LEDs

01:53 <d1b2> <Attie> yeah, hence masking it to zero

01:53 <marcan> yeah, but then you're just wasting USB bandwidth and requiring people to use RGBA

01:53 <marcan> it makes much more sense to take in RGB in that case

01:54 <d1b2> <Attie> I agree, but then we end up with an "input pixel format" and an "output pixel format", and that increases complexity

01:54 <d1b2> <Attie> e.g: RGB in, RGBW out... vs. RGB in RGB out

01:56 <d1b2> <Attie> I need to go to sleep now, but happy to continue discussing tomorrow

01:56 <d1b2> <Attie> I'm not against doing it more properly

01:56 <marcan> it's just passing in "in width" vs "out width" separately

01:57 <marcan> RGBx means RGB in, RGBW out; RGB means RGB in, RGB out

01:57 <marcan> just change the tuple to (3, 4, lambda..)

01:57 <marcan> pix_bytes_in, pix_bytes_out, func

01:57 <marcan> and calculate pix_bpp from pix_bytes_out

01:59 <d1b2> <Attie> yeah, true... okay. I'll look at that tomorrow

01:59 <d1b2> <Attie> nn :)

01:59 <marcan> nn!

12:21 <_whitenotifier-f> [glasgow] attie synchronize pull request #225: applet.video.ws2818_output: add support for LEDs other than RGB - https://git.io/JTpzp

12:22 <d1b2> <Attie> @marcan / @whitequark I've added support for different input/output pixel sizes

12:22 <d1b2> <Attie> happy to squish into one commit if you'd prefer

12:22 <_whitenotifier-f> [glasgow] attie synchronize pull request #225: applet.video.ws2818_output: add support for LEDs other than RGB - https://git.io/JTpzp

12:34 <_whitenotifier-f> [glasgow] attie synchronize pull request #225: applet.video.ws2818_output: add support for LEDs other than RGB - https://git.io/JTpzp

12:39 <_whitenotifier-f> [glasgow] Failure. The Travis CI build failed - https://travis-ci.org/github/GlasgowEmbedded/glasgow/builds/741865467?utm_source=github_status&utm_medium=notification

12:51 <_whitenotifier-f> [glasgow] Success. The Travis CI build passed - https://travis-ci.org/github/GlasgowEmbedded/glasgow/builds/741867278?utm_source=github_status&utm_medium=notification

14:29 <whitequark> since i know some people in this channel have previously experienced issues with pip: the pip developers would like to hear about those. check out https://www.ei8fdb.org/thoughts/2020/03/pip-ux-study-recruitment/

14:30 <whitequark> Attie: fyi: will be a while (week or so maybe) until I get to review that, I have heaps of work to do to prepare nmigen for release

14:34 <d1b2> <Attie> no problem, thanks for the heads up!