<lopex> jeremyevans: no idea, wrt jdbc there must have been some JI changes then
<jeremyevans> lopex: gotta run now, but I'll monitor the backlog when I return
<lopex> actually what is native exception and since where it might have been thrown
<lopex> jeremyevans: except that warning I see no other issues wrt sequel
<lopex> on 9.2
Puffball has quit [Quit: Puffball]
xardion has quit [Ping timeout: 264 seconds]
xardion has joined #jruby
Puffball has joined #jruby
<havenwood> congrats on 9.2!
Puffball has quit [Quit: Puffball]
rdubya has quit [Ping timeout: 245 seconds]
bga57 has quit [Ping timeout: 245 seconds]
bga57 has joined #jruby
rdubya has joined #jruby
rdubya has quit [Ping timeout: 260 seconds]
kares has quit [Ping timeout: 256 seconds]
kares has joined #jruby
rdubya has joined #jruby
<GitHub163> [jruby] monkstone opened issue #5192: jgem fails to load gem from rubygems on Raspbian https://git.io/vhLEO
<kares> jeremyevans: NativeException is really ancient and you should just rescue the Java type
<kares> now with JDBC usually rescue java.sql.SQLException will do
<kares> although to be more on the safe side you might want to rescue java.lang.Exception since some drivers won't wrap into a SQLException -> should be close to NativeException
<kares> this is expected to work in JRuby 1.7 as well
<kares> headius: looking into those Date issues/regressions
olle has joined #jruby
<GitHub55> [jruby] kares pushed 1 new commit to master: https://git.io/vhL2g
<GitHub55> jruby/master 48b4291 kares: [fix] Date civil impl (jd calc) should not adjust year (due joda)...
<GitHub12> [jruby] kares closed issue #5191: 9.2.0.0 Regression in DateTime.parse for BC dates https://git.io/vhLU9
claudiuinberlin has joined #jruby
<travis-ci> jruby/jruby (master:48b4291 by kares): The build was fixed. (https://travis-ci.org/jruby/jruby/builds/383564121)
<GitHub193> [jruby] kares pushed 1 new commit to master: https://git.io/vhLob
<GitHub193> jruby/master 3a140ab kares: [fix] Date (internal) constructor - proper off, keep start at ITALY...
<GitHub91> [jruby] kares closed issue #5188: Invalid Date exception when marshaling a Date - 9.2.0.0 https://git.io/vhIiv
shellac has joined #jruby
<olle> @kares are these left in because of MRI test suite compat, or something? https://github.com/jruby/jruby/blob/master/test/jruby/test_date.rb#L819-L823
<olle> "visual compatibility" for the reader, I mean
olle has quit [Quit: olle]
drbobbeaty has quit [Quit: Textual IRC Client: www.textualapp.com]
drbobbeaty has joined #jruby
<GitHub89> [jruby] original-brownbear opened issue #5193: JRUBY 9.2.0.0: Assertion Failure when Reporting RSpec Failure https://git.io/vhLSd
<kares> olle: yeah its ugly-sh
<kares> they're left in since its not a complete port - from AS, those parts are different than in AS (weren't relevant to test what was needed)
<kares> also its jruby's private tests - less worries there
olle has joined #jruby
<GitHub91> [jruby] monkstone opened issue #5194: jirb failing on raspbian https://git.io/vhLdt
olle has quit [Quit: olle]
olle has joined #jruby
shellac has quit [Quit: Computer has gone to sleep.]
<GitHub166> [jruby] kares pushed 2 new commits to master: https://git.io/vhLpO
<GitHub166> jruby/master 1a7a482 kares: [bench] sample benchmark for RubyString implements CharSequence...
<GitHub166> jruby/master f0450cb kares: [build] compile bench module using Java 8 as well
shellac has joined #jruby
<GitHub111> [jruby] kares pushed 1 new commit to master: https://git.io/vhtUF
<GitHub111> jruby/master 7810ba0 kares: [bench] adjust the benchmarking code to be more meaningful...
cpuguy83 has joined #jruby
<cpuguy83> Hey, working on getting the 9.2.0.0 Docker image going. Tests are failing on testing some stdlib stuff.
<cpuguy83> I guess `mathn` has been removed (not sure how the MRI ruby:2.5 image passed this test), but then there's things like `net/telnet` which seems to require a gem now for jruby.
<cpuguy83> @headius ^
bbrowning is now known as bbrowning_away
<GitHub108> [jruby] enebo pushed 1 new commit to master: https://git.io/vhtmg
<GitHub108> jruby/master 3c97f06 Thomas E. Enebo: Remove bogus assertion. valueNode == null is valid.
<GitHub88> [jruby] enebo closed issue #5193: JRUBY 9.2.0.0: Assertion Failure when Reporting RSpec Failure https://git.io/vhLSd
olle has quit [Quit: olle]
claudiuinberlin has quit [Quit: Textual IRC Client: www.textualapp.com]
<GitHub84> [jruby] jeremyevans opened issue #5195: 9.2.0.0 regression in Date#to_time for BC dates resulting in Time off by 1 year https://git.io/vhtCK
xardion has quit [Remote host closed the connection]
xardion has joined #jruby
ahorek has joined #jruby
ahorek has quit [Client Quit]
shellac has quit [Quit: Computer has gone to sleep.]
cpuguy83 has quit [Remote host closed the connection]
hoodow has joined #jruby
Puffball has joined #jruby
cpuguy83 has joined #jruby
cpuguy83 has quit [Remote host closed the connection]
<headius> jeremyevans: NativeException should never be thrown, and should have been that way for several releases
<headius> 9.2 just ironed out a few edge places where it might get thrown
<headius> kares: thank you!
<jeremyevans> headius: Thanks. I ended up with the following commit to Sequel which appears to work in JRuby 1.7+: https://github.com/jeremyevans/sequel/commit/b4fab95b60b7f428ec4d0edfe3d2741d07e1ca28
<GitHub24> [jruby] headius closed issue #5194: jirb failing on raspbian https://git.io/vhLdt
cpuguy83 has joined #jruby
<nirvdrum> Congrats on the release!
shellac has joined #jruby
rdubya has quit [Ping timeout: 245 seconds]
<headius> nirvdrum: thanks
<headius> jeremyevans: rescue Exception (the Ruby one) will also pick up Java exceptions
<headius> but obviously it will also pick up all Ruby exceptions, which you may not want
<jeremyevans> headius: I definitely don't want that :)
<headius> fwiw we killed NativeException some time in 1.7 or maybe earlier
<headius> if you ever see one let me know because it's a bug
<cpuguy83> Curious what's happened to net/telnet, xmlrpc/* and rake in the stdlib in 9.2
<jeremyevans> headius: I would prefer to only rescue java.sql.SQLException, but some JDBC drivers raise exception instances not subclassed from that
<headius> cpuguy83: they should be preinstalled gems
<headius> did they not make it into dist?
<jeremyevans> headius: I've been supporting JRuby on Sequel since well before 1.7 (since mid-2008 I think) :)
<headius> headius: oh sure I know
<headius> cpuguy83: bugger...I don't see them
<headius> enebo: oops
<cpuguy83> Phew, thought I missed something.
<headius> cpuguy83: well fwiw those libs that are missing actually are just preinstalled gems now in 2.5
<headius> so just install them I guess
<enebo> heh
<enebo> bugger
<enebo> is right
rdubya has joined #jruby
<headius> enebo: you didn't run your xmlrpc verification for the release bro
<enebo> what is that?
<enebo> :)
<enebo> so I guess in one sense I am happy some of these things are actually potentially removable some day
<enebo> the fact it is solvable by a gem install is nice too
<enebo> does stdlib have soap in it?
<enebo> I do remember wsdl being in it
<enebo> or did I dream that
<headius> enebo: we must have something in dist logic to pull in gems because jruby-openssl, jruby-launcher, rake are in there
<headius> I'm looking at the rvm install
<headius> I think they nuked the soap/wsdl lib a while back
<enebo> yeah I believe we have a list somewhere default.build.properties?
<headius> build's too darn complicated
rdubya has quit [Ping timeout: 245 seconds]
shellac has quit [Quit: Computer has gone to sleep.]
<headius> cpuguy83: if installing the necessary gems doesn't work do let us know
<cpuguy83> Yeah, it seems to be ok.
<cpuguy83> Assuming `net/telnet` is supposed to be provided by `net-telnet`, and xmlrpc provided by `xmlrpc`... and not some other gem.
<headius> it looks like they really are just gems in 2.5
<headius> $ bundle exec ruby -v -e 'require "net/telnet"'
<headius> ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]
<headius> Traceback (most recent call last):
<headius> 1: from -e:1:in `<main>'
<headius> -e:1:in `require': cannot load such file -- net/telnet (LoadError)
<headius> oops
<headius> well there it is though...that's with an empty bundle
<enebo> haha
<headius> so folks would have to put them in there anyway
<enebo> headius: so 2.5.1 does not ship them either then?
<headius> it ships them but they're gems
<headius> just plain gems
<headius> so installing as plain gems on JRuby after the fact is not really different
<headius> it's just a minor annoyance that they're not in the dist
<enebo> ok good to know
<enebo> very minor for most people but cpuguy83
<headius> I don't know how they get into dist though
<headius> I will ping mkristian
<enebo> At least I assume net/telnet is not super common
<enebo> headius: may be in top pom.rb?
<headius> cpuguy83: can you file a bug so others will see it
<headius> plus we can track fixing
<headius> enebo: I have not found a list
<cpuguy83> Yeah
<enebo> gzipped
<GitHub63> [jruby] cpuguy83 opened issue #5196: [9.2.0.0] Missing gems in dist https://git.io/vht7t
shellac has joined #jruby
shellac has quit [Quit: Computer has gone to sleep.]
<headius> enebo: I'm open for ideas on this dedup thing
rdubya has joined #jruby
<headius> MRI is just using their st hash, which allows you to specify functions for hash and cmp on a per-instance basis
<headius> JDK collectionclasses are not set up like that
<headius> krackenwagon
<headius> I don't want to hack a special ConcurrentHashMap
cpuguy83 has quit [Remote host closed the connection]
rdubya has quit [Ping timeout: 260 seconds]
shellac has joined #jruby
shellac has quit [Client Quit]
<GitHub11> [jruby] pcarlisle opened issue #5197: GZipFile#close does not return IO object as MRI does https://git.io/vhtdT
<GitHub134> [jruby] headius pushed 2 new commits to master: https://git.io/vhtFt
<GitHub134> jruby/master e873dd5 Charles Oliver Nutter: Return the IO associated with the gzip file on close. Fixes #5197
<GitHub134> jruby/master caa392b Charles Oliver Nutter: Clean up RubyString.op_equals.
<GitHub150> [jruby] headius closed issue #5197: GZipFile#close does not return IO object as MRI does https://git.io/vhtdT
xardion has quit [Ping timeout: 256 seconds]
xardion has joined #jruby
xardion has quit [Ping timeout: 245 seconds]
xardion has joined #jruby