<enebo>
zillions in native extensions if they work on bytelists too...although that may not be a ton
<enebo>
tno of extensions but the ones which do probably call it a lot
<enebo>
headius: although generally unless it is utf-16le or something like that it will still work
<enebo>
not perfect but a lurking killer
<headius>
well this was hit #2 out of 189
<headius>
to be fair this code would be broken under utf16 even if it were using byte length since it probably should be checking the first *character*
<enebo>
yeah
<enebo>
be would work though :P
<enebo>
16-be that is
<enebo>
paths are difficult in our codebase because they need to end up as String/Charset and behave
<enebo>
so generally by the time we do stuff like this we usually are working with utf-8 or ascii
<enebo>
although fuzzing ruby string data for paths would probably uncover some interesting bugs
<headius>
well with bytelist folding back into JRuby I'm contemplating just rolling back that patch
<headius>
the library is dead if we want to work properly in 9 and this change was never released anywhere
<enebo>
yeah makes sense to me. I suspect nokogiri may be a consumer of bytelist and might use length
<enebo>
funny though we almost always use realSize internally
<headius>
yeah I have for a long time
<headius>
these could all be audited but that won't help exts
<headius>
there's a path forward though, since realSize() is there...all current uses of length() in exts would likely be .realSize()
<enebo>
yeah assuming there are any length usages. I assume so since it is the more obvious choice without knowing the difference
<headius>
well things look fine with that commit reverted
sgeorge_ has quit [Remote host closed the connection]
shellac has joined #jruby
sgeorge has joined #jruby
shellac has quit [Ping timeout: 250 seconds]
shellac has joined #jruby
shellac has quit [Quit: Computer has gone to sleep.]
shellac has joined #jruby
rosenjcb has joined #jruby
<rosenjcb>
I have this annoying error I keep getting when I run jruby -S gem install jbundle:
<rosenjcb>
It seems your ruby installation is missing psych (for YAML output).
<rosenjcb>
LoadError: load error: psych -- java.lang.NoClassDefFoundError: Could not initialize class org.jruby.ext.psych.PsychEmitter
<rosenjcb>
To eliminate this warning, please install libyaml and reinstall your ruby.
<rosenjcb>
I have libyaml-dev installed and I reinstalled both ruby and jruby
<headius>
hmmm
<rosenjcb>
I think it's a local issue and not a bug necessarily because it runs fine on my personal computer
<headius>
well that almost certainly is due to the JRuby version and a Psych version conflicting
<headius>
we don't use libyaml
<headius>
the libyaml warning should probably be fixed in Psych since it doesn't apply to JRuby
<rosenjcb>
That would make sense.
<headius>
how did you install JRuby initially?
<rosenjcb>
I think it was automatically installed
<rosenjcb>
But I uninstalled it and reinstalled it
<rosenjcb>
Maybe I didn't completely uninstall it?
<rosenjcb>
So I think maybe my jruby is an older version
<rosenjcb>
I'm running 9.1.13.0
<rosenjcb>
ruby itself is 2.5.1p57
<rosenjcb>
When I type which jruby I get /usr/bin/jruby but I cannot find the directory
shellac has quit [Ping timeout: 240 seconds]
<rosenjcb>
headius, I tried installing via rebenv but I'm not getting anywhere with it.
<havenwood>
rosenjcb: After setting `rbenv local jruby`, and running `rbenv rehash`, what do you get for?: which jruby
<headius>
rosenjcb: automatically installed by your host OS? I'm confused
<headius>
rbenv should also work but it's a different process obviously
<headius>
if you installed (or had installed for you) JRuby from a Linux package (Fedora or Ubuntu or something) it could mean there's something wrong with that package