ur5us has quit [Ping timeout: 240 seconds]
<fzakaria[m]> yea; i'll try writing some Thread.new and see
<headius[m]> Even with threads I would expect to see that method get defined before the constant is set, since that file should initially run through from top to bottom
ur5us has joined #jruby
<fzakaria[m]> I put some time in trying to fix this bundler + warbler issue: https://github.com/rubygems/rubygems/issues/3177
<fzakaria[m]> it's very tricky the bundler source
<fzakaria[m]> (has a very simple repro)
<fzakaria[m]> I broke out a bunch of code into separate ruby-gems within the same repository.
<fzakaria[m]> (code isolation!)
<fzakaria[m]> Unfortunately using `:path` doesn't play nice with Warbler
<fzakaria[m]> I couldn't find much on Google about others doing a similar approach: monorepo + multiple gems.
ur5us has quit [Ping timeout: 256 seconds]
ur5us has joined #jruby
ur5us has quit [Ping timeout: 256 seconds]
<headius[m]> Hmm
<byteit101[m]> headius: about to go to bed now, but that bug 6140 I found while implementing java_signature method generation for extended java classes. Want to talk about that tomorrow, though I have a working POC now
<headius[m]> ok sure
<headius[m]> I'll be around
_whitelogger has joined #jruby
klobuczek[m]1 has joined #jruby
ipproxy[m] has joined #jruby
shellac has joined #jruby
travis-ci has joined #jruby
<travis-ci> jruby/jruby (ruby-2.6:7cd785c by Charles Oliver Nutter): The build is still failing. https://travis-ci.org/jruby/jruby/builds/667157624 [194 min 23 sec]
travis-ci has left #jruby [#jruby]
travis-ci has joined #jruby
<travis-ci> jruby/jruby (ruby-2.6:f5377ea by Charles Oliver Nutter): The build is still failing. https://travis-ci.org/jruby/jruby/builds/667158530 [189 min 19 sec]
travis-ci has left #jruby [#jruby]
travis-ci has joined #jruby
travis-ci has left #jruby [#jruby]
<travis-ci> jruby/jruby-openssl (master:6f91360 by Karol Bucek): The build has errored. (https://travis-ci.org/jruby/jruby-openssl/builds/667216095)
lucasb has joined #jruby
olleolleolle has quit [Ping timeout: 264 seconds]
ang-st has quit [Ping timeout: 240 seconds]
ang-st has joined #jruby
olleolleolle has joined #jruby
xardion has quit [Remote host closed the connection]
xardion has joined #jruby
<headius[m]> oh baby, down to 133 spec failures for 2.6
<headius[m]> I knocked out most of the Time.new timezone stuff last night
<headius[m]> need to fill in some blanks today
shellac has quit [Ping timeout: 250 seconds]
<headius[m]> I hate working on Time
<headius[m]> at least I have coffee
sagax has quit [Read error: Connection reset by peer]
shellac has joined #jruby
<byteit101[m]> On a fresh-ish clone, I ran mvn -Pbootstrap, then `bin/jruby spec/mspec/bin/mspec ci spec/java_integration/types/extension_spec.rb` and I'm now getting `NameError: cannot load Java class java_integration.fixtures.ProtectedInstanceMethod` (the java class used by that test). Is there something I missed doing?
shellac has quit [Quit: Computer has gone to sleep.]
travis-ci has joined #jruby
travis-ci has left #jruby [#jruby]
<travis-ci> jruby/jruby (ruby-2.6:929767e by Charles Oliver Nutter): The build was canceled. https://travis-ci.org/jruby/jruby/builds/667408048 [-4 min 11 sec]
<headius[m]> byteit101: you need to include the classpath when calling JRuby and it's not an mspec spec, it's rspec
<headius[m]> just running rspec may work ok, I don't remember if the spec helper sets up classpath or not
<headius[m]> I think it does
<byteit101[m]> mspec is what the building.md says, does that need to be updated?
<headius[m]> it says to use that for JI specs?
<headius[m]> it should not... only spec/ruby are mspec specs
<headius[m]> yeah it's talking about literally "Ruby specs", aka mspec-based specs under spec/ruby
<byteit101[m]> Ah!
<headius[m]> none of the other specs under spec/ use mspec
<byteit101[m]> just one file
<headius[m]> that's a bit confusing I guess
<byteit101[m]> How do I run those specs then?
<headius[m]> it could be clarified in BUILDING.md for sure
<byteit101[m]> bin/jruby -S rspec spec/java_integration/types/extension_spec.rb gives me similar errors about the classpath, what sets that?
travis-ci has joined #jruby
travis-ci has left #jruby [#jruby]
<travis-ci> jruby/jruby (ruby-2.6:42cfa43 by Charles Oliver Nutter): The build is still failing. https://travis-ci.org/jruby/jruby/builds/667408219 [195 min 58 sec]
<byteit101[m]> Aha! `bin/jruby -S rake spec:ji`
shellac has joined #jruby
ur5us has joined #jruby
<headius[m]> ok so spec_helper is not setting up classpath properly
<headius[m]> we should move that out of the rake task into the helper
<headius[m]> sorry I'm trying to get this blasted 2.6 work done so not watching Riot closely 😺
<headius[m]> and on that note... Time specs are green with maybe a dozen tags related to missing error cases and some weird edges
<headius[m]> ooo so close to sub-100 fails... 103 now
sagax has joined #jruby
travis-ci has joined #jruby
<travis-ci> jruby/jruby (ruby-2.6:33285cd by Charles Oliver Nutter): The build is still failing. https://travis-ci.org/jruby/jruby/builds/667430297 [193 min 6 sec]
travis-ci has left #jruby [#jruby]
_whitelogger has joined #jruby
_whitelogger has joined #jruby
<olleolleolle[m]1> Hi, I added JRuby 9.1 and 9.2 to a codebase w/ shenanigans: Flexmock https://travis-ci.org/github/doudou/flexmock/builds/667447646 shows 9.1 passing, while 9.2 does not. `NoMethodError: undefined method `allocate' for TestNewInstances::Dog:Class` NoMethodError: undefined method `new'
<olleolleolle[m]1> Am also a bit curious about the undefined method `coverage' for #<SimpleCov::SourceFile:0x33197c2f> in the Coveralls hook after that, never seen that.
_whitelogger has joined #jruby
<headius[m]> shenanigans! ☘️
<headius[m]> I'm not sure about the coverage thing... don't know how SimpleCov is doing its coverage gathering but I would assume it's using 'coverage' library which we mostly support
<headius[m]> the allocate and new thing are interesting
<olleolleolle[m]1> The weird thing re: coverage - 9.1.17.0 works with that
<headius[m]> ah
<headius[m]> I think this is a known issue with prepends in singleton classes
<headius[m]> the eventual logic that adds this proxy method adds it via prepending a module into which the method has been defined
<headius[m]> I think this is the same issue: https://github.com/jruby/jruby/issues/4678
<olleolleolle[m]1> Good memory/find
<headius[m]> so yeah, I keep meaning to prioritize that but it involves doing a lot of nasty step debugging through method dispatch
<olleolleolle[m]1> The gnarliest depths.
<olleolleolle[m]1> PS: The jruby version in this channel's Topic is "now old".
<headius[m]> curses!
<headius[m]> enebo: you did the IRC topic?
shellac has quit [Quit: Computer has gone to sleep.]
<byteit101[m]> I have a working POC of a fix for https://github.com/jruby/jruby/issues/4165 (concrete types become_java! with field and signature support on concrete types), and I have some questions about implementation details. What's the best way to review? Should I create a new PR?
<headius[m]> yes PR
<headius[m]> make a WIP PR and we can discuss there
<byteit101[m]> ok
shellac has joined #jruby
shellac has quit [Client Quit]
shellac has joined #jruby
<enebo[m]> headius: no I did not...I actually forgot about irc :|
<headius[m]> for shame
<byteit101[m]> enebo: oh, the aformentioned PR/issue will mean we can dump jrubyfx-fxmlloader for java's native FXMLLoader in jrubyfx
<headius[m]> ok another round of things passing... all new Kernel stuff is good
<headius[m]> well not all
<headius[m]> all other than exception: keyword for numeric conversions, which amounts to a whopping 51 failures out of the remaining < 90
<headius[m]> I think those need to get fixed but they're a lot of specs for a few changes
<headius[m]> going to let this run in CI and take a break for a bit
ur5us has quit [Remote host closed the connection]
ur5us has joined #jruby
lucasb has quit [Quit: Connection closed for inactivity]
travis-ci has joined #jruby
<travis-ci> jruby/jruby (ruby-2.6:b9d832c by Charles Oliver Nutter): The build is still failing. https://travis-ci.org/jruby/jruby/builds/667477616 [190 min 0 sec]
travis-ci has left #jruby [#jruby]
shellac has quit [Quit: Computer has gone to sleep.]