06:29 <venkatkms[m]> @headius: forgot to add that argumenterror exists in 9.2.9 indy as well

06:31 <venkatkms[m]> We are using ar-jdbc 1.3.25 which i think is a couple of point releases below in that series of 1.3.

15:39 <fidothe> @headius[m] the reappearance of #5585 is actually worse 😭 - it used to only fail on JDK > 8, now it fails on 8 as well on 9.2.10/9.2.11.1. Have a test written, just building master to figure out if it works there or not.

15:49 <fidothe> @headius[m]

15:49 <fidothe> @headius[m] test added: https://github.com/jruby/jruby/pull/6198. Fails under master still, alas

20:08 <headius[m]> fidothe: I see the problem... we don't bind methods on non-public classes

20:09 <headius[m]> typically we have started taking the approach that if you couldn't call it from Java you can't call it from Ruby

20:12 <headius[m]> the abstract superclass is irrelevant...if the method is on the subclass it still doesn't bind because that one isn't public either

20:12 <headius[m]> fidothe: what's your use case that breaks because of this?

20:13 <headius[m]> I'm wondering why you need to call an abstract method on a non-public class

20:16 <headius[m]> hmm I see a flaw in our logic though

20:16 <headius[m]> I think you should be able to call a non-public superclass's public methods from a public child class

20:32 <fidothe> @headius[m] calling https://www.saxonica.com/documentation9.9/index.html#!javadoc/net.sf.saxon.s9api/AbstractXsltTransformer@setInitialMode

20:34 <fidothe> which is an important method exposed via https://www.saxonica.com/documentation9.9/index.html#!javadoc/net.sf.saxon.s9api/Xslt30Transformer

20:35 <fidothe> I realised that the fixture inheriting class should have had public explicitly set on it

20:35 <fidothe> corrected and pushed

20:36 <fidothe> In Saxon `AbstractXsltTransformer` is, um, `abstract`. `Xslt30Transfomer ` is explicitly marked public

20:37 <travis-ci> jruby/jruby (master:e96dce6 by Charles Oliver Nutter): The build has errored. https://travis-ci.org/jruby/jruby/builds/681666788 [146 min 5 sec]

20:38 <headius[m]> ugh

20:47 <fidothe> @headius[m] Here's another attempt at the explanation: I'm calling the method on an instance of the public class Xslt30Transformer, but it's defined on the abstract class AbstractXsltTransformer (which Xslt30Transformer inherits from). There are two concrete classes which inherit from AbstractXsltTransformer, one for explict XSLT 3-specific stuff, and the other for legacy, XSLT 2 behaviour. There's a lot of methods in

20:47 <fidothe> common that are implemented in the AbstractXsltTransformer class

20:47 <headius[m]> yeah I dug into that library and it's the thing I suspected

20:48 <headius[m]> that Xslt30 class is public and inherits public methods from a non-public superclass

20:48 <fidothe> aha

20:48 <fidothe> i can rename the test to reflect that

20:48 <headius[m]> our logic does not add methods from non-public superclasses but this is wrong if the subclass is public and because that exposes the

20:48 <headius[m]> them

20:49 <headius[m]> er that but in English

20:49 <headius[m]> I have a patch that works but we'll have to discuss the impact of it and if this is the right tweaked logic

20:51 <fidothe> if I can help with more tests or poking, let me know

20:51 <fidothe> right now i need to sleep

20:52 <headius[m]> ok

20:54 <headius[m]> enebo kares https://github.com/jruby/jruby/pull/6199

20:54 <headius[m]> fidothe: that's the fix, you can test that branch when you have time

21:22 <travis-ci> jruby/jruby (try_handles_again:2c92824 by Charles Oliver Nutter): The build has errored. https://travis-ci.org/jruby/jruby/builds/681679664 [143 min 29 sec]