kaspter has quit [Remote host closed the connection]
kaspter has joined #linux-rockchip
kaspter has quit [Ping timeout: 246 seconds]
kaspter has joined #linux-rockchip
kevery has joined #linux-rockchip
stikonas has quit [Ping timeout: 252 seconds]
kaspter has quit [Ping timeout: 265 seconds]
kaspter has joined #linux-rockchip
camus has joined #linux-rockchip
kaspter has quit [Ping timeout: 265 seconds]
camus is now known as kaspter
vstehle has quit [Ping timeout: 265 seconds]
chewitt has quit [Ping timeout: 265 seconds]
kaspter has quit [Ping timeout: 265 seconds]
kaspter has joined #linux-rockchip
LargePrime has quit [Quit: Leaving]
ifbizo_ has joined #linux-rockchip
<kevery>
sigmaris: anarsoul: I have sync with my colleague, rockchip bl31.elf in rkbin do open all the power domain before reboot, so I believe this would be the better solution for it can resolve issue on all the rk3399 boards instead of add one by one in U-Boot.
ifbizo has quit [Remote host closed the connection]
camus has joined #linux-rockchip
kaspter has quit [Ping timeout: 268 seconds]
camus is now known as kaspter
<anarsoul>
kevery: sounds good
<anarsoul>
kevery: could you push the change into upstream ATF?
ifbizo has joined #linux-rockchip
ifbizo_ has quit [Ping timeout: 260 seconds]
ifbizo has quit [Remote host closed the connection]
ifbizo has joined #linux-rockchip
<kevery>
Yes, I can do that.
<anarsoul>
thanks
<kevery>
and about your another patch for ATF, could you help me to check some flow?
kaspter has quit [Remote host closed the connection]
kaspter has joined #linux-rockchip
<anarsoul>
kevery: what do you want to check with it?
<kevery>
Could you check the plat_param_from_bl2 in params_early_setup() at plat/rockchip/common/params_setup.c, it should be 0/NULL if this is from U-Boot SPL.
<anarsoul>
IIRC it is
<anarsoul>
oh, hold on
<anarsoul>
kevery: shouldn't it be a pointer to fdt blob?
<kevery>
This GPIOs only work for rk3399 chromebook, and other rk3399 boards should not go into this flow, when ATF init with plat_param_from_bl2 which is NULL, the related IO is not init, and rockchip_soc_soft_reset() should go to soc_global_soft_reset().
<anarsoul>
kevery: the problem that my patch fixes is that pointers to GPIOs are always valid
<anarsoul>
so it doesn't matter whether they're passed from bl2 or not
<anarsoul>
it just calls plat_get_rockchip_gpio_reset() and checks whether it returns NULL or not
<anarsoul>
but it returns pointer to static variable which is never NULL
<kevery>
There is a config in U-Boot to decide if use a fdt or not: CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y
<anarsoul>
right, so it should be NULL
<anarsoul>
why do you want me to verify it?
<kevery>
I think for most of the rk3399 board, this macro is enabled.
<kevery>
1) If this is NULL, 2) the ATF must not init reset gpio, 3) when reboot callback, the program should not go to gpio reset.
<anarsoul>
kevery: that's correct, but check ATF code. It uses static variables (e.g. static struct bl_aux_gpio_info rst_gpio;) for reset and poweroff gpios
<kevery>
I want to make clear about what is correct/expect work flow for the reboot process, although I'm not sure which step may be wrong now.
<anarsoul>
plat_get_rockchip_gpio_reset() just returns &rst_gpio which is guaranteed to be not NULL
<anarsoul>
rockchip_soc_soft_reset() calls plat_get_rockchip_gpio_reset() and uses gpio if it's not NULL (always true without my patch) otherwise it fallbacks to soc_global_soft_reset()
<anarsoul>
due to bug introduced by c1185ffde17c ("plat/rockchip: Switch to use new common BL aux parameter library") plat_get_rockchip_gpio_reset() always returns non-NULL pointer, even if GPIO is not initialized
ifbizo has quit [Remote host closed the connection]
ifbizo has joined #linux-rockchip
<kevery>
I can understand now, rockchip bl31 does not include patch "c1185ffd plat/rockchip: Switch to use new common BL aux parameter library", wo rockchip bl31.bin works correct.
<kevery>
I add review comment +1 for your ATF patch.
<anarsoul>
thanks
kaspter has quit [Remote host closed the connection]
kaspter has joined #linux-rockchip
ifbizo has quit [Remote host closed the connection]
ifbizo has joined #linux-rockchip
ldevulder__ has joined #linux-rockchip
ldevulder_ has quit [Ping timeout: 276 seconds]
vstehle has joined #linux-rockchip
ifbizo has quit [Remote host closed the connection]
ifbizo has joined #linux-rockchip
ifbizo has quit [Remote host closed the connection]
ifbizo has joined #linux-rockchip
chewitt has joined #linux-rockchip
vstehle has quit [Ping timeout: 240 seconds]
vstehle has joined #linux-rockchip
ifbizo has quit [Remote host closed the connection]
ifbizo has joined #linux-rockchip
ifbizo has quit [Remote host closed the connection]
ifbizo has joined #linux-rockchip
ifbizo_ has joined #linux-rockchip
ifbizo has quit [Remote host closed the connection]
ldevulder__ is now known as ldevulder
matthias_bgg has joined #linux-rockchip
ifbizo_ has quit [Remote host closed the connection]
<mmind00>
kevery anarsoul: just reading the backlog ... I don't think CONFIG_SPL_ATF_NO_PLATFORM_PARAM should only be used in very rare cases ... in most cases we want u-boot to hand the dtb over to atf, for example to determine the uart port and rate
ldevulder_ has joined #linux-rockchip
<mmind00>
ok, lets do that again ... CONFIG_SPL_ATF_NO_PLATFORM_PARAM _should_ only be used in rare cases
<mmind00>
(without the "I don't think")
ldevulder has quit [Ping timeout: 246 seconds]
cristian_c has quit [Ping timeout: 246 seconds]
inode has joined #linux-rockchip
inode has quit [Quit: ]
field^Zzz4 has joined #linux-rockchip
ldevulder_ is now known as ldevulder
drrty has joined #linux-rockchip
lkcl has quit [Ping timeout: 265 seconds]
wadim_ has quit [Quit: Leaving.]
vagrantc has joined #linux-rockchip
matthias_bgg has quit [Ping timeout: 245 seconds]
lkcl has joined #linux-rockchip
begin has joined #linux-rockchip
lkcl has quit [Ping timeout: 265 seconds]
lkcl has joined #linux-rockchip
chewitt has quit [Quit: Zzz..]
<anarsoul>
mmind00: someone needs to test it and fix bugs if there're any
vagrantc has quit [Quit: leaving]
vicencb has joined #linux-rockchip
drrrty has joined #linux-rockchip
drrty has quit [Ping timeout: 276 seconds]
<mmind00>
anarsoul: at least on px30 the dtb handover works nicely ... and I get my non-standard uart ;-)
jaganteki has quit [Remote host closed the connection]